Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp7821740ioo; Fri, 3 Jun 2022 14:29:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3s1+EjcGSIbhJ4zli8Ca4HdovmBufmI8yUy1JRN7P1bW0XsNYxYhh/vdT5GBRojku+7+o X-Received: by 2002:a17:90b:1651:b0:1e8:3e9c:801 with SMTP id il17-20020a17090b165100b001e83e9c0801mr3647865pjb.235.1654291750586; Fri, 03 Jun 2022 14:29:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654291750; cv=none; d=google.com; s=arc-20160816; b=RNOWBZfpYKsuwiOnSbyNsSShbvFUYexTWylM2DWCJPaDs/d6B0acsmE0FSA+Z2Xy7+ k7U1OWCJyA2EMoblhFFRhDJT4jo9htBe3+J7x1WGiPoK12C3XK60qg146fVHE80kJSxU WbBhPZ213HltL3Ca6SwSGmHDLUYT+jBM6oDqFcZYUtxiunzjjztII2k5L9ClpTKMdpKd vjt9Fd7iSxdnkgHOMkUGyXUI2jnemrUwRjJCU/qk2hLfAkzdml2jWaugVOuDZbiDp3si 2Bn5tbqzkysYWluhdfY5g2lZ+Htt6YkjjFsaxcjVyGUNT46ZHY3HSjHpRsILJTtP2Jzs SuRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=yS2e1dxmmeKupF2QgFAjrPDs9X47guxJUtZ2ZyMIH68=; b=c3FUZExypcrUp4+r+g49PV6ZNWHyGku7PkWatSTfXFjrhb9Su/mx8L6PJx8Y7M6Bg7 QuQynOwQ55m6B+P1x80l3qta5s994lcvYN4gUkl4eaV7aIN0CRKaWh4lSHYzgqQyMFhd jaYPfSOzSLWY1uwbB58P9qTUD7ZLj8wfXY9WfmpvCW59/RnQbuf021crqbWLTbh253Po g/6sGR9czWC8NGaLNXSQ5mpoi0h/nX+wkFmd6vQP6qE6m7UmFP6gP04tb2LMqbt8xc99 kGqulilpkJxFWzdgnHWKuxMnknaVDOxyw4V/0Z/wydgJ5vOR8pXdE7d2zs1OqxAyKdQY cBIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b3-20020a63d303000000b003f74c931d14si10806304pgg.586.2022.06.03.14.28.58; Fri, 03 Jun 2022 14:29:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236192AbiFBOsi (ORCPT + 99 others); Thu, 2 Jun 2022 10:48:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236160AbiFBOsg (ORCPT ); Thu, 2 Jun 2022 10:48:36 -0400 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED6571021F8; Thu, 2 Jun 2022 07:48:34 -0700 (PDT) Received: by mail-oi1-f181.google.com with SMTP id s8so1523317oib.6; Thu, 02 Jun 2022 07:48:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yS2e1dxmmeKupF2QgFAjrPDs9X47guxJUtZ2ZyMIH68=; b=e+FKXbL3dPIceD5Qup+3vVo/s/l44jcBRxyYlHx4EEhCM0wKMcai+oBMPhN2hpssmH Ebwp54Z1mmUH2kjGGAxrF1NbjhizKG11IEsoJFRvwO2XA6SGsVRcoorrsdnScoAuXv9B l2m/MheJVOxcVi8JDFCR0jDdLOlsBRwFGYh8WPeFx7CCdKtPgF07z7vUloUyT6pXL81n 0DE+dYo7hSrtVym5+TF9Ie06Bnm7wbPgbmNXowO51JZpicdl+pN3oVi68VOyYezZJ3cp 28Mp+gfzKiHGzXqwN3/CqwP4D/KJRxN5uHvf6LQbIGJagVpm+iM+YjE4NHmVphGsozhd NiGA== X-Gm-Message-State: AOAM531Yk4MTI1ptZwfGENYENbo35aj374+K+2OHeNLV0CL3DPr8vvnl Qan4R9Lm6MIH31V3J60UBA== X-Received: by 2002:aca:544:0:b0:32e:385d:1fc0 with SMTP id 65-20020aca0544000000b0032e385d1fc0mr1584841oif.241.1654181314183; Thu, 02 Jun 2022 07:48:34 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id g26-20020a4adc9a000000b004190d6a2bbesm2330725oou.28.2022.06.02.07.48.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jun 2022 07:48:33 -0700 (PDT) Received: (nullmailer pid 2294643 invoked by uid 1000); Thu, 02 Jun 2022 14:48:33 -0000 Date: Thu, 2 Jun 2022 09:48:33 -0500 From: Rob Herring To: Tanmay Shah Cc: openamp-system-reference@lists.openampproject.org, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, krzk+dt@kernel.org, michal.simek@xilinx.com, ben.levinsky@xilinx.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 1/6] dt-bindings: remoteproc: Add Xilinx RPU subsystem bindings Message-ID: <20220602144833.GA2293233-robh@kernel.org> References: <20220601162111.3505458-1-tanmay.shah@xilinx.com> <20220601162111.3505458-2-tanmay.shah@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220601162111.3505458-2-tanmay.shah@xilinx.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 01, 2022 at 09:21:07AM -0700, Tanmay Shah wrote: > Xilinx ZynqMP platform has dual-core ARM Cortex R5 Realtime Processing > Unit(RPU) subsystem. This patch adds dt-bindings for RPU subsystem > (cluster). > > Signed-off-by: Tanmay Shah > --- > > Changes in v7: > - Add minItems in sram property > > Changes in v6: > - Add maxItems to sram and memory-region property > > Changes in v5: > - Add constraints of the possible values of xlnx,cluster-mode property > - fix description of power-domains property for r5 core > - Remove reg, address-cells and size-cells properties as it is not required > - Fix description of mboxes property > - Add description of each memory-region and remove old .txt binding link > reference in the description > > Changes in v4: > - Add memory-region, mboxes and mbox-names properties in example > > Changes in v3: > - None > > .../bindings/remoteproc/xlnx,r5f-rproc.yaml | 130 ++++++++++++++++++ > include/dt-bindings/power/xlnx-zynqmp-power.h | 6 + > 2 files changed, 136 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/xlnx,r5f-rproc.yaml > > diff --git a/Documentation/devicetree/bindings/remoteproc/xlnx,r5f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/xlnx,r5f-rproc.yaml > new file mode 100644 > index 000000000000..89ce9ec10163 > --- /dev/null > +++ b/Documentation/devicetree/bindings/remoteproc/xlnx,r5f-rproc.yaml > @@ -0,0 +1,130 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/remoteproc/xlnx,r5f-rproc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xilinx R5F processor subsystem > + > +maintainers: > + - Ben Levinsky > + - Tanmay Shah > + > +description: | > + The Xilinx platforms include a pair of Cortex-R5F processors (RPU) for > + real-time processing based on the Cortex-R5F processor core from ARM. > + The Cortex-R5F processor implements the Arm v7-R architecture and includes a > + floating-point unit that implements the Arm VFPv3 instruction set. > + > +properties: > + compatible: > + const: xlnx,zynqmp-r5fss > + > + xlnx,cluster-mode: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1, 2] > + description: | > + The RPU MPCore can operate in split mode(Dual-processor performance), Safety > + lock-step mode(Both RPU cores execute the same code in lock-step, > + clock-for-clock) or Single CPU mode (RPU core 0 can be held in reset while > + core 1 runs normally). The processor does not support dynamic configuration. > + Switching between modes is only permitted immediately after a processor reset. > + If set to 1 then lockstep mode and if 0 then split mode. > + If set to 2 then single CPU mode. When not defined, default will be lockstep mode. > + > +patternProperties: > + "^r5f-[a-f0-9]+$": > + type: object > + description: | > + The RPU is located in the Low Power Domain of the Processor Subsystem. > + Each processor includes separate L1 instruction and data caches and > + tightly coupled memories (TCM). System memory is cacheable, but the TCM > + memory space is non-cacheable. > + > + Each RPU contains one 64KB memory and two 32KB memories that > + are accessed via the TCM A and B port interfaces, for a total of 128KB > + per processor. In lock-step mode, the processor has access to 256KB of > + TCM memory. > + > + properties: > + compatible: > + const: xlnx,zynqmp-r5f > + > + power-domains: > + description: RPU core PM domain specifier > + maxItems: 1 > + > + mboxes: > + minItems: 1 > + items: > + - description: mailbox channel to send data to RPU > + - description: mailbox channel to receive data from RPU > + > + mbox-names: > + minItems: 1 > + items: > + - const: tx > + - const: rx > + > + sram: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + minItems: 1 > + maxItems: 8 See my comments on v6. > + description: | > + phandles to one or more reserved on-chip SRAM regions. Other than TCM, > + the RPU can execute instructions and access data from, the OCM memory, > + the main DDR memory, and other system memories. > + > + The regions should be defined as child nodes of the respective SRAM > + node, and should be defined as per the generic bindings in, > + Documentation/devicetree/bindings/sram/sram.yaml > + > + memory-region: > + description: | > + List of phandles to the reserved memory regions associated with the > + remoteproc device. This is variable and describes the memories shared with > + the remote processor (e.g. remoteproc firmware and carveouts, rpmsg > + vrings, ...). This reserved memory region will be allocated on DDR memory. > + minItems: 1 > + maxItems: 8 > + items: > + - description: region used for RPU firmware image section > + - description: vdev buffer > + - description: vring0 > + - description: vring1 > + additionalItems: true > + > + required: > + - compatible > + - power-domains > + > + unevaluatedProperties: false > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + r5fss: r5fss { > + compatible = "xlnx,zynqmp-r5fss"; > + xlnx,cluster-mode = <1>; > + > + r5f-0 { > + compatible = "xlnx,zynqmp-r5f"; > + power-domains = <&zynqmp_firmware 0x7>; > + memory-region = <&rproc_0_fw_image>, <&rpu0vdev0buffer>, <&rpu0vdev0vring0>, <&rpu0vdev0vring1>; > + mboxes = <&ipi_mailbox_rpu0 0>, <&ipi_mailbox_rpu0 1>; > + mbox-names = "tx", "rx"; > + }; > + > + r5f-1 { > + compatible = "xlnx,zynqmp-r5f"; > + power-domains = <&zynqmp_firmware 0x8>; > + memory-region = <&rproc_1_fw_image>, <&rpu1vdev0buffer>, <&rpu1vdev0vring0>, <&rpu1vdev0vring1>; > + mboxes = <&ipi_mailbox_rpu1 0>, <&ipi_mailbox_rpu1 1>; > + mbox-names = "tx", "rx"; > + }; > + }; > +... > diff --git a/include/dt-bindings/power/xlnx-zynqmp-power.h b/include/dt-bindings/power/xlnx-zynqmp-power.h > index 0d9a412fd5e0..618024cbb20d 100644 > --- a/include/dt-bindings/power/xlnx-zynqmp-power.h > +++ b/include/dt-bindings/power/xlnx-zynqmp-power.h > @@ -6,6 +6,12 @@ > #ifndef _DT_BINDINGS_ZYNQMP_POWER_H > #define _DT_BINDINGS_ZYNQMP_POWER_H > > +#define PD_RPU_0 7 > +#define PD_RPU_1 8 > +#define PD_R5_0_ATCM 15 > +#define PD_R5_0_BTCM 16 > +#define PD_R5_1_ATCM 17 > +#define PD_R5_1_BTCM 18 > #define PD_USB_0 22 > #define PD_USB_1 23 > #define PD_TTC_0 24 > -- > 2.25.1 > >