Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp7966600ioo; Fri, 3 Jun 2022 18:23:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvqKvoI87+Z8VhR2LPDhRWcGvwKlepdMpg5qEx3Nu3k58A2KoBiiqJjy5c2JP5SNtgFmnQ X-Received: by 2002:a17:90b:38c8:b0:1e8:5202:f6d4 with SMTP id nn8-20020a17090b38c800b001e85202f6d4mr1243890pjb.149.1654305835109; Fri, 03 Jun 2022 18:23:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654305835; cv=none; d=google.com; s=arc-20160816; b=L5WyiMdl1LDABzXOVwESoOFsAogYmIrpvUD+sKdvisdBQ7yXUZJCWz5EMDGaoVv1E3 ZDowt9nNvtGBtxCX8hfj24oTL3DZezqE25+nmy32S6ToQyjSX1nUzuoZTQ3QyALuacvG pj1GfuvKmW5d6yyFLzii+u4WxTLsAwQqmIzvwSUjRZxXTpUHGb0kun6R++1lyWCjcLkl 0yCWKKrKNsNWVjuxmYLYvLYcdkEG8j4DAR0kKWb8fyvkI9Y798QLHoRc98og1APCcRGd +ItJSX1G4/nFwRe6iJzx/2lt0YnJh/cqq3OZNYUyS6knh83VUGf4kDT48xkrt/9P9XPm xGuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=lISSvWak6FLRrO5psSLs6i76bhB1ZmPsSb/17A5+cjY=; b=VTsDuF7iR3TiLn9ajkkXCQM6g6xgn6HGdbO8rY80V4tb13L2jLQ2zLmtBzabv3ZebK JaF7LJpBUdca6jD/18z/eMA4DwiNZ4txcJ0ykhAJ4uxGlTX6qEaWcq3r7kUh1QZhEHy4 Vp40yTe1hWneL5CqajCIcjnzcUDDZDQOtJEDHPi5neRQPxv+0IlVejp+Az+2CjrZtSBx GUsNcQNrv0m1x1x8DU/Fo1lrmXQZ3oWD2cniBqfEasZFPc4fZ5+fTBhOI4czEQBJ8iou 1fvttoUKgVI2txHgoLCdzpDSYRVmGMArkgfyndioOOHwUVTvYpF2bWrdQrxhoixuu9Zb qP8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=hTSUCHd4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u71-20020a63854a000000b003fd1b36af89si4668064pgd.801.2022.06.03.18.23.43; Fri, 03 Jun 2022 18:23:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=hTSUCHd4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245047AbiFCODK (ORCPT + 99 others); Fri, 3 Jun 2022 10:03:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244772AbiFCOC6 (ORCPT ); Fri, 3 Jun 2022 10:02:58 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 352EF25C65; Fri, 3 Jun 2022 07:02:57 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id g184so7308267pgc.1; Fri, 03 Jun 2022 07:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=lISSvWak6FLRrO5psSLs6i76bhB1ZmPsSb/17A5+cjY=; b=hTSUCHd4eqE/1RDHL5S1oKpSN5h9bqgrO29tfXVGaKvp9x1/Z4ByT9XMzKKptzqGLY oyfY0K1HQZX2lVTpm57VOYoOoipmY+D536vd5rWWB9+5ew2w2modqlK6G4bT3y/GErbB qZ/KeSFbiQZra88y6VdoUUkkOAQBCCYBVh0nuvZ3N1v0IkBFz6xawSjJj7Zgb1obJ8V1 5qkoNXvybmeuS/QZwnjGcpYQ9TuVJlgnEm25XqK19WndRB4dIcJgZ6qEYrbcrAiw8OQ+ k/RQnYB44SZxrUuwbjif6AUTBco2HS7QNQR1N60WNVM4bLtpFzmJChEO7SqlRHZpHYp4 N55A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=lISSvWak6FLRrO5psSLs6i76bhB1ZmPsSb/17A5+cjY=; b=Y6sZapYOPHdWvCl+wpJSCDyG/TegVZbywcMyFfDbt8c/L9CMyIEy2w+/WISVz0rxZL 84AAg8PK9XTpMZdpjKUjgbFG8RvyLqQtTh/IUbCle88QZi5GacTKfcjcp/a6Oo45iKPy w5/lALaAgpkNmcrKqsF7am5lXoX0UYpNGH69EyqPkN1IW+YMisEHZtIOewgr2asKVzci l+5kSY6fiaqas50mdAYTI6n1/54QQr5YVkQwoSIyQhThIv5arBglEdsg1501GDM8tbR0 39qaQ3DIYQGC7wWm3y0XWKWXrF+brUa8LzIZymqEH4klKagOwkhz0EliPeXOaO23yfsF QqfQ== X-Gm-Message-State: AOAM531m9Dym9q8LRh91AF/WYK/GhLZI0PTOeC5rAxiFyskgZa1bnqwB riMCD6j9VCKYp4seAnqORBaBGF7ZJR6Ceer/GxY= X-Received: by 2002:a05:6a00:2396:b0:51b:de97:7efe with SMTP id f22-20020a056a00239600b0051bde977efemr4521830pfc.8.1654264976753; Fri, 03 Jun 2022 07:02:56 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id n36-20020a635924000000b003faebbb772esm5663265pgb.25.2022.06.03.07.02.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jun 2022 07:02:56 -0700 (PDT) From: Miaoqian Lin To: Felipe Balbi , Greg Kroah-Hartman , Vladimir Zapolskiy , Miaoqian Lin , Jakob Koschel , Arnd Bergmann , Roland Stigge , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: gadget: lpc32xx_udc: Fix refcount leak in lpc32xx_udc_probe Date: Fri, 3 Jun 2022 18:02:44 +0400 Message-Id: <20220603140246.64529-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. of_node_put() will check NULL pointer. Fixes: 24a28e428351 ("USB: gadget driver for LPC32xx") Signed-off-by: Miaoqian Lin --- drivers/usb/gadget/udc/lpc32xx_udc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c index 6117ae8e7242..cea10cdb83ae 100644 --- a/drivers/usb/gadget/udc/lpc32xx_udc.c +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c @@ -3016,6 +3016,7 @@ static int lpc32xx_udc_probe(struct platform_device *pdev) } udc->isp1301_i2c_client = isp1301_get_client(isp1301_node); + of_node_put(isp1301_node); if (!udc->isp1301_i2c_client) { return -EPROBE_DEFER; } -- 2.25.1