Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 3 Jun 2022 16:23:51 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Markuss Broks <markuss.broks@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Marijn Suijten <marijn.suijten@somainline.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@somainline.org>,
        Song Qiang <songqiang1304521@gmail.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>, linux-iio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v5 0/5] Add support for ToF sensor on Yoshino platform
Message-ID: <20220603162351.69056bdf@jic23-huawei>
In-Reply-To: <20220523175344.5845-1-markuss.broks@gmail.com>
References: <20220523175344.5845-1-markuss.broks@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 23 May 2022 20:53:39 +0300
Markuss Broks <markuss.broks@gmail.com> wrote:

> This series adds support for the ToF proximity sensor installed on
> Yoshino devices. As part of this series, support handling the reset
> GPIO and VDD supply by the VL53L0X driver. Also stop hardcoding the
> interrupt type, since on Yoshino devices it seems that edge triggering
> doesn't work properly.
> 
> Tested on Sony Xperia XZ1 (poplar).
> 
> Cc: Konrad Dybcio <konrad.dybcio@somainline.org>
> Cc: Marijn Suijten <marijn.suijten@somainline.org>
> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Patches 1-4 applied to the togreg branch of iio.git.

Note I plan to rebase that tree after the char-misc (and hence IIO tree)
has been merged with mainline, so for now it is only pushed out as testing
so that 0-day can see if it can find anything we missed.

Thanks,

Jonathan

> 
> v2:
> - Fix a nasty issue: turns out grouping the pinctrl makes it not apply,
> which was the main cause of edge interrupts not working correctly and
> having to use level interrupts, which caused a large amount of false
> detections.
> - handle the irq type more gracefully: if it's not provided, default
> to falling edge, but if it's provided, then use the provided one.
> v3:
> - add irq.h header (forgot to commit)
> - reword commit message (already initialized -> pre-initialized)
> v4:
> - reorder powering on and power off action (Jonathan)
> - sort pinctrls by GPIO number (Konrad)
> v5:
> - "This patch adds..." -> "Add ..." (Krzysztof)
> 
> Markuss Broks (5):
>   dt-bindings: proximity: vl53l0x: Document optional supply and GPIO
>     properties
>   proximity: vl53l0x: Get interrupt type from DT
>   proximity: vl53l0x: Handle the VDD regulator
>   proximity: vl53l0x: Handle the reset GPIO
>   arm64: dts: qcom: msm8998-xperia: Introduce ToF sensor support
> 
>  .../bindings/iio/proximity/st,vl53l0x.yaml    |  5 ++
>  .../dts/qcom/msm8998-sony-xperia-yoshino.dtsi | 34 +++++++++++++
>  drivers/iio/proximity/vl53l0x-i2c.c           | 50 ++++++++++++++++++-
>  3 files changed, 88 insertions(+), 1 deletion(-)
>