Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp7992897ioo; Fri, 3 Jun 2022 19:14:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1RIQLi0xxLfIsT3PKo80Ry8oLcYG33odx+yA/1opUuFb7iNG81gg0fktkacOmDWY5TzDe X-Received: by 2002:a05:6a00:140e:b0:4e1:c81a:625c with SMTP id l14-20020a056a00140e00b004e1c81a625cmr12879554pfu.39.1654308872140; Fri, 03 Jun 2022 19:14:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654308872; cv=none; d=google.com; s=arc-20160816; b=PLzujmJDVJKE8sdjXJdH9br6ikPw52eYaK4cZmHL3SKG6KIE3VrTBI8m8LQOhE8ied moV+L+RQMhnWdtRfw3RrOzKKzvrB78qbiGJaaPMX4Z/bXgMsYyCF+GILg//PBwd89Nk0 Ri4vDyOInCaUBU8GPFbLy3R+oEfHnoor9d+/re+z0p5ie1lo1vEBfHuHzBJW0MPF8yje pOc/8noEwI7jlUlQ1+q+jY0woboQ4OHe4EYPXqJnD7Bx1dTKxRNqEtvww0OlWYj5sRnS zXnhXpzrcwiPKTWnVasNTcnUD4Nc22XePJ0syw0e32KPDVybbM0Ax7em5MvRD0IcrlTn WUAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=G04Itje+nR11qdqrabLmCPEHpOKP/3vXajIK56ZeOLM=; b=BiFqvUxPThJAZnKswLJI1FgK36ITKEE/+QBgRDxLaTXc90/hmx5hubyOFkSOHhV85g rtqUn5k6rfmbWuGojdL+i9kFxV6uf/0cme/Dou3Qi6jf2fheyE2DgWbGhlDOTi7PhDWT UwZLEYxTcGgxdq9gsxoivesG5HXmjJE49lsrUdc9Rp+0N6XYMTzy6ovMUYTaFJThIDAQ mMSacAwTeV/KjeNqQHJsVAjRf8pxN4S0pM5B7/KHgsaNla5bsFfy30S1AAAzsBIlxett /UCvLWGNNcfuA04+r7dl36qSC6gWgG69YAianFbPKSF23/oFs6TNRadF8wHV8HchIOS2 atbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q13-20020a170902dacd00b0016406e6ff4asi115442plx.102.2022.06.03.19.14.17; Fri, 03 Jun 2022 19:14:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244355AbiFCM3a (ORCPT + 99 others); Fri, 3 Jun 2022 08:29:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230159AbiFCM33 (ORCPT ); Fri, 3 Jun 2022 08:29:29 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9A8B3A5DD for ; Fri, 3 Jun 2022 05:29:27 -0700 (PDT) Received: from mail-yw1-f180.google.com ([209.85.128.180]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis) id 1M42X0-1nx6Qf2hgu-0005id for ; Fri, 03 Jun 2022 14:29:25 +0200 Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-2ff7b90e635so80594497b3.5 for ; Fri, 03 Jun 2022 05:29:25 -0700 (PDT) X-Gm-Message-State: AOAM531GB12Cxt/zhpR9+9ZukxdDl20OAVd5I521w5Uc/htBRaiJe5hp mpgXSspAxMYsdWS4zVs0/fVvnBGxQagr+cLakLs= X-Received: by 2002:a81:b03:0:b0:310:1375:fca9 with SMTP id 3-20020a810b03000000b003101375fca9mr3711947ywl.135.1654259364450; Fri, 03 Jun 2022 05:29:24 -0700 (PDT) MIME-Version: 1.0 References: <20220603121543.22884-1-linmq006@gmail.com> In-Reply-To: <20220603121543.22884-1-linmq006@gmail.com> From: Arnd Bergmann Date: Fri, 3 Jun 2022 14:29:07 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] powerpc/spufs: Fix refcount leak in spufs_init_isolated_loader To: Miaoqian Lin Cc: Jeremy Kerr , Arnd Bergmann , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:11JGH4/yWoAlqHenoTIAbnwXfg94/NQPtaPz+P5XvC1cC7CqgRz eNG4zwjhQUOOoP42jyS4C/x4zqFoFcqbLB/WakY7Wqca7Ttf1/0OGs8sYHrbfBc0TcY8FSw /Pp5YjjcUQdGwLsK3KZUZyB/ynpqjZGV7MnjZhlrsdMev33xrYntIvs7djxZkEvU7mEduQZ K3XyStu78DgSgGUGwJluQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:s9divb7K6iU=:W0SAxVrpuuQR7CbQwgI8Ay jNmoYz3ScSyrrjq2RICKdv+umRQoeszPQn/+wRtmEC93uH3k8oCi8IprVNxNUj/J8usbj+e/m isKw5AT139TuGKApKA6Ee0RI6JP4BpTCHgWp/mQocmCGCYDCjc6DiBRGPjFbIwCfmybBZRQN1 OLhsMISql5JXcEWQbuvWGT+GNXBeej8uN47rDYk0vWp9nQiHIqbEwlsX6MA1KZIR0awsd2w4l E4HalFnDKDG7lfEFq4e9bCCJPRY3IR6kDUwT86dTwlCJocFy9pTd+uZOsbNkc925P/WZuCgg5 Yc02Du3OrGsGJPdaQz6JT8nGvhDbOYm7REv0WuY4S13i/TKKNhg3fKlZaautxfnLdKCXa3eh3 ydwmsmNdPXpGwN8Gl9AQD2CPgzh2VR/PVZV5DA01sMJgNN7TceUGUPhIYm/HNXAxGb+cB+g5I j1dbl+057Ge+MTn6+kQz3ZlNbbYtA1+IwXsgFJQtGV6dxagG2XwEGFV05PXep+tbKBj+6Banv XrzpLERhF0nkZARwMjzzyG0J6HmETc8+tRkENmY8KvV38Yz9EiGB3XKE8mbhECT0RVfwpD7gs 8yvF8kegwpjI/ce1Ap3qcY16tCT57z9l4TmFJO8SBXtPFDGNAiYJ2K7RSkGnDZrjnvuXQ/IBL RFgnvGOr0hv3LaAvrX3odkzcVeixwkRmUDkacm2olGqlezhtBoXSGaIj3ehiY3Xln8GUuglMC IyEV/U5TzEVedrG6ijn+OjykzcrtbgC7r4dhgw== X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 3, 2022 at 2:15 PM Miaoqian Lin wrote: > > of_find_node_by_path() returns remote device nodepointer with > refcount incremented, we should use of_node_put() on it when done. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 0afacde3df4c ("[POWERPC] spufs: allow isolated mode apps by starting the SPE loader") > Signed-off-by: Miaoqian Lin Acked-by: Arnd Bergmann