Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp8009535ioo; Fri, 3 Jun 2022 19:48:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5hNa3UH6eky7ctzZuZZ18y3sVESP+TyOt+beHA+vjX5S8aFGws8Ej2guz+SgcTBmrXu6u X-Received: by 2002:a05:6402:f05:b0:42d:d709:b497 with SMTP id i5-20020a0564020f0500b0042dd709b497mr14015503eda.231.1654310924572; Fri, 03 Jun 2022 19:48:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654310924; cv=none; d=google.com; s=arc-20160816; b=PVz+K5UkEoFxZi+teY6HcSbaJ/gZ7ahjfqrW/KiWbaWafrkogo2k88JT2ozYMT91nh Yl5Wbn8c+JQgu4VUdqN9TqjcKyni03u/Euz8M6y5lJPZfr46q0OPNgfJyrRgHdolQ9G7 hTK/XGXNTyxv1j23lWAUDsjlVbOukNOlxgiDSH63ZRInljK5SUQCW//TON9ZnCK/+Sjs II9mp4FPi6ylJ+nU/GQsUH6g1qswJ9utx7hOoZufEw28CnkWWG9kX8W+igGhIMDN0n3x g+RgVPnRz1xJltKYb+mJf/3BU5XnEs1D7xVjtwQnlcuSpYrGh8Dz4yHTxZicDufhE+Nn kWjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:feedback-id :dkim-signature:dkim-signature; bh=lIjU4LaO1rApVvOShyS8GsBVRsoSsVXvjryTJrZtKjg=; b=bMF1lOr7Cd6+YQs5X3wRbsDa1SQ0vYIaNrEeblniDtQzWNGi3gUg7o3tIYV5OmoQz+ DGAINk1wD7ELgkM+Smk5TYK/ubxs53vYJ3iI79l4MW5xQjGWtR8T6pA69cJCYv6Lx+qh p97t8vq5krRbXNh0KafCJx9AjMNSIShZZSuGxVMl6gJXj+X0uiQrD5Yg6W418+DzTlD+ cjnP3tcF2KuFSE4mkmLcZIkXk4b9bPN0wGs5ww8AyjpXlaaCtCZzwg5CQG7ytkHDeD6Q k1cDTVrY22Ce6d/PEwmz0ciSznWt57vW7MfIH/ZiXAYvmTAjwDeHSLmR29ffoHcFUwmi dQPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@irrelevant.dk header.s=fm3 header.b=nYy0O1P4; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b="DWYLET/+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd36-20020a17090762a400b006e07d5f6986si800853ejc.933.2022.06.03.19.48.17; Fri, 03 Jun 2022 19:48:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@irrelevant.dk header.s=fm3 header.b=nYy0O1P4; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b="DWYLET/+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241394AbiFCFtu (ORCPT + 99 others); Fri, 3 Jun 2022 01:49:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241361AbiFCFtM (ORCPT ); Fri, 3 Jun 2022 01:49:12 -0400 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C652011C11; Thu, 2 Jun 2022 22:49:09 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 4D2485C013C; Fri, 3 Jun 2022 01:49:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 03 Jun 2022 01:49:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1654235347; x=1654321747; bh=lI jU4LaO1rApVvOShyS8GsBVRsoSsVXvjryTJrZtKjg=; b=nYy0O1P4Jg3wrrSfTQ i1ZV2JXrHfgfVbbmBZe862UKfJaGUqdX3KZuUZnKHPsAiNp7fsYkCyJj395RHnna NX8ziLucahVzPWgc3eV+EIBy6f5XnqRrdY3QY6OZyY8jLiVSlSptBu1NYNTKKlUg wzli+cpj+QudXBh4uJqCBvKA8Kdd+N5BfJnEwBwTdvNIaO49gwdMfhQ/LOzpDEXM Uyy65GIQqWBls0aVqyiU4Oz4DjMvfp35igT54Es2ef5MtYoq03nPd87EoOb4yDuh 5nLMDaYkvI9HvS6QOFV8eyvpPpAoWvjm0cFflfrgdqlikGx+4jgxIgGXyBfIEIvp Vrtw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1654235347; x=1654321747; bh=lIjU4LaO1rApVvOShyS8GsBVRsoS sVXvjryTJrZtKjg=; b=DWYLET/+XU0wgIpSjFaGJqNfUWigRsswi65wQSs1vnYS zBmqyej4l+7Eyh3eOfJargM2gMrF8Ty9hUZBmIEnAUzfIdKCme9rQoN6z9H6HQxt p5RuAQHXZNlZBNaIwCEJlDz8ldxjqbt+SsZtsxAVdEE2qsAWHyHwj4nrUVHNYlHg qIMAOtpMEaFMyWBSx4uyv2BecJrpOfIeAMML3R8ek7N3IP8/I/D8BPEO8UzmOpAK G1qq8FxEd3OMW6spsu3yk2apr/YJlX5eaUVM0jvBwT0QvAG9lTCs39jaBgrgZbsb y3yqLw+f6f9IAfAQvwYjZWGztIR6IQYZGw+8e8qZcQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrleehgdellecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefmlhgruhhs ucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrghtth gvrhhnpeejgfejfeffvdeuhfeifefhgffgueelhedukeevjeevtdduudegieegteffffej veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehith hssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: Feedback-ID: idc91472f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 Jun 2022 01:49:04 -0400 (EDT) Date: Fri, 3 Jun 2022 07:49:02 +0200 From: Klaus Jensen To: linux-kernel@vger.kernel.org Cc: Brendan Higgins , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, Wolfram Sang , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, Benjamin Herrenschmidt , Joel Stanley , Andrew Jeffery , Klaus Jensen Subject: Re: [PATCH] i2c: aspeed: do not mask SLAVE_MATCH Message-ID: References: <20220602054842.122271-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="H0uRup5aAnlYFzFn" Content-Disposition: inline In-Reply-To: <20220602054842.122271-1-its@irrelevant.dk> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --H0uRup5aAnlYFzFn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Jun 2 07:48, Klaus Jensen wrote: > From: Klaus Jensen >=20 > When commit f9eb91350bb2 ("i2c: aspeed: added slave support for Aspeed > I2C driver") added slave mode support, the SLAVE_MATCH interrupt bit > (bit 7) was not added to INTR_ALL and so will never be set by the Aspeed > I2C controller. >=20 > Fixes: f9eb91350bb2 ("i2c: aspeed: added slave support for Aspeed I2C dri= ver") > Signed-off-by: Klaus Jensen > --- > I am working on slave mode in QEMU and noticed that the device would not > generate the SLAVE_ADDR_RX_MATCH interrupt. This patch fixes it, but I > do not have a spec sheet on the Aspeed, so I am not sure if this is the > intended behavior? >=20 > drivers/i2c/busses/i2c-aspeed.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-asp= eed.c > index 771e53d3d197..7f432babcd72 100644 > --- a/drivers/i2c/busses/i2c-aspeed.c > +++ b/drivers/i2c/busses/i2c-aspeed.c > @@ -86,6 +86,7 @@ > #define ASPEED_I2CD_INTR_ALL \ > (ASPEED_I2CD_INTR_SDA_DL_TIMEOUT | \ > ASPEED_I2CD_INTR_BUS_RECOVER_DONE | \ > + ASPEED_I2CD_INTR_SLAVE_MATCH | \ > ASPEED_I2CD_INTR_SCL_TIMEOUT | \ > ASPEED_I2CD_INTR_ABNORMAL | \ > ASPEED_I2CD_INTR_NORMAL_STOP | \ > --=20 > 2.36.1 >=20 I've been informed that SLAVE_MATCH should always be generated, regardless of INTR_CTRL, so please ignore this patch. --H0uRup5aAnlYFzFn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmKZoMwACgkQTeGvMW1P DemGlAf/aII/yHlSNHBjG7id0U5uz2uhWKpOBXclCdnrJdDhxNxlXN1R0rGlpUP4 1PX6c9dlVwPdyO3xiu6egzUsvwJdQ8i28xjZZldVIYtNKC4ruvEaR/PCjCQGBRzh p5QaZAseo1PoAj1M5JJupcgrs20SSoVWs9Sr0X2qNEaCsCgQ3+E1NXS0qhf+0tp7 DXfw6ICyofMrm8Qmjz6WX6f0+SedpmIKBnzxAgyG5W9a/6jC2tWxNEam/W3bozA9 x412Op9vT2UtrN3jHy6gnJQR+mJfMUTk24kLTk1htmBWyY0HP0lRtFex65EVxozO uuQMHDRxT54gNlrroIl9Rx1qmS3LvQ== =6I9B -----END PGP SIGNATURE----- --H0uRup5aAnlYFzFn--