Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c9542630-065d-0c80-5ad3-2375d526878b@infradead.org>
Date:   Thu, 2 Jun 2022 08:04:01 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] kbuild: show the install image name and path
Content-Language: en-US
To:     Masahiro Yamada <masahiroy@kernel.org>, Keith Busch <kbusch@fb.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Keith Busch <kbusch@kernel.org>
References: <20220602015050.3185028-1-kbusch@fb.com>
 <CAK7LNAQot2kMxmisAE2XP3ukPSGBJkLWWYzrTcjV9exSVQKupQ@mail.gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <CAK7LNAQot2kMxmisAE2XP3ukPSGBJkLWWYzrTcjV9exSVQKupQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/2/22 07:52, Masahiro Yamada wrote:
> On Thu, Jun 2, 2022 at 10:51 AM Keith Busch <kbusch@fb.com> wrote:
>>
>> From: Keith Busch <kbusch@kernel.org>
>>
>> Prior to commit f774f5bb87d13 ("kbuild: factor out the common
>> installation code into"), a 'make install' would print out the install
>> command like:
>>
>>   sh ./arch/x86/boot/install.sh 5.18.0-11935-gbffe08031c89 \
>>         arch/x86/boot/bzImage System.map "/boot"
>>
>> This output was very useful for my workflow, so this patch prints it out
>> again. I'm not sure if there's a better way to do this than what's
>> implemented here, so any feedback is appreciated.
>>
>> Cc: Masahiro Yamada <masahiroy@kernel.org>
>> Signed-off-by: Keith Busch <kbusch@kernel.org>
>> ---
>>  scripts/install.sh | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/scripts/install.sh b/scripts/install.sh
>> index 9bb0fb44f04a..2989d25ef069 100755
>> --- a/scripts/install.sh
>> +++ b/scripts/install.sh
>> @@ -33,6 +33,7 @@ do
>>         # installkernel(8) says the parameters are like follows:
>>         #
>>         #   installkernel version zImage System.map [directory]
>> +       echo "$0 ${KERNELRELEASE} ${KBUILD_IMAGE} ${INSTALL_PATH}"
>>         exec "${file}" "${KERNELRELEASE}" "${KBUILD_IMAGE}" System.map "${INSTALL_PATH}"
>>  done
>>
>> --
>> 2.30.2
>>
> 
> You said "useful for *my* flow",
> so you can do whatever you think is useful in
> ${HOME}/bin/${INSTALLKERNEL}, can't you?
> 
> 

True. E.g., my kernel installer also shows me

a) the modules install path (e.g., /lib/modules/$KERNEL_RELEASE)
b) the number of modules installed

> 
> 
> $ cat ~/bin/installkernel
> #!/bin/sh
> 
> echo '== useful info for my workflow =='
> echo "$@"
> echo '================================='
> 
> exec /sbin/${INSTALLKERNEL} "$@"
> 
> 
> 
> 
> $ chmod +x ~/bin/installkernel
> 
> $ make install
>   INSTALL /boot
> == useful info for my workflow ==
> 5.17.0 arch/x86/boot/bzImage System.map /boot
> =================================
> 
> 
> 
> 
> 
> 

-- 
~Randy