Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <a08c5dd0-279d-724a-4836-6e66bfa183e8@wanadoo.fr>
Date:   Sat, 4 Jun 2022 17:41:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 1/3] regulator: mp5416: alphabetically sort header
 includes
Content-Language: fr
To:     Robert Marko <robimarko@gmail.com>, sravanhome@gmail.com,
        lgirdwood@gmail.com, broonie@kernel.org,
        linux-kernel@vger.kernel.org
References: <20220604145624.47326-1-robimarko@gmail.com>
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <20220604145624.47326-1-robimarko@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 04/06/2022 à 16:56, Robert Marko a écrit :
> Sort the header include list alphabetically.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
>   drivers/regulator/mp5416.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/regulator/mp5416.c b/drivers/regulator/mp5416.c
> index 39cebec0edb6..d8245080df03 100644
> --- a/drivers/regulator/mp5416.c
> +++ b/drivers/regulator/mp5416.c
> @@ -6,14 +6,14 @@
>   //
>   // Author: Saravanan Sekar <sravanhome@gmail.com>
>   
> +#include <linux/err.h>
> +#include <linux/i2c.h>
> +#include <linux/init.h>
>   #include <linux/kernel.h>

Nitpick: it seems that kernel.h is not needed here. (at least it compile 
without it).

CJ

>   #include <linux/module.h>
> -#include <linux/init.h>
> -#include <linux/err.h>
>   #include <linux/platform_device.h>
>   #include <linux/regmap.h>
>   #include <linux/regulator/driver.h>
> -#include <linux/i2c.h>
>   
>   #define MP5416_REG_CTL0			0x00
>   #define MP5416_REG_CTL1			0x01