Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <a3a99b6a-70c7-5b6b-718f-44c4d957cdda@gmail.com>
Date:   Sat, 4 Jun 2022 23:59:02 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Content-Language: en-US
To:     Miaoqian Lin <linmq006@gmail.com>, dave.jiang@intel.com,
        Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220601110013.55366-1-linmq006@gmail.com>
From:   =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= <peter.ujfalusi@gmail.com>
Subject: Re: [PATCH v2] dmaengine: ti: Add missing put_device in
 ti_dra7_xbar_route_allocate
In-Reply-To: <20220601110013.55366-1-linmq006@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 01/06/2022 14:00, Miaoqian Lin wrote:
> of_find_device_by_node() takes reference, we should use put_device()
> to release it when not need anymore.

adding a new label and using goto would be another option or even better?

> Fixes: a074ae38f859 ("dmaengine: Add driver for TI DMA crossbar on DRA7x")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> changes in v2:
> - split v1 into two patches.
> v1 link:
> https://lore.kernel.org/r/20220512051815.11946-1-linmq006@gmail.com
> ---
>  drivers/dma/ti/dma-crossbar.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
> index 71d24fc07c00..06da13b18a7b 100644
> --- a/drivers/dma/ti/dma-crossbar.c
> +++ b/drivers/dma/ti/dma-crossbar.c
> @@ -245,6 +245,7 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec,
>  	if (dma_spec->args[0] >= xbar->xbar_requests) {
>  		dev_err(&pdev->dev, "Invalid XBAR request number: %d\n",
>  			dma_spec->args[0]);
> +		put_device(&pdev->dev);
>  		return ERR_PTR(-EINVAL);
>  	}
>  
> @@ -252,12 +253,14 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec,
>  	dma_spec->np = of_parse_phandle(ofdma->of_node, "dma-masters", 0);
>  	if (!dma_spec->np) {
>  		dev_err(&pdev->dev, "Can't get DMA master\n");
> +		put_device(&pdev->dev);
>  		return ERR_PTR(-EINVAL);
>  	}
>  
>  	map = kzalloc(sizeof(*map), GFP_KERNEL);
>  	if (!map) {
>  		of_node_put(dma_spec->np);
> +		put_device(&pdev->dev);
>  		return ERR_PTR(-ENOMEM);
>  	}
>  
> @@ -268,6 +271,7 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec,
>  		mutex_unlock(&xbar->mutex);
>  		dev_err(&pdev->dev, "Run out of free DMA requests\n");
>  		kfree(map);
> +		put_device(&pdev->dev);

this will not apply with the other patch going separately...
Can you send a two patch series?
While there, I would check if labels+goto would look better?

Thanks for finding these and fixing it!

>  		return ERR_PTR(-ENOMEM);
>  	}
>  	set_bit(map->xbar_out, xbar->dma_inuse);

-- 
Péter