Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220603082336.3867-1-linmq006@gmail.com>
In-Reply-To: <20220603082336.3867-1-linmq006@gmail.com>
From:   Joel Stanley <joel@jms.id.au>
Date:   Fri, 3 Jun 2022 08:25:23 +0000
Message-ID: <CACPK8XdiqZ_bN+iMO8_RvMLQzJtMm1gw-dUaT8Q00vtZSeAsCQ@mail.gmail.com>
Subject: Re: [RESEND PATCH] soc: aspeed: Fix IRQ check in aspeed_lpc_snoop_config_irq
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     Andrew Jeffery <andrew@aj.id.au>,
        Patrick Venture <venture@google.com>,
        Chia-Wei Wang <chiawei_wang@aspeedtech.com>,
        Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        linux-aspeed <linux-aspeed@lists.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 3 Jun 2022 at 08:23, Miaoqian Lin <linmq006@gmail.com> wrote:
>
> platform_get_irq() returns negative error number instead 0 on failure.
> And the doc of platform_get_irq() provides a usage example:
>
>     int irq = platform_get_irq(pdev, 0);
>     if (irq < 0)
>         return irq;
>
> Fix the check of return value to catch errors correctly.
>
> Fixes: 524feb799408 ("soc: add aspeed folder and misc drivers")

That's not the commit that introduced this code, that's simply a
commit that moved the drivers.

> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> Link: https://lore.kernel.org/r/20220114064357.18562-1-linmq006@gmail.com
> In previous thread:
> Reviewed-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
> Signed-off-by: Patrick Venture <venture@google.com>
> ---
>  drivers/soc/aspeed/aspeed-lpc-snoop.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c b/drivers/soc/aspeed/aspeed-lpc-snoop.c
> index eceeaf8dfbeb..c4a03b3a5cf8 100644
> --- a/drivers/soc/aspeed/aspeed-lpc-snoop.c
> +++ b/drivers/soc/aspeed/aspeed-lpc-snoop.c
> @@ -167,8 +167,8 @@ static int aspeed_lpc_snoop_config_irq(struct aspeed_lpc_snoop *lpc_snoop,
>         int rc;
>
>         lpc_snoop->irq = platform_get_irq(pdev, 0);
> -       if (!lpc_snoop->irq)
> -               return -ENODEV;
> +       if (lpc_snoop->irq < 0)
> +               return lpc_snoop->irq;
>
>         rc = devm_request_irq(dev, lpc_snoop->irq,
>                               aspeed_lpc_snoop_irq, IRQF_SHARED,
> --
> 2.25.1
>