Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <213e966d-ac69-b5be-52ad-4ab9f616565e@pengutronix.de>
Date:   Fri, 3 Jun 2022 13:34:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
From:   Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH 2/2] ARM: dts: stm32: correct vcc-supply for eeprom on
 stm32mp15xx-osd32
To:     =?UTF-8?Q?Leonard_G=c3=b6hrs?= <l.goehrs@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de, linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org
References: <20220603094422.2112746-1-l.goehrs@pengutronix.de>
 <20220603094422.2112746-2-l.goehrs@pengutronix.de>
Content-Language: en-US
In-Reply-To: <20220603094422.2112746-2-l.goehrs@pengutronix.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 03.06.22 11:44, Leonard Göhrs wrote:
> According to the OSD32MP1 Power System overview[1] the EEPROM is connected to
> the VDD line and not to some single-purpose fixed regulator.
> Set the EEPROM supply according to the diagram to eliminate this parent-less
> regulator.
> 
> [1]: https://octavosystems.com/app_notes/osd32mp1-power-system-overview/#connections
> 
> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>

Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Thanks,
Ahmad

> ---
>  arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> index e997c4953fd1..935b7084b5a2 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> @@ -50,12 +50,6 @@ retram: retram@38000000 {
>  			no-map;
>  		};
>  	};
> -
> -	reg_sip_eeprom: regulator_eeprom {
> -		compatible = "regulator-fixed";
> -		regulator-name = "sip_eeprom";
> -		regulator-always-on;
> -	};
>  };
>  
>  &i2c4 {
> @@ -204,7 +198,7 @@ pmic_watchdog: watchdog {
>  
>  	sip_eeprom: eeprom@50 {
>  		compatible = "atmel,24c32";
> -		vcc-supply = <&reg_sip_eeprom>;
> +		vcc-supply = <&vdd>;
>  		reg = <0x50>;
>  	};
>  };


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |