Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220513142355.250389-1-mailhol.vincent@wanadoo.fr>
 <20220603102848.17907-1-mailhol.vincent@wanadoo.fr> <20220603102848.17907-3-mailhol.vincent@wanadoo.fr>
 <20220604112707.z4zjdjydqy5rkyfe@pengutronix.de>
In-Reply-To: <20220604112707.z4zjdjydqy5rkyfe@pengutronix.de>
From:   Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Date:   Sat, 4 Jun 2022 21:30:57 +0900
Message-ID: <CAMZ6RqLRf=oyo0HXDSBAMD=Ce-RxtgO=TrhT5Xf1sqR6jWDoCQ@mail.gmail.com>
Subject: Re: [PATCH v4 2/7] can: Kconfig: turn menu "CAN Device Drivers" into
 a menuconfig using CAN_DEV
To:     Marc Kleine-Budde <mkl@pengutronix.de>
Cc:     linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
        Max Staudt <max@enpas.org>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        netdev@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat. 4 juin 2022 at 20:27, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> On 03.06.2022 19:28:43, Vincent Mailhol wrote:
> > In the next patches, the software/virtual drivers (slcan, v(x)can)
> > will depend on drivers/net/can/dev/skb.o.
> >
> > This patch changes the scope of the can-dev module to include the
> > above mentioned drivers.
> >
> > To do so, we reuse the menu "CAN Device Drivers" and turn it into a
> > configmenu using the config symbol CAN_DEV (which we released in
> > previous patch). Also, add a description to this new CAN_DEV
> > menuconfig.
> >
> > The symbol CAN_DEV now only triggers the build of skb.o. For this
> > reasons, all the macros from linux/module.h are deported from
> > drivers/net/can/dev/dev.c to drivers/net/can/dev/skb.c.
> >
> > Finally, drivers/net/can/dev/Makefile is adjusted accordingly.
> >
> > Suggested-by: Oliver Hartkopp <socketcan@hartkopp.net>
> > Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> > ---
> >  drivers/net/can/Kconfig      | 29 ++++++++++++++++++++++++++---
> >  drivers/net/can/dev/Makefile | 16 +++++++++-------
> >  drivers/net/can/dev/dev.c    |  9 +--------
> >  drivers/net/can/dev/skb.c    |  7 +++++++
> >  4 files changed, 43 insertions(+), 18 deletions(-)
> >
>
> > diff --git a/drivers/net/can/dev/Makefile b/drivers/net/can/dev/Makefile
> > index 5b4c813c6222..919f87e36eed 100644
> > --- a/drivers/net/can/dev/Makefile
> > +++ b/drivers/net/can/dev/Makefile
> > @@ -1,9 +1,11 @@
> >  # SPDX-License-Identifier: GPL-2.0
> >
> > -obj-$(CONFIG_CAN_NETLINK) += can-dev.o
> > +obj-$(CONFIG_CAN_DEV) += can-dev.o
>        ^^^^^^^^^^^^^^^^^^^^^
>
> Nitpick: I think you can directly use "y" here.

I see. So the idea would be that if we deselect CONFIG_CAN_DEV, then
despite of can-dev.o being always "yes", it would be empty and thus
ignored. I just didn't know this trick.

I will do as suggested.