Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp80790iof; Sun, 5 Jun 2022 21:45:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzFI7bwdmJ38Xz469YkYlfoWZ17hTHC4eDNc6MYZ1fg3ptmnHkbpiu3H3JwXg+LnZW3yK2 X-Received: by 2002:a17:90a:b001:b0:1dd:30b9:1a45 with SMTP id x1-20020a17090ab00100b001dd30b91a45mr60331190pjq.132.1654490757464; Sun, 05 Jun 2022 21:45:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654490757; cv=none; d=google.com; s=arc-20160816; b=FlrHde3MdMCb9eC9UUuHgQlnPZwIVLakFzZj7iy43e8XtnImJ5eapUNof6HpuBBu0Y 0ILRO1Azks8oo6Gl05SjcmEecpKAFDVCZG6uBEFOnRVSWHp7YJ/HmZvA7Oh1j4ohtZ0h SgKO+Zt7bb5280s1aDaCxnIBHZQLdRb9INQFWrjVbu4dhY82cfIlIzNuiw1rd31hejh2 eJvb4jesyHQI/sxysn8c/tqHfdu7qiv/BgnBVQb2HZD71+H+0ZrVwv2YuVqL+HAcDDpz P20tEFjkL9sPo7QAwysvKHktfJjf3o3nCMzf0E5Z4LcW/2CWkYrw51fMRuy3cxX+fG1V J2AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=tUmPQIJUL4+NtOzBFIJo7+QbnFFXVwwaSJN2qOuZG+s=; b=zLKQeqVWPzp08ulUT48n0nTVG6+Cdim4p7DBP6FqaY0qdFHK1XcxtRqhI5YkMUrVV+ EpTMvUQpuil841V+Go7mMa/jDqN6wBh5otyYp6WLQXN6nT3u9t48DNHwy5JahixzkgaP /l033M9dCG/EYZuHdE12yb7gSw5DtKccfGNIw/Yem/JHp0o+sA/D1x6k829+gNdfpfW5 HCn9blg622sb54sG9kml5hjhmdiGgb2Elh3WlHPQkwxOgDckRfebjkgZStZAnyEZ28la GOla79zzNpcpvYdRBa0EXD1suqnUAiCtiUD65qVdFfOBr4GPRkJGuJGpaknmY43HrRrQ jPJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b="J3QEqc4/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id pq16-20020a17090b3d9000b001e06828a394si18577629pjb.27.2022.06.05.21.45.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 21:45:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b="J3QEqc4/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6752B1F63E; Sun, 5 Jun 2022 21:04:00 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239406AbiFBVLI (ORCPT + 99 others); Thu, 2 Jun 2022 17:11:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235208AbiFBVLF (ORCPT ); Thu, 2 Jun 2022 17:11:05 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE9CE103 for ; Thu, 2 Jun 2022 14:11:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 52B6FB82188 for ; Thu, 2 Jun 2022 21:11:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC1B4C3411E for ; Thu, 2 Jun 2022 21:11:01 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="J3QEqc4/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1654204258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tUmPQIJUL4+NtOzBFIJo7+QbnFFXVwwaSJN2qOuZG+s=; b=J3QEqc4/7f/oCewQMUXIA7sGO4TxpQpUWqpatExzE7amuYnSgqxHDmbatojLvKJxulbS9H q0lAQ4JaKCIoH0h8XH4LFSQgcm8Mn5rm8/9PeikipA3+3Nu4h7K5tU3U7FH2PoHRA44x5B ILr5afDyrDPj9COwCq088KMmNT+y2KM= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 5e55c5eb (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Thu, 2 Jun 2022 21:10:58 +0000 (UTC) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-2ff7b90e635so64529647b3.5 for ; Thu, 02 Jun 2022 14:10:58 -0700 (PDT) X-Gm-Message-State: AOAM533THESB2NaPQ+fK3kDvsemXSSbhDq2QYeMflvKXdRq6QzgE+rSj viDv0PWz9JFVx4nJsH8AjXJbd3OmaCKLRs5Ngow= X-Received: by 2002:a0d:ef03:0:b0:2fa:245:adf3 with SMTP id y3-20020a0def03000000b002fa0245adf3mr8030036ywe.100.1654204256504; Thu, 02 Jun 2022 14:10:56 -0700 (PDT) MIME-Version: 1.0 References: <20220602022109.780348-1-swboyd@chromium.org> <165419885870.2681883.10934677413962491141.b4-ty@arm.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Thu, 2 Jun 2022 23:10:45 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: Initialize jump labels before setup_machine_fdt() To: Catalin Marinas Cc: Stephen Boyd , Will Deacon , Dominik Brodowski , Ard Biesheuvel , linux-arm-kernel , LKML , Douglas Anderson , Hsin-Yi Wang , Steven Rostedt , patches@lists.linux.dev, Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +Greg Hi Catalin, On Thu, Jun 2, 2022 at 11:08 PM Catalin Marinas wrote: > > On Thu, Jun 02, 2022 at 10:18:04PM +0200, Jason A. Donenfeld wrote: > > On Thu, Jun 2, 2022 at 9:46 PM Catalin Marinas wrote: > > > On Thu, Jun 02, 2022 at 09:42:49PM +0200, Jason A. Donenfeld wrote: > > > > On Thu, Jun 2, 2022 at 9:41 PM Catalin Marinas wrote: > > > > > On Wed, 1 Jun 2022 19:21:09 -0700, Stephen Boyd wrote: > > > > > > A static key warning splat appears during early boot on arm64 systems > > > > > > that credit randomness from devicetrees that contain an "rng-seed" > > > > > > property. This is because setup_machine_fdt() is called before > > > > > > jump_label_init() during setup_arch(). Let's swap the order of these two > > > > > > calls so that jump labels are initialized before the devicetree is > > > > > > unflattened and the rng seed is credited. > > > > > > > > > > > > [...] > > > > > > > > > > Applied to arm64 (for-next/core), thanks! > > > > > > > > > > [1/1] arm64: Initialize jump labels before setup_machine_fdt() > > > > > https://git.kernel.org/arm64/c/73e2d827a501 > > > > > > > > I'm not sure precisely what your for-next tag corresponds to, but just > > > > FYI, this should probably go into 5.19 asap and be marked for stable@. > > > > > > The for-next/core branch should go in 5.19-rc1 (I'll send a pull request > > > tomorrow). There's no need to cc stable since the fixed commit just went > > > in (unless you mean something else by "marked for stable"). > > > > It is actually in stable, so please do CC. Otherwise I'll just forward manually. > > Ah, I didn't know this (the fixed commit doesn't have a cc stable > either). So please forward it manually once Linus pulls it. Will do. Jason