Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp81558iof; Sun, 5 Jun 2022 21:47:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytrUUsOVDgz5Uar13YldX4xu6bxSjdJbyDwD8s2PbonmOE+22RhyB7erBvBhirz3QL6oSE X-Received: by 2002:a17:902:f083:b0:167:4e55:2db0 with SMTP id p3-20020a170902f08300b001674e552db0mr14145076pla.165.1654490864552; Sun, 05 Jun 2022 21:47:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654490864; cv=none; d=google.com; s=arc-20160816; b=twcJNEyu36tPvKT23a7PLi5+GHnd7zzZod5WoPx0sNzLpggrg26iuDQ3x7qJnUBk1r 3A9+81bVorPn4fCoij4VbHvZnH2WCzFyxkL8LZq/x+CA+l/Mqdrgo2ry51M3bOnHkopq j06OWfoeogFXpWoCGbdlyO34RuGhFXag0DrgLRFLa+5uhOFPTCdvDj5h9aC0h/44pUQF L7YXoH3Vu1M0C5e0v5wqHTuQzwIhTJUiSpDfOcMnE3hDl+uiPCxh+layoBp8zekt0IBm eFk0VbVoV6iGaFAOYJbA0j0s31r0HhsEF+tCMFU9RZUOCvXIPQuLsV+X+YrDdKP2c4S5 XG6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=B7XfQTq4Hz6sAuSvB7XnhLdd67jZjfU3r/mi60qx2Vo=; b=LE8bpT5ks/4B9IyXh2v0PXejYNuvEqesXEG/8qpCGBnsjG8OtAmp7Nrq5Mrv3txUL/ K4ui0EzubXkAaeiVMXrhldQk9J2YVhWU1hoiehUurnmM5Ntgt+fMqswxzM5LphnfrpNc G7FldiEoHQhrF6tZVVPNCUXHWp3nCg0aBieQh8EvbHFtkQf20UAwBPNonxBo5Fr0AkIB /oUCJfu93gfM35ANjwrAs2ongaGzAABD+HckzSuiki2ozO3rCzhXlKdr/I4soQ/uFmmO owDH+8GNnyaZTQfimHivOQwtnSv5HUBElp13k4qSDANc/VsKx50I8rBgkequ2on2WhAW 1EJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lvcFToTH; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id l11-20020a170903120b00b00163f215e3dbsi24629651plh.341.2022.06.05.21.47.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 21:47:44 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lvcFToTH; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2BD839AE69; Sun, 5 Jun 2022 21:05:12 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352298AbiFFDY3 (ORCPT + 99 others); Sun, 5 Jun 2022 23:24:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245564AbiFFDY2 (ORCPT ); Sun, 5 Jun 2022 23:24:28 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A34481C102 for ; Sun, 5 Jun 2022 20:24:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 56BFCB80944 for ; Mon, 6 Jun 2022 03:24:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EEB0C34119; Mon, 6 Jun 2022 03:24:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654485864; bh=27QfA0HUowPRHp50PZrytVJKom6NrSAJVHItu8R3jHk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lvcFToTHkstRhWpP8zzRAtwT4O09ePpK8HGekpw3LbbkO31qHgbzt6f+XtyUX0wyA Upkatwg5nauh8UM2QzesBlVcMsGR/vOtWBVpC8AQ7EE08dURfEzfG2PAQfmyn3Wsev fbiAi3oV74RKwRDQyTv0Ao+mF7On+YoFOu+v3y2rwJR3RNstABANHp1SN/96ILPiON E8aoRDtBzGZ9BnEuJp+MH983c3K/e7h5ieOGtIgCU0lq7G+SWBxJyWELlENqgeq8qP Yiu9caGxHd3WDJsM/emwZ+t53/hVArkLUxciUrdm/uTeV5OPOQTfX2fckcYnno1Mrm YoUygv94h4p3Q== Date: Mon, 6 Jun 2022 03:24:19 +0000 From: Tzung-Bi Shih To: Miaoqian Lin Cc: Cheng-Yi Chiang , Guenter Roeck , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Benson Leung , Enric Balletbo i Serra , chrome-platform@lists.linux.dev, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ASoC: cros_ec_codec: Fix refcount leak in cros_ec_codec_platform_probe Message-ID: References: <20220603131043.38907-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220603131043.38907-1-linmq006@gmail.com> X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 03, 2022 at 05:10:43PM +0400, Miaoqian Lin wrote: > of_parse_phandle() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: b6bc07d4360d ("ASoC: cros_ec_codec: support WoV") > Signed-off-by: Miaoqian Lin Reviewed-by: Tzung-Bi Shih