Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp83271iof; Sun, 5 Jun 2022 21:51:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIeYYdpSiIOVF/DQ2bO9u7IwkULgsas2NBFGInDyDfDXCxMfz+WRIlE4+7VwyFF5zoDzVq X-Received: by 2002:a63:2353:0:b0:3fc:a85f:8c02 with SMTP id u19-20020a632353000000b003fca85f8c02mr7121270pgm.248.1654491075454; Sun, 05 Jun 2022 21:51:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654491075; cv=none; d=google.com; s=arc-20160816; b=BhyVCJSXSsvCsuTFJcLmcpX5qbauLLVPgJRKW7Mat/vypZlk5alGHf8o/wMXfgCe56 v04Gr6bUpTVoUsZzAS84k7uSFElkWVcCqssr9RvsnEaHYkHgW/9NCvVtLMXpASmehNkv w4CYMqzyEqG1Yr7JQ7OYUCLzhD9j27r5Knp2ng60YwabbNIqEUrvKQmCH8cipXmuF1lU Rj1/x56Wo4IrgCQG/5QNRC1k4N+ogpK0vY4M474UHvJ9Fi512FRWzDtmHODQNqrr4GB0 gyTOY0KOIt6zcQRoEdSabJlPbFW8vKEoFB+ZjSs9CUAtgvopFxYzYAAbe51/CKajwGo6 JHEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=8j4Ucv+Lybc/XuEfT3hO1ywcwWTOvwSEkCH8CD9yV8c=; b=oeUBlmhM4hdE8qgzbPvbbht1UXVK36vucNDwI1HVSmoB1QmsWlgHQuoMOP9SDE027j KX4EVcgm5ENzpwaNM61sOyyVljvSMJNsofFkrrS1rIj049nAuwpcdnCLLzQ/2Yq17ZtB TP/irSYVso6HygbK7+ApV/WoHpgzLa+7v/6tiLb4tnMqH50jBtynILyJ5H7uyRnJy8At AlGg0/y2BxftCe0/SOtA5qk9pld+KVsOwLsL86LhrPi44jKrYRpHV8ji2L6yEDCnhNf9 x64XvmCgDqgxUI5F8AKGtzWwXRHJpSKq8f/LtRpCzJOWucdboAe53KBtoqBJfEExzo3Q 8IEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=mYTiV40u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id i8-20020aa78d88000000b00518ffdf42d7si16585549pfr.285.2022.06.05.21.51.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 21:51:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=mYTiV40u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2C6D8A775A; Sun, 5 Jun 2022 21:06:57 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345700AbiFEQDy (ORCPT + 99 others); Sun, 5 Jun 2022 12:03:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232481AbiFEQDw (ORCPT ); Sun, 5 Jun 2022 12:03:52 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6792326E1 for ; Sun, 5 Jun 2022 09:03:48 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id y29so13415302ljd.7 for ; Sun, 05 Jun 2022 09:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=8j4Ucv+Lybc/XuEfT3hO1ywcwWTOvwSEkCH8CD9yV8c=; b=mYTiV40uBqdpYeGZKsKyrRnVb0WWonjejPdNzEu6MR8BMJWPVFBqMRVrE0r5NCAazP 0OHic3xL/LGD94CxLTag35+jET0evL6Fk/nhDSzT8oMxizbV4r4Dr7Zi1GM6TeJpW6tM 1VsjfxBG8Hws27jN8l+pxzBxxjdYsIjM7azlm8uyRwmNdh6Puh50p3P+GD/t0D/NDHSv 1l9O5gt8jWQGMu1T5mUkte0cVzLlLdYKERRTPwuRTktqEZ+wjNGDzp6zk/7lifYm4hby hXaRMps4kgfZ1aAWYYzkDSKVucEa7S9ieTufAoU1A1CB7gTXpYVYhPaQ9YqZWzQZ6Ykq QUVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=8j4Ucv+Lybc/XuEfT3hO1ywcwWTOvwSEkCH8CD9yV8c=; b=wKwDk5NGiMFuPnHxdlOKo2+qmlT8UwPrIL2QIrae51E7ClKwGc6ilwCpZEPZCnIquu WcveR5y7ygktggZBbNTzv6FtwIgQ3mPgdGgBs4jKp0UctSjqNsfm+0rTIh3gmxK162a3 IAF9rfbcOXhOoOwCwx1wPAltUKHUh+pZ1fht9gVNbx2E3wh25ZZ483vP2fVe37lcF+P+ OdF7maMMAOedoXtVrRsTZWGTZxFGj6TqkXv3F9swLdQ17etnnn1Tjo/TXqIbfQQ6N1WH fvYxi44udfr7MOspLlE4vCZoz3mDOgCH9gVXSTmuAxLeHiPN98+aT2PNcQvMn4msnz8S qzLw== X-Gm-Message-State: AOAM530VOrjDlhp9wgcPnbV4r43F4yzEXXuG+6GWQp1eUYlgm26QpfOR 4MI2vAa3O52sJumLm5byvjA= X-Received: by 2002:a2e:700c:0:b0:255:7dab:aad with SMTP id l12-20020a2e700c000000b002557dab0aadmr7277712ljc.492.1654445025834; Sun, 05 Jun 2022 09:03:45 -0700 (PDT) Received: from [192.168.1.11] ([46.235.67.4]) by smtp.gmail.com with ESMTPSA id x4-20020ac25dc4000000b0047255d210fcsm2529796lfq.43.2022.06.05.09.03.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jun 2022 09:03:45 -0700 (PDT) Message-ID: Date: Sun, 5 Jun 2022 19:03:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 00/11] staging: r8188eu: continue the cleanup of issue_action_BA Content-Language: en-US To: Martin Kaiser , Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20220602193726.280922-1-martin@kaiser.cx> From: Pavel Skripkin In-Reply-To: <20220602193726.280922-1-martin@kaiser.cx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Martin, On 6/2/22 22:37, Martin Kaiser wrote: > Simplify the code to send the addba response and the delba message. Use > ieee80211 helpers if possible. > > This series should be applied after the "start cleaning up > issue_action_BA" series. > > Martin Kaiser (11): > staging: r8188eu: use mgmt to set resp dialog token > staging: r8188eu: use mgmt to set the addba resp status > staging: r8188eu: use mgmt to set the addba resp timeout > staging: r8188eu: use ieee80211 to set addba resp capabilities > staging: r8188eu: calculate the addba response length > staging: r8188eu: use mgmt to set the delba reason code > staging: r8188eu: use mgmt to set delba params > staging: r8188eu: clarify the contents of the delba params > staging: r8188eu: calculate the delba length > staging: r8188eu: remove the pframe variable > staging: r8188eu: use u8, u16 in issue_action_BA prototype > > drivers/staging/r8188eu/core/rtw_mlme_ext.c | 51 +++++++------------ > .../staging/r8188eu/include/rtw_mlme_ext.h | 3 +- > 2 files changed, 18 insertions(+), 36 deletions(-) > Looks fine, thanks! Tested-by: Pavel Skripkin With regards, Pavel Skripkin