Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220530180910.2533-1-andriy.shevchenko@linux.intel.com> <20220603180347.2b0d0f08@jic23-huawei>
In-Reply-To: <20220603180347.2b0d0f08@jic23-huawei>
From:   Cixi Geng <gengcixi@gmail.com>
Date:   Mon, 6 Jun 2022 11:12:15 +0800
Message-ID: <CAF12kFueRHQJy2t6xitqfYwsY0kPagDSH289QKp0y0W0HzsshA@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] iio: adc: sc27xx_adc: Re-use generic struct u32_fract
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Cixi Geng <cixi.geng1@unisoc.com>, linux-iio@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Jonathan Cameron <jic23@kernel.org> =E4=BA=8E2022=E5=B9=B46=E6=9C=884=E6=97=
=A5=E5=91=A8=E5=85=AD 01:44=E5=86=99=E9=81=93=EF=BC=9A
>
> On Mon, 30 May 2022 21:09:10 +0300
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > Instead of custom data type re-use generic struct u32_fract.
>
> There isn't a custom data type  - I'll reword this whilst applying
> if there is no reason for a v2.
>
> > No changes intended.
>
> functional changes
>
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Given they have been active recently I'd ideally like Cixi Geng
> to take a quick glance at this before I apply it.
Acked-by: Cixi Geng <cixi.geng1@unisoc.com>
>
> Thanks,
>
> Jonathan
>
> > ---
> >  drivers/iio/adc/sc27xx_adc.c | 15 +++++++--------
> >  1 file changed, 7 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/iio/adc/sc27xx_adc.c b/drivers/iio/adc/sc27xx_adc.=
c
> > index e9ff2d6a8a57..f8421cbba8fa 100644
> > --- a/drivers/iio/adc/sc27xx_adc.c
> > +++ b/drivers/iio/adc/sc27xx_adc.c
> > @@ -579,15 +579,14 @@ static int sc27xx_adc_read(struct sc27xx_adc_data=
 *data, int channel,
> >       return ret;
> >  }
> >
> > -static void sc27xx_adc_volt_ratio(struct sc27xx_adc_data *data,
> > -                               int channel, int scale,
> > -                               u32 *div_numerator, u32 *div_denominato=
r)
> > +static void sc27xx_adc_volt_ratio(struct sc27xx_adc_data *data, int ch=
annel, int scale,
> > +                               struct u32_fract *fract)
> >  {
> >       u32 ratio;
> >
> >       ratio =3D data->var_data->get_ratio(channel, scale);
> > -     *div_numerator =3D ratio >> SC27XX_RATIO_NUMERATOR_OFFSET;
> > -     *div_denominator =3D ratio & SC27XX_RATIO_DENOMINATOR_MASK;
> > +     fract->numerator =3D ratio >> SC27XX_RATIO_NUMERATOR_OFFSET;
> > +     fract->denominator =3D ratio & SC27XX_RATIO_DENOMINATOR_MASK;
> >  }
> >
> >  static int adc_to_volt(struct sc27xx_adc_linear_graph *graph,
> > @@ -615,7 +614,7 @@ static int sc27xx_adc_to_volt(struct sc27xx_adc_lin=
ear_graph *graph,
> >  static int sc27xx_adc_convert_volt(struct sc27xx_adc_data *data, int c=
hannel,
> >                                  int scale, int raw_adc)
> >  {
> > -     u32 numerator, denominator;
> > +     struct u32_fract fract;
> >       u32 volt;
> >
> >       /*
> > @@ -637,9 +636,9 @@ static int sc27xx_adc_convert_volt(struct sc27xx_ad=
c_data *data, int channel,
> >               break;
> >       }
> >
> > -     sc27xx_adc_volt_ratio(data, channel, scale, &numerator, &denomina=
tor);
> > +     sc27xx_adc_volt_ratio(data, channel, scale, &fract);
> >
> > -     return DIV_ROUND_CLOSEST(volt * denominator, numerator);
> > +     return DIV_ROUND_CLOSEST(volt * fract.denominator, fract.numerato=
r);
> >  }
> >
> >  static int sc27xx_adc_read_processed(struct sc27xx_adc_data *data,
>