Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Sat, 4 Jun 2022 14:43:04 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Cc:     linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
        Max Staudt <max@enpas.org>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        netdev@vger.kernel.org
Subject: Re: [PATCH v4 2/7] can: Kconfig: turn menu "CAN Device Drivers" into
 a menuconfig using CAN_DEV
Message-ID: <20220604124304.ds5eyjnxxvcl543l@pengutronix.de>
References: <20220513142355.250389-1-mailhol.vincent@wanadoo.fr>
 <20220603102848.17907-1-mailhol.vincent@wanadoo.fr>
 <20220603102848.17907-3-mailhol.vincent@wanadoo.fr>
 <20220604112707.z4zjdjydqy5rkyfe@pengutronix.de>
 <CAMZ6RqLRf=oyo0HXDSBAMD=Ce-RxtgO=TrhT5Xf1sqR6jWDoCQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kiq4zve2baid4qzh"
Content-Disposition: inline
In-Reply-To: <CAMZ6RqLRf=oyo0HXDSBAMD=Ce-RxtgO=TrhT5Xf1sqR6jWDoCQ@mail.gmail.com>
Precedence: bulk


--kiq4zve2baid4qzh
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 04.06.2022 21:30:57, Vincent MAILHOL wrote:
> > > diff --git a/drivers/net/can/dev/Makefile b/drivers/net/can/dev/Makef=
ile
> > > index 5b4c813c6222..919f87e36eed 100644
> > > --- a/drivers/net/can/dev/Makefile
> > > +++ b/drivers/net/can/dev/Makefile
> > > @@ -1,9 +1,11 @@
> > >  # SPDX-License-Identifier: GPL-2.0
> > >
> > > -obj-$(CONFIG_CAN_NETLINK) +=3D can-dev.o
> > > +obj-$(CONFIG_CAN_DEV) +=3D can-dev.o
> >        ^^^^^^^^^^^^^^^^^^^^^
> >
> > Nitpick: I think you can directly use "y" here.
>=20
> I see. So the idea would be that if we deselect CONFIG_CAN_DEV, then
> despite of can-dev.o being always "yes", it would be empty and thus
> ignored.

ACK

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--kiq4zve2baid4qzh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKbU1UACgkQrX5LkNig
012j/gf9H0jLCIOgNudqg9EpeJUg9kt6kqe7g1xpRxAmbPs8FgERZXZrf4cvRKao
cYepV5pZX9vy4+sH/EoAjzmJLz9Z5Undty0301Ejetfjqv5C6C7h2vVOpBism5t5
ZvTneDkQaGdL3roPHEvrgPUhprfhMP7VqMx7uRTGBykBmdvko6xWiXDm8U97MbML
+dfSfFdxC/pI7RBnebeLSiiq3GAOr5ueXpqBBjtkjQFzweHhsLDRnoOsolUMqwkW
sWFC4I7UIds8iUyJRb2eM0uOvyMEVmuo/x4SKr0jLCpwcBOaUwRPYoMeEdpmUvaM
a5r5QbscSEDe4v6gnp8KCZzLwjiTew==
=Mc5r
-----END PGP SIGNATURE-----

--kiq4zve2baid4qzh--