Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Sat, 4 Jun 2022 13:25:38 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc:     linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
        Max Staudt <max@enpas.org>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        netdev@vger.kernel.org
Subject: Re: [PATCH v4 3/7] can: bittiming: move bittiming calculation
 functions to calc_bittiming.c
Message-ID: <20220604112538.p4hlzgqnodyvftsj@pengutronix.de>
References: <20220513142355.250389-1-mailhol.vincent@wanadoo.fr>
 <20220603102848.17907-1-mailhol.vincent@wanadoo.fr>
 <20220603102848.17907-4-mailhol.vincent@wanadoo.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="fmzaihovq3ararpb"
Content-Disposition: inline
In-Reply-To: <20220603102848.17907-4-mailhol.vincent@wanadoo.fr>
Precedence: bulk


--fmzaihovq3ararpb
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 03.06.2022 19:28:44, Vincent Mailhol wrote:
> The canonical way to select or deselect an object during compilation
> is to use this pattern in the relevant Makefile:
>=20
> bar-$(CONFIG_FOO) :=3D foo.o
>=20
> bittiming.c instead uses some #ifdef CONFIG_CAN_CALC_BITTIMG.
>=20
> Create a new file named calc_bittiming.c with all the functions which
> are conditionally compiled with CONFIG_CAN_CALC_BITTIMG and modify the
> Makefile according to above pattern.
>=20
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> ---
>  drivers/net/can/Kconfig              |   4 +
>  drivers/net/can/dev/Makefile         |   2 +
>  drivers/net/can/dev/bittiming.c      | 197 --------------------------
>  drivers/net/can/dev/calc_bittiming.c | 202 +++++++++++++++++++++++++++
>  4 files changed, 208 insertions(+), 197 deletions(-)
>  create mode 100644 drivers/net/can/dev/calc_bittiming.c
>=20
> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
> index b1e47f6c5586..8f3b97aea638 100644
> --- a/drivers/net/can/Kconfig
> +++ b/drivers/net/can/Kconfig
> @@ -96,6 +96,10 @@ config CAN_CALC_BITTIMING
>  	  source clock frequencies. Disabling saves some space, but then the
>  	  bit-timing parameters must be specified directly using the Netlink
>  	  arguments "tq", "prop_seg", "phase_seg1", "phase_seg2" and "sjw".
> +
> +	  The additional features selected by this option will be added to the
> +	  can-dev module.
> +
>  	  If unsure, say Y.
> =20
>  config CAN_AT91
> diff --git a/drivers/net/can/dev/Makefile b/drivers/net/can/dev/Makefile
> index 919f87e36eed..b8a55b1d90cd 100644
> --- a/drivers/net/can/dev/Makefile
> +++ b/drivers/net/can/dev/Makefile
> @@ -9,3 +9,5 @@ can-dev-$(CONFIG_CAN_NETLINK) +=3D dev.o
>  can-dev-$(CONFIG_CAN_NETLINK) +=3D length.o
>  can-dev-$(CONFIG_CAN_NETLINK) +=3D netlink.o
>  can-dev-$(CONFIG_CAN_NETLINK) +=3D rx-offload.o
> +
> +can-dev-$(CONFIG_CAN_CALC_BITTIMING) +=3D calc_bittiming.o

Nitpick:
Can we keep this list sorted?

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--fmzaihovq3ararpb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKbQS8ACgkQrX5LkNig
010fHAf9EqWC7V8zYRf8tGNLSdm/oEsh1naw8BqOxpmbMdPMxbOaSe7WN5BYJjAc
lRtXQVh0Sog3DkmHNso25zttV5HRJ/iZ139Mjko0TkQaJ2wWzbTIuQ17iBN1TkIP
vidEwAwgQlPI8PiKVegZWiekwCK/XGxDgJZVZAE+7W+Ovg88eHXZwtT5o+Idhcll
g2hH8VY5Um6sBmg08jF4FuJWReRJmTQ6fXdUeQHbs5nkrMYEL8ojIgmmPMneNbac
tBsGAU/HXIq8wY6no2qt7iPr6efZ0SEhh8T9SgdWkI32T1cGIVMIf8R0GbBFlmS8
x4goNIHA4MPFoGcZrbAj1DYZ2SFR/Q==
=fWUj
-----END PGP SIGNATURE-----

--fmzaihovq3ararpb--