Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp96553iof; Sun, 5 Jun 2022 22:15:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGhE8AebjNdmdNSLnk5n2xRPSeqNf57oHeykEGiChvijZzkT4QgrQsy1T37TqvfJDv3hCW X-Received: by 2002:a17:90a:408f:b0:1d1:d1ba:2abb with SMTP id l15-20020a17090a408f00b001d1d1ba2abbmr59267145pjg.152.1654492499860; Sun, 05 Jun 2022 22:14:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654492499; cv=none; d=google.com; s=arc-20160816; b=RZ6fXGzmKwucxECwkUm+1zJpFfNxjfk+dvj/iSoh1J71+1ZWsTmvoy+bHBNkQLBaDI Tc9JmAH7Kc9CWWMH/grlcPKnf2gvk3a2iq9kHPTvhcS7/2nC63o7A90PuusE/PtjNZxD Kb8QXcLdEjdneAeKNzBqTzdEu4J2PuzHkkQj+lMmAP2f/BcBlO/3RvWSbGG/WssgC58W kuWcie5fFsXc8/MUco+x5MRy/76gRJsIZxd1I3Q71Gu/wFlXLfL2MaOljYd4krJsVECi Gv49VNWyJuZtY5pbpFZYBSsPnmzbz3QPGY4zi0rnGV4X62zpOsou7F+RyHXMGtdGi7q1 h9tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=XXwZLwWBMtchia74QqrjKzKjbZMReUedDWUaL7poWWo=; b=EnK20LqoYwFgH3nrNZRn5u4KENyL4z/IH9lcXcROzRhSn9kHCTWLak559U6eboeKJ7 4DnuUGYOmDSlsCQRkSnThb6/SrNl3jtxcE82KeANcIEluv5JdwzFCNfwQRuUZJ5KNwuK JSzYoy46QuG8UjfSxmF1alWWjgCF9GEKiaONgvf1g84nGKubyzmAO6c4f1EPbKZv6HhK FNA+Taypt0eb0wZlt4LDn2bL16dS6EB+B308XS4TZ7+vMmoSZcSrU1FuDd6R8E4Zg/mj kYwIIuRGHaXCpMCCsshYTLorD3NARJw2/cVslJCErHzmpCUn1UqtLW5ihd72PGZYlEHq MQ3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id f13-20020a056a001acd00b005180f251cd5si20001925pfv.184.2022.06.05.22.14.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 22:14:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 692CE1611FC; Sun, 5 Jun 2022 21:20:25 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242680AbiFCLBs (ORCPT + 99 others); Fri, 3 Jun 2022 07:01:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229723AbiFCLBq (ORCPT ); Fri, 3 Jun 2022 07:01:46 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFC053A726 for ; Fri, 3 Jun 2022 04:01:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id CEF57CE231B for ; Fri, 3 Jun 2022 11:01:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE193C385A9; Fri, 3 Jun 2022 11:01:37 +0000 (UTC) Date: Fri, 3 Jun 2022 12:01:34 +0100 From: Catalin Marinas To: Patrick Wang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yee.lee@mediatek.com Subject: Re: [PATCH v2 0/4] mm: kmemleak: store objects allocated with physical address separately and check when scan Message-ID: References: <20220603035415.1243913-1-patrick.wang.shcn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220603035415.1243913-1-patrick.wang.shcn@gmail.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 03, 2022 at 11:54:11AM +0800, Patrick Wang wrote: > Patrick Wang (4): > mm: kmemleak: add OBJECT_PHYS flag for objects allocated with physical > address > mm: kmemleak: add rbtree for objects allocated with physical address > mm: kmemleak: handle address stored in object based on its type > mm: kmemleak: kmemleak_*_phys() set address type and check PA when > scan This looks fine at a very quick look but I'll do a in-depth review next week. One more thing needed is to remove the min_count argument to kmemleak_alloc_phys() and assume it's always 0. After this series we can't track them for leaking anyway. Thanks for putting this together. -- Catalin