Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp104795iof; Sun, 5 Jun 2022 22:31:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbdr/3adN1kn0FFVYK2I5xrlkB+SBYwf6+5V2eAtv/keL+GhNf3QMmaD+WC5V8NO8nR/HO X-Received: by 2002:a17:902:ecc5:b0:164:1a5d:576f with SMTP id a5-20020a170902ecc500b001641a5d576fmr22368344plh.19.1654493476286; Sun, 05 Jun 2022 22:31:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654493476; cv=none; d=google.com; s=arc-20160816; b=DYc3IUxkJrnYHHWpT46Q+Kivw1QHAWSR6tN+lUyS9TpeM2tZxt6Bd35sOU0UE6Y1J1 ZiOkxPPe1QhUtvC1Ap84H5wXKZbdnFFn2SNH1wqpEMTRFq2w/NAOw2DvK8wRig5axYFx K5WUHSareEc8Q24HcwGJSkbzWZ6LX3o6Q/zprDREmK5qzcnp/lhP2RwceHUSlOoyqju2 pqug/UFRV9Oei/Uz/2ZuHqv4J2OIQPvg0GE4QY/7i8UghpoNkChJ5h0FV4P7qmWnkk7w +o1/htamdQkM/7glHTc4tS25zCNgOmGjo7HBn6tGG8OWSIIWDGL5IX8rdg/fvEfOtOTq +QkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HmYk1E0nlrVwRWwFSUC/a4yoPMG0X4XicsKq1hOz6KU=; b=URsm2TNrPan7Idk005bcWZ0v3b8DBPl0hdIw4gHwny+VjeOwCdti1b50QIoKvxsEc9 H//rNYvzbKl3cr8rVg8AML+qquEP54foEvDV5+U35Cqws3FKfufsUb9ZnmKMgzOzm84F /Q1g4duopzLuy3eHcdbav3HWNk2gb+AmZVOPL6FJB4WHf1t0beBTWLEUrZGCNLLIu1cn xTwHlEuvYFOUuS1P9D9Lhq7qkUpv7vMxcnnMskNOF3uIZJTVG2C10RqC6/BV8foLPFWM bDlNAvrPrmEbFHO/t8oQ8IIkryYl9/wX0US8RZ0QI/rXsMWODH8VXYXyVQYVUx1nViQF ZeZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=PJoje009; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id v12-20020a170902b7cc00b00161571fd712si19260444plz.450.2022.06.05.22.31.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 22:31:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=PJoje009; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4E63C20E16E; Sun, 5 Jun 2022 21:31:37 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241212AbiFDTdY (ORCPT + 99 others); Sat, 4 Jun 2022 15:33:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240865AbiFDTbt (ORCPT ); Sat, 4 Jun 2022 15:31:49 -0400 Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27FDD50448 for ; Sat, 4 Jun 2022 12:31:36 -0700 (PDT) Received: by mail-qk1-x729.google.com with SMTP id az35so1177947qkb.3 for ; Sat, 04 Jun 2022 12:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HmYk1E0nlrVwRWwFSUC/a4yoPMG0X4XicsKq1hOz6KU=; b=PJoje00985N6oGb/Y7bGsu79gRdWGwWmNVnvrX06a4qBWEHiGWQMqbbjrBD0FWF2C9 hSxat3cFEp6yEukLVpR44SfZoxpFuoy8AW0TgKufz1DdZL5g4kNAzKJx0SPBApiG7uu9 5iJ5dC8D+KXHkXvGpc8je01NDyf1w/bitToUoQPbJleWS5Aihp4Z6oeD3doWmT251/Cp rh9gw83EVSkHrRClNO/OBunWbwOxu/mC3V+aooYZnVFQS+qMckTUvctDbOhw6s9TmWyO II1dLerx3Cqsh6cZ78WG0pNY2U19ON3i0qzCmNq4qNtFUNIlU8RatEylhTfDZWObcyZz JZvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HmYk1E0nlrVwRWwFSUC/a4yoPMG0X4XicsKq1hOz6KU=; b=drX+fwuhq8RLSL9bGneFPl/2UIBFihyc3nyoUgNs8Ikx5jIX1NbuLM2jjBBra3T6px Mn7vKP73GXhiH4ur9bDpmZShgpi7uc9Wrr7AioIgGfKoAptPuf8zM/CNpKQe2pQoTttJ ftyK2ZsoPDLPZ8Qn4YzisPA83XRL4buLuq+6YUKuVbllHp2k1Txcff+XO6isoT/mgWYV b3ybm5OWPiK/fXInAxUdyM/T5lXXZZEgeULQHDWx/gWwENnMKMrbTccR/1iiohjsk/iz ldRnYo1WVfY4s8IYSgEf8nOwDi6v6sIBzEUXDGfhszWEyHkRE6YKKqSzAoAxggRE+DZ4 UXSg== X-Gm-Message-State: AOAM533GsLZs8SP8iIfMOEoZecQsLUuZcWpYXfFxav1hASG+DBVCBxAZ CFtwlxN/1VeHpwia+YqJn6/mHzn9rf1j X-Received: by 2002:a05:620a:2586:b0:680:f846:4708 with SMTP id x6-20020a05620a258600b00680f8464708mr10998237qko.654.1654371089527; Sat, 04 Jun 2022 12:31:29 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id o17-20020ac84291000000b00304defdb1b3sm3537426qtl.85.2022.06.04.12.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jun 2022 12:31:28 -0700 (PDT) From: Kent Overstreet To: linux-kernel@vger.kernel.org Cc: Kent Overstreet , pmladek@suse.com, rostedt@goodmis.org, Dan Williams , Dave Hansen , nvdimm@lists.linux.dev Subject: [PATCH v3 26/33] tools/testing/nvdimm: Convert to printbuf Date: Sat, 4 Jun 2022 15:30:35 -0400 Message-Id: <20220604193042.1674951-27-kent.overstreet@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220604193042.1674951-1-kent.overstreet@gmail.com> References: <20220604193042.1674951-1-kent.overstreet@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This converts from seq_buf to printbuf. Here we're using printbuf with an external buffer, meaning it's a direct conversion. Signed-off-by: Kent Overstreet Cc: Dan Williams Cc: Dave Hansen Cc: nvdimm@lists.linux.dev --- tools/testing/nvdimm/test/ndtest.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/tools/testing/nvdimm/test/ndtest.c b/tools/testing/nvdimm/test/ndtest.c index 4d1a947367..a2097955da 100644 --- a/tools/testing/nvdimm/test/ndtest.c +++ b/tools/testing/nvdimm/test/ndtest.c @@ -12,7 +12,7 @@ #include #include #include -#include +#include #include "../watermark.h" #include "nfit_test.h" @@ -740,32 +740,30 @@ static ssize_t flags_show(struct device *dev, { struct nvdimm *nvdimm = to_nvdimm(dev); struct ndtest_dimm *dimm = nvdimm_provider_data(nvdimm); - struct seq_buf s; + struct printbuf s = PRINTBUF_EXTERN(buf, PAGE_SIZE); u64 flags; flags = dimm->flags; - seq_buf_init(&s, buf, PAGE_SIZE); if (flags & PAPR_PMEM_UNARMED_MASK) - seq_buf_printf(&s, "not_armed "); + prt_printf(&s, "not_armed "); if (flags & PAPR_PMEM_BAD_SHUTDOWN_MASK) - seq_buf_printf(&s, "flush_fail "); + prt_printf(&s, "flush_fail "); if (flags & PAPR_PMEM_BAD_RESTORE_MASK) - seq_buf_printf(&s, "restore_fail "); + prt_printf(&s, "restore_fail "); if (flags & PAPR_PMEM_SAVE_MASK) - seq_buf_printf(&s, "save_fail "); + prt_printf(&s, "save_fail "); if (flags & PAPR_PMEM_SMART_EVENT_MASK) - seq_buf_printf(&s, "smart_notify "); + prt_printf(&s, "smart_notify "); + if (printbuf_written(&s)) + prt_printf(&s, "\n"); - if (seq_buf_used(&s)) - seq_buf_printf(&s, "\n"); - - return seq_buf_used(&s); + return printbuf_written(&s); } static DEVICE_ATTR_RO(flags); -- 2.36.0