Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <e78940bc-9be2-2fe7-026f-9e64a1416c9f@xen0n.name>
Date:   Fri, 3 Jun 2022 22:14:30 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:103.0) Gecko/20100101
 Thunderbird/103.0a1
Subject: Re: [PATCH V15 10/24] LoongArch: Add other common headers
Content-Language: en-US
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Arnd Bergmann <arnd@arndb.de>
Cc:     Huacai Chen <chenhuacai@loongson.cn>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Airlie <airlied@linux.ie>,
        Jonathan Corbet <corbet@lwn.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Yanteng Si <siyanteng@loongson.cn>,
        Huacai Chen <chenhuacai@gmail.com>,
        Guo Ren <guoren@kernel.org>, Xuerui Wang <kernel@xen0n.name>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        WANG Xuerui <git@xen0n.name>
References: <20220603072053.35005-1-chenhuacai@loongson.cn>
 <20220603072053.35005-11-chenhuacai@loongson.cn> <YpoPZjJ/Adfu3uH9@zx2c4.com>
 <CAK8P3a0iASLd768imA8pG32Cc2RsqG8-ZyN+Obcg+PksVj1FJg@mail.gmail.com>
 <YpoURwkAbqRlr7Yi@zx2c4.com>
From:   WANG Xuerui <kernel@xen0n.name>
In-Reply-To: <YpoURwkAbqRlr7Yi@zx2c4.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/3/22 22:01, Jason A. Donenfeld wrote:
> Hi Arnd,
>
> On Fri, Jun 03, 2022 at 03:55:27PM +0200, Arnd Bergmann wrote:
>> On Fri, Jun 3, 2022 at 3:40 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>>> On Fri, Jun 03, 2022 at 03:20:39PM +0800, Huacai Chen wrote:
>>>> diff --git a/arch/loongarch/include/asm/timex.h b/arch/loongarch/include/asm/timex.h
>>> "Currently only used on SMP for scheduling" isn't quite correct. It's
>>> also used by random_get_entropy(). And anything else that uses
>>> get_cycles() for, e.g., benchmarking, might use it too.
>>>
>>> You wrote also, "we know that all SMP capable CPUs have cycle counters",
>>> so if I gather from this statement that some !SMP CPUs don't have a
>>> cycle counter, though some do. If that's a correct supposition, then
>>> you may need to rewrite this file to be something like:
>> The file is based on the mips version that deals with a variety of
>> implementations
>> and has the same comment.
>>
>> I assume the loongarch chips all behave the same way here, and won't need
>> a special case for non-SMP.
> Oh good. In that case, the code is fine and I suppose the comment could
> just be removed.

In addition, the rdtime family of instructions is in fact guaranteed to 
be available on LoongArch; LoongArch's subsets all contain them, even 
the 32-bit "Primary" subset intended for university teaching -- they 
provide the rdtimeh.w and rdtimel.w pair of instructions that access the 
same 64-bit counter. So I think the comments are probably just leftovers 
from a very early port; the LoongArch development started way before it 
was publicized.

And yes, the comment block re get_cycles usage can be removed altogether.