Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Sat, 4 Jun 2022 15:46:15 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc:     linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
        Max Staudt <max@enpas.org>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        netdev@vger.kernel.org
Subject: Re: [PATCH v4 2/7] can: Kconfig: turn menu "CAN Device Drivers" into
 a menuconfig using CAN_DEV
Message-ID: <20220604134615.l7qtyam6kmqboujo@pengutronix.de>
References: <20220513142355.250389-1-mailhol.vincent@wanadoo.fr>
 <20220603102848.17907-1-mailhol.vincent@wanadoo.fr>
 <20220603102848.17907-3-mailhol.vincent@wanadoo.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="pvkdbv5sicbki4qw"
Content-Disposition: inline
In-Reply-To: <20220603102848.17907-3-mailhol.vincent@wanadoo.fr>
Precedence: bulk


--pvkdbv5sicbki4qw
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

My previous mail on this was wrong (as you noticed).... so here's the
corrected one (hopefully).

On 03.06.2022 19:28:43, Vincent Mailhol wrote:
> diff --git a/drivers/net/can/dev/Makefile b/drivers/net/can/dev/Makefile
> index 5b4c813c6222..919f87e36eed 100644
> --- a/drivers/net/can/dev/Makefile
> +++ b/drivers/net/can/dev/Makefile
> @@ -1,9 +1,11 @@
>  # SPDX-License-Identifier: GPL-2.0
> =20
> -obj-$(CONFIG_CAN_NETLINK) +=3D can-dev.o
> -can-dev-y                    +=3D bittiming.o
> -can-dev-y                    +=3D dev.o
> -can-dev-y                    +=3D length.o
> -can-dev-y                    +=3D netlink.o
> -can-dev-y                    +=3D rx-offload.o
> -can-dev-y                       +=3D skb.o
> +obj-$(CONFIG_CAN_DEV) +=3D can-dev.o
> +
> +can-dev-$(CONFIG_CAN_DEV) +=3D skb.o
           ^^^^^^^^^^^^^^^^

As "skb.o" is always part of "can-dev.o" (if build at all), you can use
"can-dev-y" here.

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--pvkdbv5sicbki4qw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKbYiQACgkQrX5LkNig
012l2gf/YsNjl48yYp2YEyLJmGsd69HaA37eYqom1L74OW9JPO9Gx2alg4uULFXL
Y2pcFSHVqKAWefFuIh5MeE3b5+ARJkwEdqggBPSy1Z88LqW+zNp/oA7gIIHtgjGC
AzyEEj8FyHFFAk2lqzGgMenGYxzVxFyba6NtXGWzc/aTT7ltWwFUaKPOSBkInvmf
Y0hAQmOggGxuMKES7H+JBXTYCoewgn2dOkazxBn/8Xllg4porzsCGCBOTijEbYr0
/YHerEoOBecHcf5SsoG1QmLdfBEI7VpqjicPQ1arODIR84j+GvfFym+7TjjtJJfy
ji0E0hivJG2/HzmzsjKrXKZAQDekrw==
=iouw
-----END PGP SIGNATURE-----

--pvkdbv5sicbki4qw--