Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <d01f87e0-66fa-e727-f08d-347e0f0853de@redhat.com>
Date:   Sat, 4 Jun 2022 16:01:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] Input: soc_button_array - also add Lenovo Yoga Tablet2
 1051F to dmi_use_low_level_irq
Content-Language: en-US
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Marius Hoch <mail@mariushoch.de>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220603120246.3065-1-mail@mariushoch.de>
 <YpqMMmIH6Rr0RbeP@google.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <YpqMMmIH6Rr0RbeP@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 6/4/22 00:33, Dmitry Torokhov wrote:
> On Fri, Jun 03, 2022 at 02:02:46PM +0200, Marius Hoch wrote:
>> Commit 223f61b8c5ad ("Input: soc_button_array - add Lenovo Yoga Tablet2
>> 1051L to the dmi_use_low_level_irq list") added the 1051L to this list
>> already, but the same problem applies to the 1051F. As there are no
>> further 1051 variants (just the F/L), we can just DMI match 1051.
>>
>> Tested on a Lenovo Yoga Tablet2 1051F: Without this patch the
>> home-button stops working after a wakeup from suspend.
>>
>> Signed-off-by: Marius Hoch <mail@mariushoch.de>
> 
> Adding Hans for his input...

This patch is obviously correct the F/L postfix just differs between
wiFi vs LTE, not sure if I already knew this when I wrote this patch
(and did not think things through) or if it is knowledge which I
gathered later, anyway:

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> 
>> ---
>>  drivers/input/misc/soc_button_array.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
>> index cbb1599a520e..480476121c01 100644
>> --- a/drivers/input/misc/soc_button_array.c
>> +++ b/drivers/input/misc/soc_button_array.c
>> @@ -85,13 +85,13 @@ static const struct dmi_system_id dmi_use_low_level_irq[] = {
>>  	},
>>  	{
>>  		/*
>> -		 * Lenovo Yoga Tab2 1051L, something messes with the home-button
>> +		 * Lenovo Yoga Tab2 1051F/1051L, something messes with the home-button
>>  		 * IRQ settings, leading to a non working home-button.
>>  		 */
>>  		.matches = {
>>  			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>>  			DMI_MATCH(DMI_PRODUCT_NAME, "60073"),
>> -			DMI_MATCH(DMI_PRODUCT_VERSION, "1051L"),
>> +			DMI_MATCH(DMI_PRODUCT_VERSION, "1051"),
>>  		},
>>  	},
>>  	{} /* Terminating entry */
>> -- 
>> 2.36.1
>>
>