Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762555AbXESFrR (ORCPT ); Sat, 19 May 2007 01:47:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755787AbXESFrE (ORCPT ); Sat, 19 May 2007 01:47:04 -0400 Received: from mx1.redhat.com ([66.187.233.31]:57897 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755525AbXESFrC (ORCPT ); Sat, 19 May 2007 01:47:02 -0400 Message-ID: <464E8ED7.6060607@redhat.com> Date: Sat, 19 May 2007 13:44:55 +0800 From: Eugene Teo Organization: Red Hat, Inc User-Agent: Thunderbird 2.0.0.0 (X11/20070419) MIME-Version: 1.0 To: Randy Dunlap CC: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo Subject: Re: [2.6 patch] net/llc/llc_conn.c: fix possible NULL dereference References: <464E8763.3010609@redhat.com> <20070518223005.91236c38.randy.dunlap@oracle.com> In-Reply-To: <20070518223005.91236c38.randy.dunlap@oracle.com> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 775 Lines: 27 Hi Randy, Randy Dunlap wrote: > On Sat, 19 May 2007 13:13:07 +0800 Eugene Teo wrote: > >> skb_peek() might return an empty list. skb should be checked before calling >> llc_pdu_sn_hdr() with it. >> >> Spotted by the Coverity checker. >> >> Signed-off-by: Eugene Teo [...] > > Networking patches need to be sent to the netdev@vger.kernel.org > mailing list (and lkml can be omitted IMHO). > > But... instead of doing the assignment and test in one swoop, > we prefer: Right, thanks for the reminder! Eugene - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/