Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Sat, 4 Jun 2022 13:27:07 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc:     linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
        Max Staudt <max@enpas.org>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        netdev@vger.kernel.org
Subject: Re: [PATCH v4 2/7] can: Kconfig: turn menu "CAN Device Drivers" into
 a menuconfig using CAN_DEV
Message-ID: <20220604112707.z4zjdjydqy5rkyfe@pengutronix.de>
References: <20220513142355.250389-1-mailhol.vincent@wanadoo.fr>
 <20220603102848.17907-1-mailhol.vincent@wanadoo.fr>
 <20220603102848.17907-3-mailhol.vincent@wanadoo.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="nsn6qtiymrhpcwlo"
Content-Disposition: inline
In-Reply-To: <20220603102848.17907-3-mailhol.vincent@wanadoo.fr>
Precedence: bulk


--nsn6qtiymrhpcwlo
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 03.06.2022 19:28:43, Vincent Mailhol wrote:
> In the next patches, the software/virtual drivers (slcan, v(x)can)
> will depend on drivers/net/can/dev/skb.o.
>=20
> This patch changes the scope of the can-dev module to include the
> above mentioned drivers.
>=20
> To do so, we reuse the menu "CAN Device Drivers" and turn it into a
> configmenu using the config symbol CAN_DEV (which we released in
> previous patch). Also, add a description to this new CAN_DEV
> menuconfig.
>=20
> The symbol CAN_DEV now only triggers the build of skb.o. For this
> reasons, all the macros from linux/module.h are deported from
> drivers/net/can/dev/dev.c to drivers/net/can/dev/skb.c.
>=20
> Finally, drivers/net/can/dev/Makefile is adjusted accordingly.
>=20
> Suggested-by: Oliver Hartkopp <socketcan@hartkopp.net>
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> ---
>  drivers/net/can/Kconfig      | 29 ++++++++++++++++++++++++++---
>  drivers/net/can/dev/Makefile | 16 +++++++++-------
>  drivers/net/can/dev/dev.c    |  9 +--------
>  drivers/net/can/dev/skb.c    |  7 +++++++
>  4 files changed, 43 insertions(+), 18 deletions(-)
>=20

> diff --git a/drivers/net/can/dev/Makefile b/drivers/net/can/dev/Makefile
> index 5b4c813c6222..919f87e36eed 100644
> --- a/drivers/net/can/dev/Makefile
> +++ b/drivers/net/can/dev/Makefile
> @@ -1,9 +1,11 @@
>  # SPDX-License-Identifier: GPL-2.0
> =20
> -obj-$(CONFIG_CAN_NETLINK) +=3D can-dev.o
       ^^^^^^^^^^^^^^^^^^^^^

Nitpick: I think you can directly use "y" here.

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--nsn6qtiymrhpcwlo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKbQYgACgkQrX5LkNig
0114iwgAgOXlzqpe1RifsdUg7ptDPm5yYnu4hcnrssBkFSEZVvtCRcdmV+FapA2J
HB5UqN03uD/JxpuCuhzDPl39oGx8c9m+MtXGOCkyYFzqjUc631tM0Y9dSf3vSj5b
rkRPA3xcApXgt0pDlLLmooJjEfx8g2FUUljRRk8BQDNT1lo3i98wIIT0VSFnwTkR
S8xg6OQysZaCjk3GtWn+94STiDDokJKa7ue3Xu7sdJPMdMvuFXBY4DzbjeEKYSk6
VzgIhEgT+kloeETZBpu6EyyPMB6kRs2z+TweliXlrz3LMUuMDNDkYuYloilkUnAW
YTPJ/h2TnEEwitzBb8VQTBNIA14lGg==
=RtEe
-----END PGP SIGNATURE-----

--nsn6qtiymrhpcwlo--