Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp125707iof; Sun, 5 Jun 2022 23:07:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEuBDDB4CybMMtWA3bgYT0vmWzvgkq4ZiJCUWRsEGiWLEnieMIZJ5h7mpufEjJwcrkSbUH X-Received: by 2002:a63:2b87:0:b0:3fd:31d6:6a0e with SMTP id r129-20020a632b87000000b003fd31d66a0emr12578542pgr.488.1654495675779; Sun, 05 Jun 2022 23:07:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654495675; cv=none; d=google.com; s=arc-20160816; b=hzxfSk8uZCIS6YwKXOiisYlQxijFAGdjumoTEhgn5iiAbtnT7vCRSY4zPkyJ/uEv8X pW6MhaLQDbd9YgebtHuopUPMSLLbx8+o7jCRyt7lfeWe3LuNujDiHHgTrLaCKgN/Ypcd ok6BsdmoEiRDVU6WjnTnLCS5S/fkZSqvJtmdy4HDzSsJy07qahy54rVLlFUFKWWLpBgb CMjyuodvNI4D4XOzX8vpFLFXER/D5Bswcaqd8Qibd+tUjxxrrdkDCRlXrsuVrksvhYcQ On/ShAqTwpuGa9/ECy0SS3gTjiN2mvcMHIEPGa56YxdQyiQTKyG3pYY0Vv64I+fuPWPy /TJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=zut19pl/BUZXXaNZH5dMwhS5QkgGoG3FohWFDv1uCNs=; b=Mc3mdHovx3sz+KDefqEs6dKbbaAy9qyoVsm9h7V3aVw64hjSgeiiHS6BLVyQwcJVxh Fntf++UHuFu0CDPOQd2XxaxOeL6H2DuVC6GoC46qtCCaDKOm2cOGc4U92XZ8XbARoBzo 53RZETmwNJeZq+m1cphTv5rAaWw7luPEkjXACPabH8k04BfCeVJ0lb4tSe4A+jcy8Ll8 eJM+cvteBmhEPIBK9tA+q3ksImvuTMsbryV02YWuIM0shEESVNjRjeUTspuYg1p5vKmp bOyojFdMn4G8/ZI0hfY7Sa4rFnmBsOx+1rox+oMwpLbPr9GuKD+1KGRyV2OWwOO+VNGx hq0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nco8FdQW; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id w10-20020a170902e88a00b0015d0aa41a88si26956648plg.442.2022.06.05.23.07.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 23:07:55 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nco8FdQW; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0D373BF11C; Sun, 5 Jun 2022 21:57:30 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349206AbiFCWIs (ORCPT + 99 others); Fri, 3 Jun 2022 18:08:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245510AbiFCWIr (ORCPT ); Fri, 3 Jun 2022 18:08:47 -0400 Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 010A628E36 for ; Fri, 3 Jun 2022 15:08:44 -0700 (PDT) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-30c2f288f13so95428057b3.7 for ; Fri, 03 Jun 2022 15:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zut19pl/BUZXXaNZH5dMwhS5QkgGoG3FohWFDv1uCNs=; b=nco8FdQW1bEC2bR7g2JLLUI8UlhXzwHVOCndQpL0eLon5vBviKZ5PqfRDHUkp400DR C8d81xwFUPClu1pvpcynp7zc+xmb6njbOokhMMezgQAjfne8ZqV//0Swi4P8B1S1CQoa xNWb43r29E/mshrO46297uuKRbFUmSB7/zzU/+HQWtdFAtfa/6VYtaEe+2uFqayTSF0c io6FUXNSqh9c1JZdnjHOZXFoTvUHj27kXXYg55SnrowuI2MkNnp9k/wfGr1FT2xbap3I 8aAec0spL9NdGPW/9H9sLzVUym+Q/ZZnp+QAF1a+gXz9KGhUBjiD0D0pkV/hPgkMi+JL V6XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zut19pl/BUZXXaNZH5dMwhS5QkgGoG3FohWFDv1uCNs=; b=UIf6MCSBrbT7mDE/rkpZfEQ6LB7B5gxCrTafvWIUmmFavN0wj0e8b9OVlVP/fIIv3e RqIr02lojEKqe8bL7hNrYN/0ll2EizfNMPbf0Aj41RQqqpY2wTMJN45eARZsRwPcUPA1 sP/G1l0p/ul5L15VXyOWJra7ee5BlqZcG25rYBeArlqMbKzFuH+t/DN0o97Fvrxq3igH +umd7tqv3BCoUuqoKvUNjbiYkTYjsl2Av4eRJfpceoTw8PseEzUjOFJt0e8cugdILpzM qZrgRypFjK/bIEQluUFuhZ/wg3p0yvL8Y6thhuneaZNt1HZ8G0+qVcHNODpz5MCR0ZuF 2gKA== X-Gm-Message-State: AOAM532LDdqGAZWoTk343UR/07NWNvr34OqSCghmIVq4p5UtwUnhI3Nn BpJwyvkneQ3aUxRl3meh5uJRhrA2yCZuIoxfk1iU9A== X-Received: by 2002:a81:fe0b:0:b0:30c:7e9c:701 with SMTP id j11-20020a81fe0b000000b0030c7e9c0701mr13632194ywn.118.1654294124240; Fri, 03 Jun 2022 15:08:44 -0700 (PDT) MIME-Version: 1.0 References: <20220526081756.32998-1-linmq006@gmail.com> In-Reply-To: <20220526081756.32998-1-linmq006@gmail.com> From: Linus Walleij Date: Sat, 4 Jun 2022 00:08:33 +0200 Message-ID: Subject: Re: [PATCH] ARM: integrator: Fix refcount leak in intcp_init_of To: Miaoqian Lin Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 26, 2022 at 10:18 AM Miaoqian Lin wrote: > of_find_matching_node() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: df36680f1a71 ("ARM: integrator: core module registers from compatible strings") > Signed-off-by: Miaoqian Lin Patch applied manually (target file moved in the tree) Yours, Linus Walleij