Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp126569iof; Sun, 5 Jun 2022 23:09:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4RiXpka2shnNTWDd0oUD0FAsaCs1wgkGpo95WQ3zcj5Lk+f50rRFmFbxwLnChrZtbK12N X-Received: by 2002:a62:be14:0:b0:505:a43b:cf6e with SMTP id l20-20020a62be14000000b00505a43bcf6emr89983095pff.33.1654495777988; Sun, 05 Jun 2022 23:09:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654495777; cv=none; d=google.com; s=arc-20160816; b=ORzCxxGVYTgOVAmPQQMV5WbxxBfeDfwEoZmuR9QqgruWwuMzTo7jj1kso2FXowyJCw KD/DofCq8bfzLqKdA/YPw4hR3TEd2qMxWbHa/NwJM5yIlWBJlvPq/Vc/cLU+v1ZJmtzp G46Lq0FDaT+SYIXGbxlZh8mQ8lXG0aaZGlkIVm0VFpi1Lig9wMUo1GqZ5PZy72DohZT2 iEoaZv6sERX4Dtk24saHiuWICef95Mn5VlPXSoX/eXqd5Atc6YV/DmE2ADX4Mwq2qrdP RKTJlHUh7V1h+NwlMSUs5F19IlUEfQz9VyN5NVfmHxy/8CQWtsfKDEE11Q/I6Li+JBv6 hAmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5BhKZd1ZztUFuFtohu4ix955CtOvlBJ4OzYqsyB12K8=; b=nGXAkddDkG0Aeo+vPCTDUbpLEl30m39MgUdwWXG10dWNgGZUdHGXeMZKygWE5HpDME fPDm9zWoquosd479M3Mwe1HjCtf3lK2DJJPgtiL6RS0TpC5dql1YVCY6sGguDbs8Jb62 Nk7EEm1GFvqBpf+q0pTHfKqHkVxzhyE4CqMyb22l56afrtwi6t4LGgAbMlFR99gkmpFE gsDL+EQhG0tf/e9C+GSHTCCFxRHI1i1m60GhU202G9Kdnj9Ozb6f5ZKl5bVzlKXN7gA9 pAH8i7rpYDF3Y6ZEC2G9oBO3o/JsGQRAS5zdYnZCxxfCzbb93iEuJ0k9pDCceYy9LKet U5vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=doejqQpf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id x11-20020a170902ec8b00b0016390f2f284si22084021plg.167.2022.06.05.23.09.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 23:09:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=doejqQpf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 88C22F45F0; Sun, 5 Jun 2022 22:00:49 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244737AbiFEI2T (ORCPT + 99 others); Sun, 5 Jun 2022 04:28:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240098AbiFEI2S (ORCPT ); Sun, 5 Jun 2022 04:28:18 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99158286C5 for ; Sun, 5 Jun 2022 01:28:16 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id d22so9924069plr.9 for ; Sun, 05 Jun 2022 01:28:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5BhKZd1ZztUFuFtohu4ix955CtOvlBJ4OzYqsyB12K8=; b=doejqQpfz9ht/RQ+t1MfOyTZgVOi5NUVQwtmSNk3icJY41qCkgzM3wefT3Y0hwCIGs 6Go7a8QuyARo4srDXXsx824/KaEqFHz5CC2FQsOscnOpJZQ7LdwAVw9GYtldLunGpmQf nNP8EJkJUVNH5jhFO3GGZGkwVti36ZHnvmc1SYT4YOaF/QYAL+tL/5NYSc8qNrR44xZh KvU7474brhY19TEcrDdQ4SK04ewQ5SC7+SNtXm/TOh9qUlhXZz9FheHmuJb8+tB4m9/N HwGWG6f/aynWlwD5KdiF2pWS6AkaPtt4cxc0ME3KOTuzTtf+g0O9gN/3eSNaDWrwFz5k NDdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5BhKZd1ZztUFuFtohu4ix955CtOvlBJ4OzYqsyB12K8=; b=cUXQdEPC8LuGalXNSAYiS5iXbqrENAq1MHyscXXVJx35nED0VvHFg4/s+qvv6QlpO6 onI8LkZj5P2SoMkhohJk5DINpPYqFUbdwriBpX9agKYCwFJ/FQ4yOnp3j9DWD1EJdiIc uoQYjVnk0Vft22F9YNcK4vnTcK+e5x4Gl8IuPlK+avN9bRKw2Y8qUl2NNOUginMlvSHG 4xHckjmQdwkEEbcNqZd3bfOp3tz0yfEKLTrUsa5ZAxR7ZtzA9uS8zM18i4dGmriMzCgA LN9QGqDBy5qKirbBoG95n27zvvKuh/3VMRD88/o9M5Zgx6/886+TGoD+1h9ea8NpYqO0 6s2w== X-Gm-Message-State: AOAM531S4Drdqp+Ia6bW0ay14lV1AkzLW38YGcpFx8Mhw9VgcuZnzzAI icCF4EuuV0rYVRk0H220B4JLA6Oa/Lbrc9SL X-Received: by 2002:a17:902:e5ca:b0:164:1958:c84a with SMTP id u10-20020a170902e5ca00b001641958c84amr18409178plf.72.1654417696119; Sun, 05 Jun 2022 01:28:16 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id l24-20020a17090ac59800b001e25e3ba05csm12820399pjt.2.2022.06.05.01.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 01:28:15 -0700 (PDT) From: Miaoqian Lin To: Russell King , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] cpufreq: zynq: Fix refcount leak in zynq_get_revision Date: Sun, 5 Jun 2022 12:28:07 +0400 Message-Id: <20220605082807.21526-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_find_compatible_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: 00f7dc636366 ("ARM: zynq: Add support for SOC_BUS") Signed-off-by: Miaoqian Lin --- arch/arm/mach-zynq/common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-zynq/common.c b/arch/arm/mach-zynq/common.c index e1ca6a5732d2..15e8a321a713 100644 --- a/arch/arm/mach-zynq/common.c +++ b/arch/arm/mach-zynq/common.c @@ -77,6 +77,7 @@ static int __init zynq_get_revision(void) } zynq_devcfg_base = of_iomap(np, 0); + of_node_put(np); if (!zynq_devcfg_base) { pr_err("%s: Unable to map I/O memory\n", __func__); return -1; -- 2.25.1