Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp129111iof; Sun, 5 Jun 2022 23:14:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwWlN6r3G6QMOwJy/tRbjTjmvXbwXiDoIUL42rpo9oWlXM1BLsG7L4/WulwQdNrPBmSBASz X-Received: by 2002:a63:ea4f:0:b0:3c6:6534:d8f2 with SMTP id l15-20020a63ea4f000000b003c66534d8f2mr19749164pgk.187.1654496046299; Sun, 05 Jun 2022 23:14:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654496046; cv=none; d=google.com; s=arc-20160816; b=TELNAEb4/AuIcRKzJK3p1zrRYZh04NkE7J5DQgHTZFfBXEENQc+hok9tErHgybXSY3 mQzwmPRpMl3tPAduXcNs8TnxbxH+Fl8g7QJrC1HeXdQR+84ch4ipmK5lBub9Q8VK+40b vbKzrLo++stXFlUIcJwzbE9SInsMeOm4wp3V+0BFE++5Z2yGjmlnRgg0kum0HeI11HUU zuqrfzm6/ZrCw/L1ZusoW09Mg6Ns6UZPmTkz3kwoCDPR4NQg/qcOsTBfGu5G+hu9hGBt DFpXmkV66D1We5LTURl4gk8fyhNiDzjjPcztIfmOd/1RW8/UyBRFE71y5gWVqrtFEFMF UnRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8tiiUv4eBu5du21eIL4t/D0KywBJvdO3W3xtbfv6aY0=; b=zcgE0l5yVvbUAxtWn26U6AAWgla4lhqII8DYKo39INqgJT0+vzPdeaqcJEd1RHu79P 7A6Qkw8bE5rbyzwsFq/PLC/UElhQqbKvjjNFhVx7xKiqZtTBuASQsEvSgCeFRcdOuBZm 0rqQW5z3o9cj1zIOvnzLkXDchE3hLx3QVZCszt4T7DOBDH2JQUYp1MQBP5rX3vTr28fq fDELY8Xvr1EqtMtjy5+htPG8xzdOVfLisRv7So4ThhAYvmNhBqJulPYbeqj1mxD6X/BE BZvoKGegasKX6lDdX404GLb1AvfM/U1G9JINWlVQ7pISUIUysL0KSGgRjjg4jeVN3CZ7 r0NQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Spx54QQb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id p11-20020a654bcb000000b003c281e1fd7csi20059771pgr.214.2022.06.05.23.14.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 23:14:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Spx54QQb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4E087ADBD7; Sun, 5 Jun 2022 21:53:02 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351339AbiFERzJ (ORCPT + 99 others); Sun, 5 Jun 2022 13:55:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236252AbiFERzH (ORCPT ); Sun, 5 Jun 2022 13:55:07 -0400 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA5F64B1DD for ; Sun, 5 Jun 2022 10:55:06 -0700 (PDT) Received: by mail-qk1-x72e.google.com with SMTP id 15so4339687qki.6 for ; Sun, 05 Jun 2022 10:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8tiiUv4eBu5du21eIL4t/D0KywBJvdO3W3xtbfv6aY0=; b=Spx54QQbJ3FvO5ogfJ4LHHNYOWvAsInam2fKcwOy+Lkl84OL8pNIuekva1D0OHiItt NeXqLtyi55jEqBOamyMhLrLnhLgsqlknzxwHHPWeff+eCDDVwbnPx8IsBziaPM3dkUEA +C/zl3Nm/lNAfnRhCC31ALXNXHU5MOCU7cmO9B/2ud1bngrnYUDz1aZOggkMTMfYjawh /PTpbC51nvZlq2LjmymLu9ubQklgpSELjXp+Ddx+GETt5BficSeQJa0MGMSmhiWJqvuA 1g40E3W2NVcALCamauZ+RnmuLSgbhlSNpta1923m3tH9TL6s7c+1UKPUKet/3TaR6Vkr Adpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8tiiUv4eBu5du21eIL4t/D0KywBJvdO3W3xtbfv6aY0=; b=TV62usqU/elZ0P7rmVicfrT5+BsgEMbr+w4BKY5FpTU8EUAzkXAkKEjQdkheylE4Wy mvc56D67npjhO6MO5r4oiXgMvvPZv5wDnUMBd86RjG7iV4vO/Ohl+3xXKAhYaNkXMJgh K8BJjiIn8fE8I7H65CU8K3XZ/XI2Yfq4/eR0kshM25t9lPmOBMkjreHtJYO0ykUDHp1R I/hJ1o/OaR/AIfLgO8/mo/VBwcjpaYpCpZ4d6tS32twyTPcKH5kDN1NN9ZfMuygse3a3 MRJsjFlKQicDcrLu9kCl0qK+FQfP1zLg8suz+uT0XHvduKpxkPjG+ID7epQpW+a/S1/I Yspg== X-Gm-Message-State: AOAM533OHlH9FWx6e0izLzCMDOhBsy11vEDw/mqfTkv1K8jAlmQ6CQx2 a4pKcrPB54GYKbHKp1xVVtpApnRUTyiL X-Received: by 2002:a37:8701:0:b0:6a5:ff4f:b2bc with SMTP id j1-20020a378701000000b006a5ff4fb2bcmr13483219qkd.584.1654451705953; Sun, 05 Jun 2022 10:55:05 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id br9-20020a05620a460900b006a6539862f8sm10272057qkb.40.2022.06.05.10.55.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 10:55:05 -0700 (PDT) Date: Sun, 5 Jun 2022 13:55:03 -0400 From: Kent Overstreet To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, pmladek@suse.com Subject: Re: [PATCH v3 00/33] Printbufs Message-ID: <20220605175503.ug3cjtv5tjmmornx@moria.home.lan> References: <20220604193042.1674951-1-kent.overstreet@gmail.com> <20220605122110.22176bd9@rorschach.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220605122110.22176bd9@rorschach.local.home> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 05, 2022 at 12:21:10PM -0400, Steven Rostedt wrote: > On Sat, 4 Jun 2022 15:30:09 -0400 > Kent Overstreet wrote: > > > Printbufs, your new data structure for all your string-building and outputting > > needs! > > > > git repo: https://evilpiepirate.org/git/bcachefs.git/log/?h=printbuf_v3 > > Hi Kent, > > Just wanted to let you know that I want to review this and I'm not > ignoring it. But there's a still quite a bit in my queue that I must > review before I get to this, so it may still be a while. :-/ Could you just review the parts that touch your code then? The rest has already seen some review and Petr's going to do more, and I'd like to get this patchset done and squared away so I can go back to building my OOM debugging improvements on top of this stuff :)