Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 6 Jun 2022 15:48:54 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Akira Yokosawa <akiyks@gmail.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        linux-gpio@vger.kernel.org, Joey Gouly <joey.gouly@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>, linux-kernel@vger.kernel.org,
        linux-next@vger.kernel.org
Subject: Re: [PATCH] gpio: Fix kernel-doc comments to nested union
Message-ID: <20220606154854.653c08ee@canb.auug.org.au>
In-Reply-To: <27612e81-d843-d161-ecd2-c653c7d5bae9@gmail.com>
References: <27612e81-d843-d161-ecd2-c653c7d5bae9@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/OxU+zvSxT+aW_NkUeZrEfx2";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/OxU+zvSxT+aW_NkUeZrEfx2
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Akira,

On Mon, 6 Jun 2022 13:44:24 +0900 Akira Yokosawa <akiyks@gmail.com> wrote:
>
> Commit 48ec13d36d3f ("gpio: Properly document parent data union")
> is supposed to have fixed a warning from "make htmldocs" regarding
> kernel-doc comments to union members.  However, the same warning
> still remains [1].
>=20
> Fix the issue by following the example found in section "Nested
> structs/unions" of Documentation/doc-guide/kernel-doc.rst.
>=20
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: 48ec13d36d3f ("gpio: Properly document parent data union")
> Link: https://lore.kernel.org/r/20220606093302.21febee3@canb.auug.org.au/=
 [1]
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <brgl@bgdev.pl>
> Cc: Joey Gouly <joey.gouly@arm.com>
> Cc: Marc Zyngier <maz@kernel.org>
> ---
>  include/linux/gpio/driver.h | 29 ++++++++++++++++-------------
>  1 file changed, 16 insertions(+), 13 deletions(-)

Looks good, thanks.

Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>

--=20
Cheers,
Stephen Rothwell

--Sig_/OxU+zvSxT+aW_NkUeZrEfx2
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmKdlUYACgkQAVBC80lX
0GzMeQgAmySfWjcyc+xFr/XHVcCpHvT2l98zbkfuyMs8Bu2vsutDKzizn/+T7hof
2k5YYIAsxJSGd7bcKKyW6WuuCYILScEKiD2Lmh0RdDMMg6gOCdsoYA7VfYUhplvw
qyCOx9xlE2Zlcjgu3K0XJEXDqKM9j4/CCbqWxlZLfJjEoWJyBhWjYv/Q7w/ZyqFV
tI7suLKwiC0QXSWpKdP/m1xE8r92CdNsALaL1pN8uWureqDNDZfIFRxGxf4yZTAE
lJjGvuxhfO7JYsaepVKmDNmNsYrSQbOkHT8lCx+ZFGzbgHTWgyEJNNs+zJ30SDrx
5y4ZlcwFKNQeU7ZF/dx8CkFERNv/SA==
=KKQb
-----END PGP SIGNATURE-----

--Sig_/OxU+zvSxT+aW_NkUeZrEfx2--