Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <33aae30b17a14b41212f9c3ed0f8943817a835d9.camel@redhat.com>
Subject: Re: [PATCH 2/2] l2tp: fix possible use-after-free
From:   Paolo Abeni <pabeni@redhat.com>
To:     Xiaohui Zhang <ruc_zhangxiaohui@163.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.or,
        linux-kernel@vger.kernel.org
Date:   Mon, 06 Jun 2022 10:10:01 +0200
In-Reply-To: <20220605115412.16004-1-ruc_zhangxiaohui@163.com>
References: <20220605115412.16004-1-ruc_zhangxiaohui@163.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hello,

On Sun, 2022-06-05 at 19:54 +0800, Xiaohui Zhang wrote:
> From: xiaohuizhang98 <ruc_zhangxiaohui@163.com>
> 
> We detected a suspected bug with our code clone detection tool.
> 
> Similar to the handling of l2tp_tunnel_get in commit a622b40035d1
> ("l2ip: fix possible use-after-free"), we thought a patch might
> be needed here as well.
> 
> Before taking a refcount on a rcu protected structure,
> we need to make sure the refcount is not zero.
> 
> Signed-off-by: xiaohuizhang98 <ruc_zhangxiaohui@163.com>

It looks like series this did not make to patchwork, due to a typo in
the ML address, please fix it and resend: netdev@vger.kernel.or ->
netdev@vger.kernel.org

Thanks,

Paolo