Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp248281iof; Mon, 6 Jun 2022 02:40:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwERpEfwLqsCnF/JuhSz9hsieF2asQra4O2Zakia2MhpXxfiehfLgaRvszeLvlPjy4Qx7rf X-Received: by 2002:a63:2107:0:b0:3fb:ac79:50ed with SMTP id h7-20020a632107000000b003fbac7950edmr20657975pgh.105.1654508449992; Mon, 06 Jun 2022 02:40:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654508449; cv=none; d=google.com; s=arc-20160816; b=fr/WSPa9gD10p/wXDk6EK7CFP6RQyYRUENgG6Z3/+CJgbsiof0U8ZSNY+6gx6QUHTT JGsnOMYaDWP9VCTT+5Nx1WHGqlrbv1MphHApFgWuEJ5b3XohJ1upa9l9v8XIb+iDimsI WrLZNP+GA4H1Q8sMJkw/xULUb6jDHrBbUADP4AevX+MtQhx9JG45Et/WnSh2eomYdZnQ vPJGVBwlv46OO25CGux50U05SotlT08zpmkzHRX76hYy9R8HM9MFlv/OQzQzc+XzOF6x 6FFgEsePZaQIKyDgugzIEz5R2nJL2Wvipbb+s6E0fY8vMPiH6kamoKkjRlixxK9T+N9+ KViQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BPuEXMq+9lFEX3s+CewNQ8QOCm+DO64U8n+0VKR7QWA=; b=T9Uwz5t37B6M6Fji1+fRt9IqgJjhkUkEXS3Dva4y15Af/RGZdOXRRW+D7GtIhD2J2g nS3JY/TyThsUkb0SaNjobg724cWylnlmMaGD3vPV7UjopIWBEN3OG8k6DVv7qcd2Dn5j 57Jir451eHFMAFyao4aW3BhY8n2KuHUtGdPchNb8aaWM0gcIKJE0yitUT7lZIBAfWWtZ ZLdm0lyu8cMDmX6Whz/WoB5UB1yeCDZiumzqI+o3AAo3gwmlwroc+hdmdYUu9YRe6Xzp 39d+efK+ppQXsuOox7mBpa+avRmBtPN8/OhscpinajBZ51ScA5PjXA/54aLuCYIQBeMb iR1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HK+Nt7xT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id j16-20020a056a00235000b0050dd5a66df1si21791764pfj.181.2022.06.06.02.40.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 02:40:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HK+Nt7xT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DB6745B3EC; Mon, 6 Jun 2022 02:21:10 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232692AbiFFJVC (ORCPT + 99 others); Mon, 6 Jun 2022 05:21:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232758AbiFFJUz (ORCPT ); Mon, 6 Jun 2022 05:20:55 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B47637AB0 for ; Mon, 6 Jun 2022 02:20:53 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id gl15so13838909ejb.4 for ; Mon, 06 Jun 2022 02:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BPuEXMq+9lFEX3s+CewNQ8QOCm+DO64U8n+0VKR7QWA=; b=HK+Nt7xTLdOK4LakJ8fa1HYObrvUhYOKzTayvt6U/GnZYaeLXZmchU+MGT8KOKEoAC mT4eXur0L2XfiuDlWK0H7ob5mehbXpY1L1L1ox73iApWtDylOAkhlO/PfAR4OVpbd/E7 RHgV5b8Z3peVnFnsvRJfBuwFhCEBiyem9XiokL1U3euUdohlP6/sWhyhiGY4wVGa/Uqs rQ0Xcl9tDp4pIA6sswu97F74HnZKzGIsAGzcc3FXX0ri0YR9Akjm5OpbegeXFjNJ6G9c +UVy4AWPEoxw1sY9oNlYLfvfEOR1z7wjMJVRoagfACbjncjKmD48fekXNKxSiyVsai9J v27w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BPuEXMq+9lFEX3s+CewNQ8QOCm+DO64U8n+0VKR7QWA=; b=xr+S753INs+lvWjsUav+rY/pbF0UZGlUmrv+TeNyBWi5PzN847cSwIKxUwhRuHKf+T hUYVNNfiwQr6bbGDcZWw3lagLaJZ1nAY71zUiD8WLDFq3We1T/YCbX6az5jvswI48v1I p9BUVAnUKQHxNMqT0/3gv5SF3hFoIi4iEMVfwK5sc4yecUVhNiQAALPwajwXtT6gg+zK OqvsAGLxy/KpJGlgtV78J9xyVHpRAfmO5sjHvPGZBFxW9vS98zvHa9uvcoYz70pHVP+T 0i+GFF2AtsSG5t6YO2KQkmjolcQW8nj7CDSLbxsIVzC1Dj5VSbMyF/Qvf2a1cQIpwSdw E5jQ== X-Gm-Message-State: AOAM5300GJqMZDpzitcYhwhyvYquzUomJJYjwnEgn+v58ryFBpSN8+eY qkfeHz8SOObVuOnKUtUlrOn5LQ== X-Received: by 2002:a17:906:af0d:b0:708:d48a:271 with SMTP id lx13-20020a170906af0d00b00708d48a0271mr20415081ejb.329.1654507251574; Mon, 06 Jun 2022 02:20:51 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id b6-20020a17090636c600b006feb6dee4absm6067412ejc.137.2022.06.06.02.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 02:20:51 -0700 (PDT) From: Krzysztof Kozlowski To: Lukasz Luba , linux-samsung-soc@vger.kernel.org, Miaoqian Lin , Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: Re: [PATCH] memory: samsung: exynos5422-dmc: Fix refcount leak in of_get_dram_timings Date: Mon, 6 Jun 2022 11:20:46 +0200 Message-Id: <165450724182.62574.13510345979647280538.b4-ty@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220602041721.64348-1-linmq006@gmail.com> References: <20220602041721.64348-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2 Jun 2022 08:17:21 +0400, Miaoqian Lin wrote: > of_parse_phandle() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > This function doesn't call of_node_put() in some error paths. > To unify the structure, Add put_node label and goto it on errors. > > Applied, thanks! [1/1] memory: samsung: exynos5422-dmc: Fix refcount leak in of_get_dram_timings https://git.kernel.org/krzk/linux-mem-ctrl/c/1332661e09304b7b8e84e5edc11811ba08d12abe Best regards, -- Krzysztof Kozlowski