Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Subject: Re: [PATCH v2 2/3] usb: phy: Add devm_of_usb_get_phy_by_phandle
To:     Harsh Agarwal <quic_harshq@quicinc.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Felipe Balbi <balbi@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
CC:     <linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_pkondeti@quicinc.com>,
        <quic_ppratap@quicinc.com>, <quic_jackp@quicinc.com>,
        <ahalaney@redhat.com>
References: <1654276362-28930-1-git-send-email-quic_harshq@quicinc.com>
 <1654276362-28930-3-git-send-email-quic_harshq@quicinc.com>
From:   Sergey Shtylyov <s.shtylyov@omp.ru>
Organization: Open Mobile Platform
Message-ID: <c52d93db-e89a-24ba-725c-420641bd43af@omp.ru>
Date:   Mon, 6 Jun 2022 14:00:56 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <1654276362-28930-3-git-send-email-quic_harshq@quicinc.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled
X-KSE-Antivirus-Interceptor-Info: scan successful
X-KSE-Antivirus-Info: Clean, bases: 6/6/2022 9:18:00 AM
X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,
	RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello!

On 6/3/22 8:12 PM, Harsh Agarwal wrote:

> Adding support for devm_of_usb_get_phy_by_phandle which allows
> us to get PHY phandles of a device declared inside lookup_node.
> 
> Signed-off-by: Harsh Agarwal <quic_harshq@quicinc.com>
[...]
> diff --git a/include/linux/usb/phy.h b/include/linux/usb/phy.h
> index e4de6bc..2581c72 100644
> --- a/include/linux/usb/phy.h
> +++ b/include/linux/usb/phy.h
[...]
> @@ -249,6 +251,12 @@ static inline struct usb_phy *devm_usb_get_phy_by_phandle(struct device *dev,
>  	return ERR_PTR(-ENXIO);
>  }
>  
> +extern inline struct usb_phy *devm_of_usb_get_phy_by_phandle(struct device *dev,

   *extern inline*? :-O
   Shouldn't it be *static*?
 
> +	const char *phandle, u8 index, struct device_node *lookup_node)
> +{
> +	return ERR_PTR(-ENXIO);
> +}
> +
>  static inline struct usb_phy *devm_usb_get_phy_by_node(struct device *dev,
>  	struct device_node *node, struct notifier_block *nb)
>  {

MBR, Sergey