Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 6 Jun 2022 14:13:32 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: drivers/cpufreq/qcom-cpufreq-hw.c:333 qcom_lmh_dcvs_notify() error:
 uninitialized symbol 'throttled_freq'.
Message-ID: <202206010736.NcY0Y2fK-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?p5WMXfMT6I7OckQMdVuPpsAOiKqPCNjQ64et+cFpxgXtTHlsG6qW9azqZ8jf?=
 =?us-ascii?Q?5aO2pM0qF38mjqO+ly+6Rj1rfl8jxG1l9zJJV/OUSSKz4kCSgG/QKiGxNwXx?=
 =?us-ascii?Q?7t1AWbDt2fDCjLmw0QrCnVEmn1yF9Dqxuib1sACdUzTfyohNTsyErcpbEwKg?=
 =?us-ascii?Q?c97z+hIzQmmhgrbV8zkmCfrO1YxS78MazVf2X42hIZjR10TH1jnyoCf77EDT?=
 =?us-ascii?Q?I1EBWikhEO9gE/2/n32Zchj70gDrQHFgiVtNdM4G56U8TM3Me6F84DXtpBJH?=
 =?us-ascii?Q?aromQ81SOTmZgKvrXJMPgJTj/s7ALB4eEFpgtcC7PdZXywfo7Yx7Mjfka6VP?=
 =?us-ascii?Q?xIzPEf3/fVecaplBLUexv4nanhg5H/JMKd58eJw7Q4uf3Za90B/E8zYVWiGV?=
 =?us-ascii?Q?ymUSCyRQGFrqwZVEJx68CrrVNhu5UsAbDCdHtSCFXZlwPF4ve6SMkk94UuuC?=
 =?us-ascii?Q?a3y5cYcW22PQng9lchkFpBVui3nVoupXiXPDGUprz4C29U9N1EpyUaBAftDZ?=
 =?us-ascii?Q?NJ0PcMA/KVTBa2hES0gC+YEubH09/NkSlMMuiPgQEzpMBEhiVDnLc3zoq0Ug?=
 =?us-ascii?Q?XGg4clGu3q3tYto+6BQE9Rvs4ZdLS8L1Q4GICvoCrxUAXQn/aWzbt495k80L?=
 =?us-ascii?Q?s+mIRFFdc6traBF9fr0VuPpSgJrcYhM5YiRkpnt8Y+ttFtEfL27+HMpEUVjw?=
 =?us-ascii?Q?zJfEzjLTUG/OjfkwNlh4uBBRScUCqcSIh8WMMMk23xyLt68iGu+6ZzOOVY6c?=
 =?us-ascii?Q?Gp95Zd3BENuT9yPQFOeYYN/2nKLBs4oWVLvlIzyC/EV+HBs0X+USMuajM2iL?=
 =?us-ascii?Q?cIG762rVHimFOQU/29/tSw5Gb0s+y3/sUDWgCN5/ZWd8PPxTo8BXENlYycci?=
 =?us-ascii?Q?2Mt5nsBXByHLlwIOLkCVRF0u1skE/JPRhvkS26UW1pKKrqnQZVQrgoLwAbdN?=
 =?us-ascii?Q?il8BcmctDEhoKYt4fUxMAqLU1ALK4nfc8wChW1Fnkt/iuKzXyt+BKOEymvHQ?=
 =?us-ascii?Q?hHMov8Y0/PhMumIk6VvcsHt70Rxt3KU0vGU1gpNTDLGnXR+uge0XpGReV7WA?=
 =?us-ascii?Q?4h0dpxDA31TWhUj3bTg0VfMurnc4hS6wL0cny71x9dDyR43xrIaP5fzm+TQ2?=
 =?us-ascii?Q?taUDFABZxVoigrEdV0BXb8ovqF6ZNLfLSfu1iqdXAHZgJ33ZkoTeFsIBCiOP?=
 =?us-ascii?Q?rjokqs7ydXbOsEkxWRbkeH/aZ0exlE8EXEKJHrUJLsu7AfqsPgzGXfeD+uKN?=
 =?us-ascii?Q?XRVPjkaleLMkE49P9SU4wiUImp4q7U3yxW3liMhD1gEKRYncZ8Bf8xcBnWUm?=
 =?us-ascii?Q?fm41LZSWtcO2Iv8VHYeimnUgDLEBp3yXZNyfkFY3OHfRD2lfsqj05TOAuinu?=
 =?us-ascii?Q?dF50oOz4PCvQf9nHdKU4JOaOyW3HeIqRun9RTSLwjyeTeJmjUaUtXI63/glv?=
 =?us-ascii?Q?i9TXE+OzlOHY3sOakTDd01zst0I+djNLp8xm/XBt6APMXzcn1ZgukK3hZhlC?=
 =?us-ascii?Q?uTUiTIh2eqOAg0Oeh+zjel+9ArMavjg7M79vEuhHuDGIi/Av9T6vhdVeBrGX?=
 =?us-ascii?Q?wcVSy1NVgg63PjKkE+rcQdXTFn0bj6zau36mF1rl+jtycWfjfK6EW2makMkN?=
 =?us-ascii?Q?DnCq3mCrnt7k7qq2WKHoy3UZuTYFX/hLbnWBWCKGjAuOC728zbozOX8q6bml?=
 =?us-ascii?Q?kklgu3t3I5ACbH/KS1IPJ/trmTkhcxivE4yLqVcHHfW2cHM+/H7H3qVpCG0G?=
 =?us-ascii?Q?60QcXMtr5pTB1ddCKWnciSBFAltXMC8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 59b4584c-fc85-42ec-7741-08da47ada36b
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2022 11:13:52.4552
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qiruElkXbDRF/nX+TaVlAU1ll0Rs2qrHaRm3RkLrEawpbamsSEftLv5AE/CCTsdW2gC0LS7AtgurtQ/mtqV1/2Y3worl6tumV8ieVWzTocc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5295
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-06_03:2022-06-02,2022-06-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 spamscore=0
 phishscore=0 mlxscore=0 adultscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206060052
X-Proofpoint-GUID: cqWeu7GR1XJnOHTn6DeR3FCIXty_ARyg
X-Proofpoint-ORIG-GUID: cqWeu7GR1XJnOHTn6DeR3FCIXty_ARyg
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   2a5699b0de4ee623d77f183c8e8e62691bd60a70
commit: 6240aaad75e1a623872a830d13393d7aabf1052c cpufreq: qcom-hw: fix the opp entries refcounting
config: arm64-randconfig-m031-20220531 (https://download.01.org/0day-ci/archive/20220601/202206010736.NcY0Y2fK-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/cpufreq/qcom-cpufreq-hw.c:333 qcom_lmh_dcvs_notify() error: uninitialized symbol 'throttled_freq'.

vim +/throttled_freq +333 drivers/cpufreq/qcom-cpufreq-hw.c

275157b367f479 Thara Gopinath   2021-08-09  290  static void qcom_lmh_dcvs_notify(struct qcom_cpufreq_data *data)
275157b367f479 Thara Gopinath   2021-08-09  291  {
275157b367f479 Thara Gopinath   2021-08-09  292  	struct cpufreq_policy *policy = data->policy;
5e4f009da6be56 Dmitry Baryshkov 2022-03-26  293  	int cpu = cpumask_first(policy->related_cpus);
275157b367f479 Thara Gopinath   2021-08-09  294  	struct device *dev = get_cpu_device(cpu);
0258cb19c77deb Lukasz Luba      2021-11-09  295  	unsigned long freq_hz, throttled_freq;
275157b367f479 Thara Gopinath   2021-08-09  296  	struct dev_pm_opp *opp;
275157b367f479 Thara Gopinath   2021-08-09  297  	unsigned int freq;
275157b367f479 Thara Gopinath   2021-08-09  298  
275157b367f479 Thara Gopinath   2021-08-09  299  	/*
275157b367f479 Thara Gopinath   2021-08-09  300  	 * Get the h/w throttled frequency, normalize it using the
275157b367f479 Thara Gopinath   2021-08-09  301  	 * registered opp table and use it to calculate thermal pressure.
275157b367f479 Thara Gopinath   2021-08-09  302  	 */
275157b367f479 Thara Gopinath   2021-08-09  303  	freq = qcom_lmh_get_throttle_freq(data);
275157b367f479 Thara Gopinath   2021-08-09  304  	freq_hz = freq * HZ_PER_KHZ;
275157b367f479 Thara Gopinath   2021-08-09  305  
275157b367f479 Thara Gopinath   2021-08-09  306  	opp = dev_pm_opp_find_freq_floor(dev, &freq_hz);
275157b367f479 Thara Gopinath   2021-08-09  307  	if (IS_ERR(opp) && PTR_ERR(opp) == -ERANGE)
6240aaad75e1a6 Dmitry Baryshkov 2022-03-26  308  		opp = dev_pm_opp_find_freq_ceil(dev, &freq_hz);
275157b367f479 Thara Gopinath   2021-08-09  309  
6240aaad75e1a6 Dmitry Baryshkov 2022-03-26  310  	if (IS_ERR(opp)) {
6240aaad75e1a6 Dmitry Baryshkov 2022-03-26  311  		dev_warn(dev, "Can't find the OPP for throttling: %pe!\n", opp);

throttled_freq not initialized on this path

6240aaad75e1a6 Dmitry Baryshkov 2022-03-26  312  	} else {
275157b367f479 Thara Gopinath   2021-08-09  313  		throttled_freq = freq_hz / HZ_PER_KHZ;
275157b367f479 Thara Gopinath   2021-08-09  314  
0258cb19c77deb Lukasz Luba      2021-11-09  315  		/* Update thermal pressure (the boost frequencies are accepted) */
0258cb19c77deb Lukasz Luba      2021-11-09  316  		arch_update_thermal_pressure(policy->related_cpus, throttled_freq);
275157b367f479 Thara Gopinath   2021-08-09  317  
6240aaad75e1a6 Dmitry Baryshkov 2022-03-26  318  		dev_pm_opp_put(opp);
6240aaad75e1a6 Dmitry Baryshkov 2022-03-26  319  	}
6240aaad75e1a6 Dmitry Baryshkov 2022-03-26  320  
275157b367f479 Thara Gopinath   2021-08-09  321  	/*
275157b367f479 Thara Gopinath   2021-08-09  322  	 * In the unlikely case policy is unregistered do not enable
275157b367f479 Thara Gopinath   2021-08-09  323  	 * polling or h/w interrupt
275157b367f479 Thara Gopinath   2021-08-09  324  	 */
275157b367f479 Thara Gopinath   2021-08-09  325  	mutex_lock(&data->throttle_lock);
275157b367f479 Thara Gopinath   2021-08-09  326  	if (data->cancel_throttle)
275157b367f479 Thara Gopinath   2021-08-09  327  		goto out;
275157b367f479 Thara Gopinath   2021-08-09  328  
275157b367f479 Thara Gopinath   2021-08-09  329  	/*
275157b367f479 Thara Gopinath   2021-08-09  330  	 * If h/w throttled frequency is higher than what cpufreq has requested
275157b367f479 Thara Gopinath   2021-08-09  331  	 * for, then stop polling and switch back to interrupt mechanism.
275157b367f479 Thara Gopinath   2021-08-09  332  	 */
275157b367f479 Thara Gopinath   2021-08-09 @333  	if (throttled_freq >= qcom_cpufreq_hw_get(cpu))
                                                            ^^^^^^^^^^^^^^

275157b367f479 Thara Gopinath   2021-08-09  334  		enable_irq(data->throttle_irq);
275157b367f479 Thara Gopinath   2021-08-09  335  	else
275157b367f479 Thara Gopinath   2021-08-09  336  		mod_delayed_work(system_highpri_wq, &data->throttle_work,
275157b367f479 Thara Gopinath   2021-08-09  337  				 msecs_to_jiffies(10));
275157b367f479 Thara Gopinath   2021-08-09  338  
275157b367f479 Thara Gopinath   2021-08-09  339  out:
275157b367f479 Thara Gopinath   2021-08-09  340  	mutex_unlock(&data->throttle_lock);
275157b367f479 Thara Gopinath   2021-08-09  341  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp