Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 6 Jun 2022 14:25:02 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Marc Zyngier <maz@kernel.org>
Cc:     kbuild@lists.01.org, Hector Martin <marcan@marcan.st>,
        lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org
Subject: Re: drivers/irqchip/irq-apple-aic.c:941 aic_of_ic_init() error:
 uninitialized symbol 'off'.
Message-ID: <20220606112502.GN2168@kadam>
References: <202206010439.LRgjym7t-lkp@intel.com>
 <87zgiq3uux.wl-maz@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87zgiq3uux.wl-maz@kernel.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ixDfjtK8CtdtjwlLUM7bREWICs/z0qLKJs1HaXk8fJWPjUAoBp9waoenw3CW?=
 =?us-ascii?Q?jSh++eiaXpQjd+GC3KhBUkkdqEt39rLADo1Nctt2VVoMTKKr2xSz7p9vJIMu?=
 =?us-ascii?Q?bGo+Rd9g9jEmdCfUEkAFuolFLsV0zPSDb4e+AUovyfsAA9wLy2cb5gKAB4b1?=
 =?us-ascii?Q?3PMors4ZKXprYpi6rZsg0ZLEZPXrzJMyIKucf/vbQozeTAe9jDkmo+eH+rjx?=
 =?us-ascii?Q?0/8ugft8LrV5fxYLEA8JbZ/Pa9rwWRjA6sxqcbuW7rDbEWSUU2deroj7baNl?=
 =?us-ascii?Q?JFURHod5AgGxNgtUYpzoLzuoDFyKi8JDNCyl8qrlzGqA1UBdopepEZp6hVD/?=
 =?us-ascii?Q?KQzC/uTdo0xuf3c4kodFjPOjSvT3OTGNwRsdGHcbJYrQXjei/1yYuu/OO5wB?=
 =?us-ascii?Q?wzcStFedskWVxQfz5hP+Zjvkll0LVFlatH6bbGV5oG++1HQTLGNKaMspx788?=
 =?us-ascii?Q?0HizYtuhOa7yGDwjteIenS6cEAsQwF3kKgiYoV/uVKBlzTcbisKTxIIAGph0?=
 =?us-ascii?Q?8oehBdIqQhAT225i9jA54ND91lsrPKbxn3kt7dCAnoGj1q9VUuD97NdDcmXE?=
 =?us-ascii?Q?Wp8JJEhMHs9ZdTYNLRSrTfhGYV7gg50yJquWQj1F29IisaVCfViMyTlsXXCC?=
 =?us-ascii?Q?1bhU5N/9LLmiijRShEz8jmQbRwfVemcjW5CagRYxkec+sZ8lzm1/88JJiZZT?=
 =?us-ascii?Q?e719q6L9I+XSNT2wIDawy5Xohn+TbA3yHoVLTfeA7PmoGsCNx59IBUKEc0+q?=
 =?us-ascii?Q?g7uZswkHqZze9mqX7mz+LiXX3LCr0rt9v6+AZ6slxuF/aMw5RwAHMbc9G88c?=
 =?us-ascii?Q?G3lUaP13xcCjH4DFFefEXHLJgGno0A7Sq11k913m7s4hVmyIz6D0DzKFMvXT?=
 =?us-ascii?Q?UDWJp824GkIUyeea6dJXA948Vdavr3WRkCYT/psIG/kh0ruQJ7OICDfHCbh1?=
 =?us-ascii?Q?meQbvOj+t9dT1FxWd/MlJzyF0cX2iKgkZy568cCRVrGaqwOt/kyLjpb/gnbp?=
 =?us-ascii?Q?gTjrn+Vm/1rI8+c4OMKHaLhDzQenxps8H0mfr/vWyDe+QjENBYXcGzUa0MoC?=
 =?us-ascii?Q?XaKkbCK20Y5zU9VP3istdfjOJ1ZBGxJm4cw7jjo48SHFxJZZ1w9g8Zz4xig8?=
 =?us-ascii?Q?wd2mpL88EV8QWAA+j22x3rESJbA+WUDJJ/Xx1cGJTnSuUADdi5SReKeAIlCI?=
 =?us-ascii?Q?uyKr+3CNzcE43wWVFv+EXzfHyqxVN7opNCgFwYBN9vUGF1g4Juom31XvUzc8?=
 =?us-ascii?Q?b92wE8stHV8JU4KIcQ22n8uPsYqb6k4dUXVt+r6/V/MEQ3l8m/qREsj55Jxk?=
 =?us-ascii?Q?eE1WYKL2eBLGvknFQr/HzsGN8IEtzpMh+CEu5NaLvHTVC1RFeHzYM1SoXBWR?=
 =?us-ascii?Q?ZHEg5x/5it3Ezwq/RyIemRr6fpjmaKMyiwONTIkNr+5vJDB/j6ygvI+AchhX?=
 =?us-ascii?Q?V7SRQH8qEQ9Nt8RHI9uiaNIWl1xOurnTkUgfLnC/7Wu7apNors/4sSGbC76u?=
 =?us-ascii?Q?aVubOmd9T8dEhg8n6/3hxAj26OC6kow1AKABKVIAdYl0Wzqa+HJVdcVrnaBf?=
 =?us-ascii?Q?/gQvZxCmSlGzc88kUY2hcQ4V5b3/Kb7tVe5WcRQzMj25NuRlUQOIwkBeu5lO?=
 =?us-ascii?Q?HEQNXaulj3r/ExzJ7oR3O2c+DBzPKjvpEokrEKM3eEEzEPXjXtDXhJ/fDGrY?=
 =?us-ascii?Q?lXGRa7dUPAcgGJkrwLG3N/tuIpYmEp7Kz39QNYUgAYvgUu8KDKi6nV2U512w?=
 =?us-ascii?Q?qyqEahfmQ4avmgeoHIO799I0DIHy0dw=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 586158c1-ba5d-48e6-7aea-08da47af3dae
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2022 11:25:21.0258
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HIZGsnRZs3dmlwQvMwcN4p1iP98lZAPDbkq/fxcSyFcNmYPfOac8kZ1kyQyTDTz5AQjA4l4oCGuDvk5AOL95/oJg9qLwts2t8rM5pNpohJs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1974
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-06_04:2022-06-02,2022-06-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 adultscore=0 bulkscore=0 mlxscore=0 suspectscore=0 malwarescore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206060052
X-Proofpoint-ORIG-GUID: C7YWOftWFTKvYVnFS-uY5RFqq5AUgXGU
X-Proofpoint-GUID: C7YWOftWFTKvYVnFS-uY5RFqq5AUgXGU
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 06, 2022 at 12:16:22PM +0100, Marc Zyngier wrote:
> > dc97fd6fec0099 Hector Martin 2022-03-10   926  	switch (irqc->info.version) {
> > dc97fd6fec0099 Hector Martin 2022-03-10   927  	case 1: {
> > dc97fd6fec0099 Hector Martin 2022-03-10   928  		u32 info;
> > dc97fd6fec0099 Hector Martin 2022-03-10   929  
> > 76cde26394114f Hector Martin 2021-01-21   930  		info = aic_ic_read(irqc, AIC_INFO);
> > 7c841f5f6fa3f9 Hector Martin 2022-03-10   931  		irqc->nr_irq = FIELD_GET(AIC_INFO_NR_IRQ, info);
> > dc97fd6fec0099 Hector Martin 2022-03-10   932  		irqc->max_irq = AIC_MAX_IRQ;
> > dc97fd6fec0099 Hector Martin 2022-03-10   933  
> > dc97fd6fec0099 Hector Martin 2022-03-10   934  		off = irqc->info.target_cpu;
> > dc97fd6fec0099 Hector Martin 2022-03-10   935  		off += sizeof(u32) * irqc->max_irq; /* TARGET_CPU */
> > dc97fd6fec0099 Hector Martin 2022-03-10   936  
> > dc97fd6fec0099 Hector Martin 2022-03-10   937  		break;
> > 
> > "off" uninitialized if irqc->info.version != 1.
> 
> Which is pretty much impossible by construction, as as of this
> particular commit, all the possible implementations have version == 1.
> 
> Subsequent patches do add cases where version == 2, and that gets
> covered too.
> 
> So unless I'm missing something obvious, there is no bug here.

I assumed it was something like that.  The kbuild bot doesn't do cross
function analysis.  Neither does Clang really.

regards,
dan carpenter