Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <fc350cfd-e9c1-e29e-392b-ede4fe7fb265@linaro.org>
Date:   Mon, 6 Jun 2022 14:54:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v2 RESEND] ARM: dts: nuvoton: wpcm450: Add missing aliases
 for serial0/serial1
Content-Language: en-US
To:     =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= <j.neuschaefer@gmx.net>,
        openbmc@lists.ozlabs.org
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220606123529.1738542-1-j.neuschaefer@gmx.net>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220606123529.1738542-1-j.neuschaefer@gmx.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 06/06/2022 14:35, Jonathan Neuschäfer wrote:
> Without these, /chosen/stdout-path = "serial0:115200n8", as done in
> nuvoton-wpcm450-supermicro-x9sci-ln4f.dts, does not work.
> 
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
> 
> v2:
> - mention WPCM450 in the summary
> ---
>  arch/arm/boot/dts/nuvoton-wpcm450.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> index 93595850a4c3c..57943bf5aa4a9 100644
> --- a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> +++ b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> @@ -17,6 +17,8 @@ aliases {
>  		gpio5 = &gpio5;
>  		gpio6 = &gpio6;
>  		gpio7 = &gpio7;
> +		serial0 = &serial0;
> +		serial1 = &serial1;

Serial aliases might be wired differently per board, so this should go
to board DTS instead.


Best regards,
Krzysztof