Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp451512iof; Mon, 6 Jun 2022 06:41:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsZjrq9B+dIOWOqREv8aErVSDvVES4iiCL2/CeqwcxkRCfIk6G4CrPQoEjts8VO+PvzlNB X-Received: by 2002:a65:49c8:0:b0:3fd:9170:b9c7 with SMTP id t8-20020a6549c8000000b003fd9170b9c7mr7516981pgs.243.1654522862416; Mon, 06 Jun 2022 06:41:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654522862; cv=none; d=google.com; s=arc-20160816; b=tjTjSOW7G/GEvuabzVMO8HYeNV0G2ukPDR9ucppxpj0qH4860Sp8DrRCxXopxjgwI4 wKJmGZPhuePN61RJJs297ZwG3qeFK9V4bDhKjAwinSRn8MprVzWhQffDV3DmAr0cYwUj KtMa7Q5CZ7wCKDPwSkgNYlfXN/DOvVaFzPsmyHgrnp/ZZZoVZFqrTuZbYIx0yEPVS2IY 8rCsxNP0fihD77gcbiwVgBOGVI1I5oecsL9ZN3h2rdSk9MT521LdOK70ROVaA6/qigRm Hi3/cVDm8cgY5b9k/u6O5WsKj+wZCZ/LQdAxoempYnm2Q/zRjcMpv3Db871bgAIwMTzg HIlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=qTCEbd7aPGL7tAMAbp4nJjEaaXReCy/kGWOOAJ2+wnU=; b=euJn+vF0kkdGNfJos+fRFEiPi5FIOWoQ0EADgtCasWgl7Wq0p306+S44emLCZv3ucA 2qf48xdS8PW9fYGD1xvZFghDhW4/gC+Y+M9PXSTLKiQZTE4XomCTppdfS6qXZxxyRJQy E6oHTMfBDH7soizdbQcFT5JOuCmKqUSENHqVo9GF9TlCBYEoPhwzMTvUSYJ84vfN405T Y6mGm0SJ+cNamEOFZ0N9yDKORpnxUEGkQNcnWQcG+GOJ8mCvyXXqF7+lhcuJo20UNJKi mKrP1fsuIzwT7JWZ4CMeAMCVep7f0WOib6kHK5kHLRWcclkDi4IiJaZnvFblojl87qNz GT/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id j11-20020a654d4b000000b003fdd5d8c869si2778566pgt.685.2022.06.06.06.41.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 06:41:02 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4C7D91A408B; Mon, 6 Jun 2022 06:32:05 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238927AbiFFNb7 (ORCPT + 99 others); Mon, 6 Jun 2022 09:31:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238920AbiFFNb5 (ORCPT ); Mon, 6 Jun 2022 09:31:57 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6C3791A0484 for ; Mon, 6 Jun 2022 06:31:56 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 429A71596; Mon, 6 Jun 2022 06:31:56 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9DDAB3F73B; Mon, 6 Jun 2022 06:31:54 -0700 (PDT) Date: Mon, 6 Jun 2022 14:31:48 +0100 From: Cristian Marussi To: Michael Riesch Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Heiko Stuebner , Liang Chen , Kever Yang , Jeffy Chen , Peter Geis , Nicolas Frattaroli , Etienne Carriere , Sudeep Holla Subject: Re: [PATCH] firmware: arm_scmi: Relax BASE protocol sanity checks on protocol list Message-ID: References: <20220523171559.472112-1-cristian.marussi@arm.com> <45bf11a8-47eb-e088-ba99-30c8788c7143@wolfvision.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45bf11a8-47eb-e088-ba99-30c8788c7143@wolfvision.net> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2022 at 02:59:10PM +0200, Michael Riesch wrote: > Hi Cristian, > Hi Michael, > On 5/23/22 19:15, Cristian Marussi wrote: > > Even though malformed replies from firmware must be treated carefully to > > avoid memory corruption Kernel side, some out-of-spec SCMI replies can > > be tolerated to avoid breaking existing deployed system, as long as they > > won't cause memory issues. > > > > Reported-by: Nicolas Frattaroli > > Cc: Etienne Carriere > > Cc: Sudeep Holla > > Signed-off-by: Cristian Marussi > > Thanks a lot, without this fix the Mali G52 GPU won't probe on my RK3568 > EVB1 in vanilla v5.19-rc1. > Yes, the break was reported on -next and today it appeared in 5.19-rc1. A proper FW fix is also up for review by Etienne but in the meantime this tries to limit damages relaxing a bit the checks. > I guess this patch should have a Fixes: tag, right? > It has not a Fixes tag because the issue was introduced in 5.19-rc1 and the fix will go in with the next round of v5.19 fixes by Sudeep (AFAIU) so it will be solved within the v5.19 cycle and I thought the Fixes tag was not needed in this case (I could be wrong...) > Would be great to have this in v5.19. AFAIC: > > Acked-by: Michael Riesch Thanks for testing it. Cristian