Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Feedback-ID: i8771445c:Fastmail
Date:   Mon, 6 Jun 2022 15:42:42 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>
Cc:     javierm@redhat.com, davidgow@google.com, dlatypov@google.com,
        tzimmermann@suse.de, maarten.lankhorst@linux.intel.com,
        airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
        kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for
 drm_fb_xrgb8888_to_rgb332()
Message-ID: <20220606134242.h6kuqn4zbpmc2rql@houat>
References: <20220606095516.938934-1-jose.exposito89@gmail.com>
 <20220606095516.938934-2-jose.exposito89@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="nmupzpdydlfrfe4r"
Content-Disposition: inline
In-Reply-To: <20220606095516.938934-2-jose.exposito89@gmail.com>
Precedence: bulk


--nmupzpdydlfrfe4r
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Jun 06, 2022 at 11:55:16AM +0200, Jos=E9 Exp=F3sito wrote:
> Test the conversion from XRGB8888 to RGB332.
>=20
> What is tested?
>=20
>  - Different values for the X in XRGB8888 to make sure it is ignored
>  - Different clip values: Single pixel and full and partial buffer
>  - Well known colors: White, black, red, green, blue, magenta, yellow
>    and cyan
>  - Other colors: Randomly picked
>  - Destination pitch
>=20
> How to run the tests?
>=20
>  $ ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/gpu/drm \
>          --kconfig_add CONFIG_VIRTIO_UML=3Dy \
>          --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=3Dy

It's not clear to me why you would need VIRTIO here? The Kunit config
file should be enough to run the tests properly

Maxime

--nmupzpdydlfrfe4r
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYp4EUgAKCRDj7w1vZxhR
xdD/AQCVKUFsKCwDjplnL7J+4MZC7u9BvBuBbUwiUaBES9UgqQEA+JV0l+OYLBD+
6FCuKDewDOpOGvmYO3+pxyijE6tjnws=
=aLxf
-----END PGP SIGNATURE-----

--nmupzpdydlfrfe4r--