Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Feedback-ID: i8771445c:Fastmail
Date:   Mon, 6 Jun 2022 15:52:19 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Javier Martinez Canillas <javierm@redhat.com>
Cc:     =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>,
        davidgow@google.com, dlatypov@google.com, tzimmermann@suse.de,
        maarten.lankhorst@linux.intel.com, airlied@linux.ie,
        daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
        kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for
 drm_fb_xrgb8888_to_rgb332()
Message-ID: <20220606135219.nwhp4fdawg2qjeam@houat>
References: <20220606095516.938934-1-jose.exposito89@gmail.com>
 <20220606095516.938934-2-jose.exposito89@gmail.com>
 <20220606134242.h6kuqn4zbpmc2rql@houat>
 <576ed6ef-b961-9214-2c9b-56cb5b493b4e@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="bilcjadqyeu5dusd"
Content-Disposition: inline
In-Reply-To: <576ed6ef-b961-9214-2c9b-56cb5b493b4e@redhat.com>
Precedence: bulk


--bilcjadqyeu5dusd
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

hi,

On Mon, Jun 06, 2022 at 03:49:57PM +0200, Javier Martinez Canillas wrote:
> Hello Maxime,
>=20
> On 6/6/22 15:42, Maxime Ripard wrote:
> > Hi,
> >=20
> > On Mon, Jun 06, 2022 at 11:55:16AM +0200, Jos=E9 Exp=F3sito wrote:
> >> Test the conversion from XRGB8888 to RGB332.
> >>
> >> What is tested?
> >>
> >>  - Different values for the X in XRGB8888 to make sure it is ignored
> >>  - Different clip values: Single pixel and full and partial buffer
> >>  - Well known colors: White, black, red, green, blue, magenta, yellow
> >>    and cyan
> >>  - Other colors: Randomly picked
> >>  - Destination pitch
> >>
> >> How to run the tests?
> >>
> >>  $ ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/gpu/drm \
> >>          --kconfig_add CONFIG_VIRTIO_UML=3Dy \
> >>          --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=3Dy
> >=20
> > It's not clear to me why you would need VIRTIO here? The Kunit config
> > file should be enough to run the tests properly
> >
>=20
> It's needed or otherwise KUnit will complain with:
>=20
> ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/gpu/drm/.kunit=
config
> [15:47:31] Configuring KUnit Kernel ...
> Regenerating .config ...
> Populating config with:
> $ make ARCH=3Dum O=3D.kunit olddefconfig
> ERROR:root:Not all Kconfig options selected in kunitconfig were in the ge=
nerated .config.
> This is probably due to unsatisfied dependencies.
> Missing: CONFIG_DRM=3Dy, CONFIG_DRM_KUNIT_TEST=3Dy
> Note: many Kconfig options aren't available on UML. You can try running o=
n a different architecture with something like "--arch=3Dx86_64".
>=20
> The following works correctly but it won't use User Mode Linux:
>=20
> ./tools/testing/kunit/kunit.py run --kunitconfig=3Ddrivers/gpu/drm/.kunit=
config --arch=3Dx86_64

But then, can't we add them to .kunitconfig?

We should avoid that gotcha entirely

Maxime

--bilcjadqyeu5dusd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYp4GkwAKCRDj7w1vZxhR
xT6PAQDhwfp2fjJmUMUJPnpt4aT/XrvencrUwbHEHr3BC5MJmAEArrmm08IruivD
HYAgDNsHi3OXg1TE3K/2v9c95skILAw=
=d37x
-----END PGP SIGNATURE-----

--bilcjadqyeu5dusd--