Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp621614iof; Mon, 6 Jun 2022 09:31:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfsqvScjOB5yvJdWxbiigAqG0rB4spLHkLCq3SW3g4hqkyNe6eKDc2zVWf3isO2zut5hlW X-Received: by 2002:a63:5b5d:0:b0:3fc:97d5:f8b2 with SMTP id l29-20020a635b5d000000b003fc97d5f8b2mr22124326pgm.322.1654533092910; Mon, 06 Jun 2022 09:31:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654533092; cv=none; d=google.com; s=arc-20160816; b=YQTfV/x67F0WI86cojFAb3mmHKbNLDSsghsUb/PuqzIuCwKia+Y2JIMzCD+xGijIJ2 9LtVx5Iltq9g9ZFawq+v+jT/kB9AGKC5jCJsTcT8e9VhwCnGu88zKpLzl/KFreVKFwXX ZptqfdajrGeDjjDRNlqiuWGAVGylbuL3N17ZbhYYNjXSd29wYh63yYx1wWTaTzuDZK9i gf0l2RZ6NvahhP9r+aFaU6osFbI8zVNcCXo6mGu4SPtFvi8k0h3HS2K/nR2dsu8/BlOM 5W0BycAj/a8HN8HaA2qCcyzxtVXkfrceCo+AK/cX8UNTT+YlExryv5jSV/2HOnHiZq+I nzBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=TaRotW9W17/Yi/5OQGOuvLemt233VPR4Op+a3XNt43M=; b=RzzLDTxOrs0DaWeqSqOGJRSdYPWWaB8vjNfl8VEz6c6erXtneOp6z+XbSH6zyurjkP 9vTmsfZvvQkd8FTTJObRGfiCTvQTLg3MV1e7Bm4eFrBvT13crOtoqGy1LmtTpG4M/iB2 f9bHYzjvtcUZmq9ADiGdgDO3M38GxDLDIbA1dLtCBcUcyt5EbfBf+49Q2T53zgc9+ECS DT2xoeBfO01v67befSKyUFo25Q9AkJNhto+QhePvTzm44WGDFefz2wugSXxxZb2lU7pG h270MEtPqAE76OXC6dnJc3byKONNAWUPihhpNN774Ge3/b81M867mWxFiGDE79e6JCuP 90sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QAI1RHiS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id m10-20020a170902768a00b00161946a7108si18843277pll.161.2022.06.06.09.31.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 09:31:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QAI1RHiS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7C8E6158F1B; Mon, 6 Jun 2022 09:14:10 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241639AbiFFQNr (ORCPT + 99 others); Mon, 6 Jun 2022 12:13:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241624AbiFFQNj (ORCPT ); Mon, 6 Jun 2022 12:13:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31A941248EF; Mon, 6 Jun 2022 09:13:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BBF4B60C97; Mon, 6 Jun 2022 16:13:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F920C34115; Mon, 6 Jun 2022 16:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654532017; bh=MueADA+CiyJmz39HZzbLm60F2gZNMbcgAKZql4mZf7c=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=QAI1RHiScg3qpm4z3/qK7ESW37gHCGbfX3wSJ/EQqdzK5dSmxbKNk4JCNAFEjb3Ba WoUMsGX5I01tKA+gsmVz9Rb/qkNRW2Lc+WEhoDjV7w066igtO3S7qlEi4Qddiujiol mq44PevNwvgnkRDrYyS6SmLtAO+RpalCp+gkZuow10XHakf8OHu1ms82BEPpQHJVOH CDHIaECYmDjRbfT9ZUwotD/0y+EOUwhl2C8cHAgCR3u6jaRISGeNctuUaYqF7kiIL6 RYdT7gFRQbqf5NhaK8KkzWyBgtdPkrRv0y7KH6MN0uzUiWkbF54ILN6jF6rp8jeSp2 PLKFacvXp1v8A== From: Mark Brown To: amit.kumar-mahapatra@xilinx.com Cc: linux-spi@vger.kernel.org, git@xilinx.com, lakshmi.sai.krishna.potthuri@xilinx.com, linux-kernel@vger.kernel.org In-Reply-To: <20220606062525.18447-1-amit.kumar-mahapatra@xilinx.com> References: <20220606062525.18447-1-amit.kumar-mahapatra@xilinx.com> Subject: Re: [PATCH] spi: spi-cadence: Fix SPI CS gets toggling sporadically Message-Id: <165453201583.2010189.2681411517456165829.b4-ty@kernel.org> Date: Mon, 06 Jun 2022 17:13:35 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Jun 2022 11:55:25 +0530, Amit Kumar Mahapatra wrote: > From: Sai Krishna Potthuri > > As part of unprepare_transfer_hardware, SPI controller will be disabled > which will indirectly deassert the CS line. This will create a problem > in some of the devices where message will be transferred with > cs_change flag set(CS should not be deasserted). > As per SPI controller implementation, if SPI controller is disabled then > all output enables are inactive and all pins are set to input mode which > means CS will go to default state high(deassert). This leads to an issue > when core explicitly ask not to deassert the CS (cs_change = 1). This > patch fix the above issue by checking the Slave select status bits from > configuration register before disabling the SPI. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: spi-cadence: Fix SPI CS gets toggling sporadically commit: 21b511ddee09a78909035ec47a6a594349fe3296 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark