Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 6 Jun 2022 17:18:33 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Lukasz Majewski <lukma@denx.de>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org,
        patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
        Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH 2/3] ASoC: wm8940: Rewrite code to set proper clocks
Message-ID: <Yp4o2bQammYjv7Kt@sirena.org.uk>
References: <20220606154441.20848-1-lukma@denx.de>
 <20220606154441.20848-2-lukma@denx.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="3nyy0JRAQdDxWcrH"
Content-Disposition: inline
In-Reply-To: <20220606154441.20848-2-lukma@denx.de>
Precedence: bulk


--3nyy0JRAQdDxWcrH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jun 06, 2022 at 05:44:40PM +0200, Lukasz Majewski wrote:
> Without this change, the wm8940 driver is not working when
> set_sysclk callback (wm8940_set_dai_sysclk) is called with
> freqency not listed in the switch clause.

> This change adjusts this driver to allow non-standard frequency
> set (just after the boot) being adjusted afterwards by the sound
> system core code.

I don't entirely follow the above - in what way might the core adjust
the clocking, and why would we want to allow the use of invalid clocks?
Surely that just makes error checking worse.

> Code in this commit is based on previous change done for wm8974
> (SHA1: 51b2bb3f2568e6d9d81a001d38b8d70c2ba4af99).

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

--3nyy0JRAQdDxWcrH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKeKNkACgkQJNaLcl1U
h9CBzwf7Bsk4iYWK7ta6JUCjk6j2ZHCbZQHOMiN6efdBy834xrJCPOHTbaCz3KvO
Kye4CEAZP8dHX8/L8dHyOFnPlzcDTL2lbSoMJNOA9rP4IUjCGdCBIyPLQ/kzEi4t
Zcvy/aAB3tiR6rtlHP/3f/B+gqW+2b5vqJ2bjYMLL0QaK4xo8T4OZbUTtxPn+yOc
Wrm2qJGy1X2PFU+Rtoh/rE5wPyCzvhjW5GzJJ8i111MnFvLsVlfbB0ckZ1+zrYFY
JiP+ELOKT7USyUFugr3W12oV0RSGMQYa+uDqXSeMwZpos7U1WqbxSuEo3uRldgsB
gdAfowSaXfq1ayZwfjNAl4WtQWAakQ==
=RBse
-----END PGP SIGNATURE-----

--3nyy0JRAQdDxWcrH--