Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 6 Jun 2022 17:25:19 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Lukasz Majewski <lukma@denx.de>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org,
        patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
        Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH 3/3] ASoC: wm8940: Mute also the speaker output
Message-ID: <Yp4qb5jaGYf5qnxt@sirena.org.uk>
References: <20220606154441.20848-1-lukma@denx.de>
 <20220606154441.20848-3-lukma@denx.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="vbR2GMX70upG8Py9"
Content-Disposition: inline
In-Reply-To: <20220606154441.20848-3-lukma@denx.de>
Precedence: bulk


--vbR2GMX70upG8Py9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jun 06, 2022 at 05:44:41PM +0200, Lukasz Majewski wrote:

> Without this change the BTL speaker produces some
> "distortion" noise when test program
> (speaker-test -t waw) is ended with ctrl+c.

> As our design uses speaker outputs to drive BTL speaker,
> it was necessary to also mute the speaker via the codec
> internal WM8940_SPKVOL register with setting
> WM8940_SPKMUTE bit.

This will not interact well with both the user visible control of the
speaker volume via the Speaker Playback Volume control and the analog
bypass paths that the device has - it'll change the state of the control
without generating any events, and cut off any bypassed audio that's
mixed in.

You can probably achieve a similar effect by making the control an
_AUTODISABLE one which will allow the core to mute the control when it's
not being used in a way that's not visible to userspace.

--vbR2GMX70upG8Py9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKeKm4ACgkQJNaLcl1U
h9CkDwgAhJX7tOT+yGFzvFc73mwr1jkFi+2f+NgQ5Vz+AFyNn8C7GgMClt6+gXhI
GuqETDHalU67stNb4ke1NTVdlKM1qI5rdGl20VfY/mFCb+itbR/fE/vxwMHIQSCy
JY4dpCv2Z3yDKLSjSarJiTWV6dxaJ01tJYp3z3+i2Za9Di4v6K3j2wRayIZcczSt
sxPdAt/4AL265LDctA6PmI2VCE2wjo3l4YgfInO1bGDpH5gjnZFMdJo3cKHD/Vrs
JLRuB6A1guLo1oURYQOKLrvpMPRkKoF/XaoNlCA/Tlsd/p0l3Up8sk6zBY8Gr+f0
uNDYRwQnGcy/KqQT+B6Ytqa2i7pMqw==
=2p+e
-----END PGP SIGNATURE-----

--vbR2GMX70upG8Py9--