Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp660666iof; Mon, 6 Jun 2022 10:11:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwcmjOjC4ZC2/BWkED0LLk7R8/v0PtPfMc6PwhRC3P1YBUEvV/awk0f7EPCgkkwXyF9hYZs X-Received: by 2002:a63:894a:0:b0:3fc:a724:578c with SMTP id v71-20020a63894a000000b003fca724578cmr22102898pgd.499.1654535501247; Mon, 06 Jun 2022 10:11:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654535501; cv=none; d=google.com; s=arc-20160816; b=FOtmheu01fsVWFjT4frm7pxsnRTnN/T5CJyQqKd8VuhDikBJhIQ8tyw+cfDPqHBMHH acd53vKN6ijcRiUVn7gxpN2zN9ris8Eh1cXGz2QYGP816BfSer3iYS96+l3X45sXn1Yp 0XzBFJuzNxcv0/TsW73v59eDkaKx4loG6lgmpJjMeJpTOB3rfuQvWt4S9Ld3EkEyb+Ib PSQTGPHMmsyibwE+dRsfyZYaOTVc+jQItN/EvSG7+3ckISgDU21prZ2l1buJnfB3GfCR gYbZ8B7ajdeT9IWKdUcVTas5DYnomQOIlNYSupu/qUWo7vi2tF/FNroHP8JS9BqwEwE1 Wt5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/5dOkIUPK4LW5OYTDk812LAqaFzKUe0vwtcKi0hbnlM=; b=KnZ3lS5px1Kh6vwiyxOF59DeOVEID8ggxQTE0+4+xYbK3BsG9wkx7tVMFrTM4swB9M HT4IEkyXepIBBTXhSg86iGfcZcK22PKZupumrGu5WKzSfNZbbtSJlPrK1aAn4J6WfEaU BxRX9qNkCy9CDObbT/CSvZEJM3+y/7PvbrzLUO4znWnp3ZQiDVNID4lyWLw4xXlw5X0p Expc33l4XJOX6+pYT50cg2SZIlJtsOoQYpMO3Y5o6CZYRJ5mroPne1B+Ctf/8A3TA39p QrzkqMdh9QOLvY8jgqLJnn7IwOus41j/uCEWSl3oPTG5Y2ulfxX8cgSD+HpAm1mCbdXu 8vsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=GfFJBUVi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b9-20020a170902d88900b0016390a937aesi19521725plz.524.2022.06.06.10.11.28; Mon, 06 Jun 2022 10:11:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=GfFJBUVi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229715AbiFFRKn (ORCPT + 99 others); Mon, 6 Jun 2022 13:10:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbiFFRIv (ORCPT ); Mon, 6 Jun 2022 13:08:51 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B494D3561E6 for ; Mon, 6 Jun 2022 09:56:55 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id 129so13393217pgc.2 for ; Mon, 06 Jun 2022 09:56:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/5dOkIUPK4LW5OYTDk812LAqaFzKUe0vwtcKi0hbnlM=; b=GfFJBUVisv0PqVkrWuDqO6GnJbD1uVivcukZ2+zrLhAY0TYOAzF6hiVnTS/CwdWapc vHuX33w6RmbXVpASnBf2DFOa7iXRJUxB/RnVvyVZ6CVZfGYZrcBW0esQofH9Pfe2Qldq tRTqaMscD14X5BSW1w/68cLagRaTKeX/s1p8FMrm6Bgpkebje8Y+zV72+0lHB1Q7r13P dMy0wgR9NRSuFyCmXn7Be3ir3d/b2+rJN5r9K8qdPVkW3JgpEGyy/uq1wLbjfKfSqVBv +w1zAPlN1+BKXWgm7S0oYoz0uEj27PZq+4e4HWQ6B5TMSQOSg9Bym9Q/DhQQ0M6AqUSC JChg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/5dOkIUPK4LW5OYTDk812LAqaFzKUe0vwtcKi0hbnlM=; b=YYdbJpNwMF4mYm9k+oL2oBsCaPqpHRZDWVeIMIus3lMWLIkMbH0hLt0sJxvlNCjBdR /j87wpFpES+dAhWtHRv3waxZz7+Qur+W4sP1D8wUPbjHauEPlaG5UziMkblwKg8KuYvA xFJqk/YZT+calFo/glJ2mWhdE2cWimMwMtN5ZHUM27PUOCUcdt9IyHizg6+dL2mnjdjr 91bnl6kIhOhivLeN1jvje+kqi1cijmbc0xw9miNzRQuCGla7t4syZJ9SxtWcAi1qQB22 CLWTx5hi43GKvc8pWEZvfTUZUGdQ0IJtj/0HP6/dH27PLIwApc8TB1xUaAPgSnkKCh0u Ywjw== X-Gm-Message-State: AOAM533BehFX7QUZxWORKb/vEfcYbu1QantO1gJa9xF2XJL2CKIGPoz3 kQ2K1TFt9VzlvCsWgKEB8uzKcA== X-Received: by 2002:a05:6a00:2293:b0:51c:155a:1868 with SMTP id f19-20020a056a00229300b0051c155a1868mr7220103pfe.79.1654534614798; Mon, 06 Jun 2022 09:56:54 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id u5-20020a170903108500b00161f9e72233sm10592208pld.261.2022.06.06.09.56.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 09:56:54 -0700 (PDT) Date: Mon, 6 Jun 2022 16:56:50 +0000 From: Sean Christopherson To: shaoqin.huang@intel.com Cc: pbonzini@redhat.com, Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ben Gardon , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] KVM: x86/mmu: Check every prev_roots in __kvm_mmu_free_obsolete_roots() Message-ID: References: <20220607005905.2933378-1-shaoqin.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607005905.2933378-1-shaoqin.huang@intel.com> X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2022, shaoqin.huang@intel.com wrote: > From: Shaoqin Huang > > When freeing obsolete previous roots, check prev_roots as intended, not > the current root. > > Signed-off-by: Shaoqin Huang > Fixes: 527d5cd7eece ("KVM: x86/mmu: Zap only obsolete roots if a root shadow page is zapped") Because KVM patches aren't guaranteed to be backported without it (though it's "only" v5.18 that's affected), this needs: Cc: stable@vger.kernel.org Reviewed-by: Sean Christopherson