Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <774c3d04-4c02-ed52-f545-73acbffde561@gmail.com>
Date:   Mon, 6 Jun 2022 22:00:58 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v2 2/4] staging: r8188eu: add error handling of rtw_read16
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        straube.linux@gmail.com, dan.carpenter@oracle.com,
        fmdefrancesco@gmail.com, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev
References: <cover.1652994483.git.paskripkin@gmail.com>
 <fd10125ab8f4a64572742ec01d3202af2a79b1d0.1652994483.git.paskripkin@gmail.com>
 <Yp2VQU9G1xVw9lHE@kroah.com>
From:   Pavel Skripkin <paskripkin@gmail.com>
In-Reply-To: <Yp2VQU9G1xVw9lHE@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Greg,

On 6/6/22 08:48, Greg KH wrote:
>> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
>> index e67ecbd1ba79..6662ebc30f7b 100644
>> --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
>> +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
>> @@ -249,11 +249,14 @@ static void efuse_read_phymap_from_txpktbuf(
>>  		hi32 = cpu_to_le32(rtw_read32(adapter, REG_PKTBUF_DBG_DATA_H));
>>  
>>  		if (i == 0) {
>> +			u16 reg;
>> +
>>  			/* Although lenc is only used in a debug statement,
>>  			 * do not remove it as the rtw_read16() call consumes
>>  			 * 2 bytes from the EEPROM source.
>>  			 */
>> -			rtw_read16(adapter, REG_PKTBUF_DBG_DATA_L);
>> +			res = rtw_read16(adapter, REG_PKTBUF_DBG_DATA_L, &reg);
>> +			(void)res;
> 
> Same here, that line isn't ok.
> 
hm, that place is not obvious.

I guess, on-chip EEPROM acts like a FIFO, so this read must be completed 
w/o any errors, so I will simply propagate an error to callers

And will place another "FIXME" for further work :)

thanks,


With regards,
Pavel Skripkin