Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp871716iof; Mon, 6 Jun 2022 14:21:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjNYWIEM3GoAC+AiagRm2TKJHY3hSxWyjpDWKwT3irZ6MX2HmtrcrIKE2vN5sSec48tZFA X-Received: by 2002:a17:903:120a:b0:15f:99f:95bc with SMTP id l10-20020a170903120a00b0015f099f95bcmr25862377plh.48.1654550488333; Mon, 06 Jun 2022 14:21:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654550488; cv=none; d=google.com; s=arc-20160816; b=N7E5+6NNclMNgQ5KrYkjdi8k/TIqnpZ9u4tALnr0+B6nmz3f6bGt4hX6uzKwhEpAod KXefPh+07NtvJ3WL9y8V7zKIL85MexkfhCnwnZZQ42uiOAsL5nXlk59IIYZKXgbYcPLY 99Qy2LlrnZP4EYTvHEhdoKSVL6LTsGo//3qOM+dBemIkRasWbq2X2W6F6gMXtzeIl3du XeKommzgnsxGG0NcvlKTZ5u8hqLJJEL2DjlJeShC9FYZLNzhCegRIilSxComUqncGeGY r8DXl/9rshUHhQLWvvs+1BQLEA5lU/w2r2diiLCNJQbgbn03ELrKz/kTcAwL9oJKcvcv Cseg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:subject:message-id:date:user-agent:from :references:in-reply-to:mime-version:dkim-signature; bh=G0s9EvK9A5j5jro8iyUi5/Ke5ICziVLB9PSRs9EAj4g=; b=FBqfrB4j2X/obZ+g5sP35WRiRGAZ8lx549CnpqfZopxHGv3Lkqc0qCFTEIvjt1UA/T Dx2pEWworyzQfYqy3Bc4lK0mBkq2n6pcSLU759HciT/8mYP3r1kGq1rNIKTWJlbZ2rqX 2j/OSNewTSX4RuqqyC0Sj4jUgnoAaKcqtgLbvkt3wyxKfNzCv/2pXoQDwtxSiAZI/BgH kf2uyMQv919JmKR7VE5LHpL8WRTfAl0Fejvg5oZOORiabdcFpD0d6nFrcqyWs/8NWOqY DZ4GqWQrqjwuHpfdKFz9vJrWG34uDU+8NvWBg5kFf5aYpoXbY1a2CjgjjZiWPPbROrJ9 HFCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hUP3AyLW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h21-20020a056a001a5500b0051c187b97d5si6073259pfv.11.2022.06.06.14.21.15; Mon, 06 Jun 2022 14:21:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hUP3AyLW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232636AbiFFTou (ORCPT + 99 others); Mon, 6 Jun 2022 15:44:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232627AbiFFTor (ORCPT ); Mon, 6 Jun 2022 15:44:47 -0400 Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97E582BEA for ; Mon, 6 Jun 2022 12:44:45 -0700 (PDT) Received: by mail-oi1-x231.google.com with SMTP id q11so5737143oih.10 for ; Mon, 06 Jun 2022 12:44:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to; bh=G0s9EvK9A5j5jro8iyUi5/Ke5ICziVLB9PSRs9EAj4g=; b=hUP3AyLWcII1jU/38fRFnfKqyqfmKEc9qI+hlI7ikDhyY2bjlVB5vCV7BySY2ktEuL u7EfkpZRlCep9Z/DF440GwsfgW+xQeRzDH3U14cpDxTIgDN/jeJfEhaLdv+uSvSwWJ4N DykcvePs5dV24iZmueaG4njvIBUSWiOmK0vy0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to; bh=G0s9EvK9A5j5jro8iyUi5/Ke5ICziVLB9PSRs9EAj4g=; b=drsRZRYGY31lWSEUuLdXK0sRwGRQnSq0pwJdG/1yGEFus4JFS3tScstz2sir7IdECE vDCX9G7PKAlX6CVD5uo9VmTa05gj9I+RwsjRqhBQBHRRZKxDT7t+V2kKuuOXutMHuBB0 THKQL/c2doVAGgruSU/9nDfUEuR1FgXMLVesoln+QrWQdtx//CyN9nTKX/iRi23OsFnQ WAptfs4kRMwumD+It4lr8xEulLICjw5HVaS/FE/5AttXCPsp6XmvRR+HSgd8INQO4Ozv SH+WYqzqVzTjpSvYnYcTPm4maZi0GtISZJGMWAkcdtx35NMV/oLtEV5HOqhTP/nkKoAz QiMA== X-Gm-Message-State: AOAM533y1h/pB10T45Z1/3oGd6JovRjE8MHFfLVSAyC5nD3g5yAAYbdc JhcYmJU87hChEZxZ9rQIjsr4LZK2TxsH/H7DogQLPQ== X-Received: by 2002:a05:6808:1703:b0:32e:851e:7f81 with SMTP id bc3-20020a056808170300b0032e851e7f81mr5204846oib.63.1654544684903; Mon, 06 Jun 2022 12:44:44 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 6 Jun 2022 12:44:44 -0700 MIME-Version: 1.0 In-Reply-To: <20220601075211.2117596-1-wanjiabing@vivo.com> References: <20220601075211.2117596-1-wanjiabing@vivo.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Mon, 6 Jun 2022 12:44:44 -0700 Message-ID: Subject: Re: [PATCH] leds: Add of_node_put() before return To: Bjorn Andersson , Marijn Suijten , Pavel Machek , Satya Priya , Wan Jiabing , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Wan Jiabing (2022-06-01 00:52:03) > Fix following coccicheck warning: > drivers/leds/rgb/leds-qcom-lpg.c:1107:2-34: WARNING: Function for_each_available_child_of_node should have of_node_put() before return around line 1110. > drivers/leds/rgb/leds-qcom-lpg.c:1286:1-33: WARNING: Function for_each_available_child_of_node should have of_node_put() before return around line 1289. > > Early exits from for_each_available_child_of_node should decrement the > node reference counter. > > Fixes: 24e2d05d1b68 ("leds: Add driver for Qualcomm LPG") > Signed-off-by: Wan Jiabing > --- Reviewed-by: Stephen Boyd