Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp1184723iof; Mon, 6 Jun 2022 23:39:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaBut6yB/NvlFc11b4sQQGhms1go08zs//Fpgnq3B+f95z5+JHzGsOZyPkhu3RpAcvEQhS X-Received: by 2002:a05:6402:4145:b0:42d:842a:f916 with SMTP id x5-20020a056402414500b0042d842af916mr31102968eda.357.1654583971291; Mon, 06 Jun 2022 23:39:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654583971; cv=none; d=google.com; s=arc-20160816; b=KF4Opdf00Nm5CjoQ0Cpiv8zHw9zDqR08V3+bBRsL9Azly5VHAiEjsTKuCAcy+ODrXp LHxBSfRkUTreuBPC0TRFUFG+1SYO1hMA4Cdt0f/2QFYlF08R1IFMnwAloPh8FpumvfPI ZMGYDzImAsS1D398YxpihSk3pAN0zKWIv4Rn6r+BL3sbAGS8lq32nyakbsLuG+8MnhuX NimwAIP5ktu57zbiCJgCgurI7ydFN7RY5ASz4QeV9ZOxSKv//jyFFiVT3W8MiG1eXUii OIyYI022VuiXDxBcuK1hsX+/5NFY8j12Ko/PbYzIE2FzIRBrAVzzq595YJyQHzoQ6COL QO3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MBFPcYzjP5YOoUYeqxAddyhSSk+bw/1q7yO09hPREDU=; b=ldOztesS0dVo145RLUd9riACCyOPnRwoWdLfurOXMb8q2FZV8v46LKsL1cL+UvC/6N 5ZLKk/e8sd6CiyDDXvsZVvA1IbYERLz7aUCM6nIWb18clINUpgRFdXr9KEnQPH3NrAbE JxIiUXR+n1M1jaXMq3k2tbVDk3n/HS81pkJAWNum6EfftMQKHJnTJHjVgaqaiiU5VyrN xogmS31heJSWWVdvrZ8NjO8GWn/XzsqBELyVyAC4gpqRQdBuCnlLOv6S6VNHMkd5jRdm nYUEW8JleNLj1wz95TrW8M4BCJW1Urn+fMFr6e1IAWscy8Ot5g4Ww6Wm6U9OVNbNnZz4 28Jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JdPGdlgz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hs41-20020a1709073ea900b006eff1450aebsi14814748ejc.691.2022.06.06.23.39.04; Mon, 06 Jun 2022 23:39:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JdPGdlgz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235495AbiFGAzF (ORCPT + 99 others); Mon, 6 Jun 2022 20:55:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235498AbiFGAzE (ORCPT ); Mon, 6 Jun 2022 20:55:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A69E8BF11F for ; Mon, 6 Jun 2022 17:55:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0FCE360CA0 for ; Tue, 7 Jun 2022 00:55:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 957C7C385A9; Tue, 7 Jun 2022 00:55:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654563302; bh=jtKsJm2olsnz+fSzwZA/FF+z6PxvCo6g3U8AJ3kGynE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JdPGdlgzYiEn6KC2AY89fd68QPepy/PmCePcArDAR197Fu4nhi5to+B+AotpYGp6/ 1sxB9O5X63W/A9frKCX80S6mag2QAVc1LidUtdVjy75JM4KpA2TzECJIlL308L+yII pl7Etz5KCN6TEQSkXaaL/9pVVOGhhJIS8Jywlynn6aNRQDtijVa0nSiaWzTT62g6Ov +gORgEC6JLBO6qLTdYIghUPZfopikSeZ0XCrpukJPOeWCsG1piMmRiLVU9yURawggp OLAHNyOduoS8uYiMQnn3KprJ8dAdlZpQH7bJ3w48nQK5oY8/kg+1b8cfE+POF100cJ 7Iam57ewpGuuw== Date: Tue, 7 Jun 2022 00:54:59 +0000 From: Tzung-Bi Shih To: Guenter Roeck Cc: Benson Leung , Guenter Roeck , chrome-platform@lists.linux.dev, linux-kernel Subject: Re: [PATCH 07/13] platform/chrome: cros_ec_proto: separate fill_protocol_info() Message-ID: References: <20220606141051.285823-1-tzungbi@kernel.org> <20220606141051.285823-8-tzungbi@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2022 at 09:06:03AM -0700, Guenter Roeck wrote: > On Mon, Jun 6, 2022 at 7:12 AM Tzung-Bi Shih wrote: > > -static int cros_ec_host_command_proto_query(struct cros_ec_device *ec_dev, > > - int devidx, > > - struct cros_ec_command *msg) > > +static int fill_protocol_info(struct cros_ec_device *ec_dev, int devidx) > > I would suggest to keep the cros_ec_ prefix. Also, "fill" sounds a bit > too much as if the function would fill some structure fields. "get" > (ie cros_ec_get_proto_info or similar) might be a better name, Ack, will fix in next version.