Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4d4549ef-f8f8-d0cb-6d27-e6200aa14048@kernel.org>
Date:   Tue, 7 Jun 2022 07:42:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH 2/2] tty/vt: Makefile, add --unicode for loadkeys
 invocation
Content-Language: en-US
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20220602083128.22540-1-jslaby@suse.cz>
 <20220602083128.22540-2-jslaby@suse.cz>
 <CAHp75VfsR6sVwO9iF6RA0bhVjMF1jC1_JEkv106TubPgL_m8YA@mail.gmail.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <CAHp75VfsR6sVwO9iF6RA0bhVjMF1jC1_JEkv106TubPgL_m8YA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 06. 06. 22, 16:35, Andy Shevchenko wrote:
> On Thu, Jun 2, 2022 at 12:30 PM Jiri Slaby <jslaby@suse.cz> wrote:
>>
>> For a long time, we generate unicode tables using loadkeys. So fix
>> Makefile to use that flag too.
> 
> generated

We still do, but I didn't even know there is even a rule for that ;).

> Does it make sense to add the Fixes tag?

I don't think so -- I don't think anyone ran the rule in the past decade 
:P. I.e. it'd be pre-git anyway.

> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> 
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>> ---
>>   drivers/tty/vt/Makefile | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/vt/Makefile b/drivers/tty/vt/Makefile
>> index fe30ce512819..b3dfe9d5717e 100644
>> --- a/drivers/tty/vt/Makefile
>> +++ b/drivers/tty/vt/Makefile
>> @@ -30,6 +30,6 @@ $(obj)/defkeymap.o:  $(obj)/defkeymap.c
>>   ifdef GENERATE_KEYMAP
>>
>>   $(obj)/defkeymap.c: $(obj)/%.c: $(src)/%.map
>> -       loadkeys --mktable $< > $@
>> +       loadkeys --mktable --unicode $< > $@
>>
>>   endif
>> --
>> 2.36.1
>>
> 
> 

thanks,
-- 
js
suse labs