Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764129AbXESTFX (ORCPT ); Sat, 19 May 2007 15:05:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757414AbXESTFN (ORCPT ); Sat, 19 May 2007 15:05:13 -0400 Received: from nz-out-0506.google.com ([64.233.162.232]:62563 "EHLO nz-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757184AbXESTFL (ORCPT ); Sat, 19 May 2007 15:05:11 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:x-enigmail-version:content-type; b=gj4Udk6eJIm7rm8LfPzdb8kHG+SugTcd9xL3pe2BnJA7ALntkb7X9PKaLPCGtpFbqL2YrnVa0bJkt6LUHca8hmiRbQkSFCHBMcdi6JBsg2WFwhA5xYRZE1JCweqhKd5pUaNWX5yFnZw/2ETBtMfMRwH0QrWLKlXkJIpLadvVYho= Message-ID: <464F4A58.2050607@gmail.com> Date: Sat, 19 May 2007 21:04:56 +0200 From: Tejun Heo User-Agent: Thunderbird 2.0.0.0 (X11/20070326) MIME-Version: 1.0 To: Indan Zupancic , Paul Mundt CC: jeff@garzik.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, garyhade@us.ibm.com Subject: Re: [PATCH] libata: implement ata_wait_after_reset() References: <20070510072005.GA27316@linux-sh.org> <464301D3.5060306@gmail.com> <464307CC.40701@gmail.com> <20070510124645.GA18534@linux-sh.org> <4643196B.7070806@gmail.com> <20070511005217.GA23186@li <464B3505.20004@gmail.com> <2229.81.207.0.53.1179592754.squirrel@secure.samage.net> <464F4548.6020101@gmail.com> In-Reply-To: <464F4548.6020101@gmail.com> X-Enigmail-Version: 0.95.0 Content-Type: multipart/mixed; boundary="------------030605080502040608030402" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1713 Lines: 44 This is a multi-part message in MIME format. --------------030605080502040608030402 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Tejun Heo wrote: > Yeah, if SCR registers are accessible, 0xff doesn't indicate the device > isn't there, so the whole skip-0xff logic probably shouldn't apply in > such cases, but we can also achieve pretty good result by just making > the first reset tries a bit more aggressive. So, here's the patch. Paul, can you please test this patch without the previous patch? Indan, this should reduce the resume delay. Please test. But you'll still feel some added delay compared to 2.6.20 due to the mentioned suspend/resume change. Thanks. -- tejun --------------030605080502040608030402 Content-Type: text/plain; name="patch" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="patch" ZGlmZiAtLWdpdCBhL2RyaXZlcnMvYXRhL2xpYmF0YS1jb3JlLmMgYi9kcml2ZXJzL2F0YS9s aWJhdGEtY29yZS5jCmluZGV4IGQ1OTM5ZTYuLjI3ZGRjMzkgMTAwNjQ0Ci0tLSBhL2RyaXZl cnMvYXRhL2xpYmF0YS1jb3JlLmMKKysrIGIvZHJpdmVycy9hdGEvbGliYXRhLWNvcmUuYwpA QCAtMzAzMSw3ICszMDMxLDcgQEAgaW50IGF0YV93YWl0X3JlYWR5KHN0cnVjdCBhdGFfcG9y dCAqYXAsCiAKIAkJaWYgKCEoc3RhdHVzICYgQVRBX0JVU1kpKQogCQkJcmV0dXJuIDA7Ci0J CWlmIChzdGF0dXMgPT0gMHhmZikKKwkJaWYgKCFhdGFfcG9ydF9vbmxpbmUoYXApICYmIHN0 YXR1cyA9PSAweGZmKQogCQkJcmV0dXJuIC1FTk9ERVY7CiAJCWlmICh0aW1lX2FmdGVyKG5v dywgZGVhZGxpbmUpKQogCQkJcmV0dXJuIC1FQlVTWTsK --------------030605080502040608030402-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/