Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Tue, 07 Jun 2022 08:35:56 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From:   "Yajun Deng" <yajun.deng@linux.dev>
Message-ID: <9150a4ffa0ff94ab4697d615c60ed9b4@linux.dev>
Subject: Re: [PATCH] sched/deadline: Use proc_douintvec_minmax() limit
 minimum value
To:     "Daniel Bristot de Oliveira" <bristot@redhat.com>
Cc:     linux-kernel@vger.kernel.org, mingo@redhat.com,
        peterz@infradead.org, juri.lelli@redhat.com,
        dietmar.eggemann@arm.com, bsegall@google.com, vschneid@redhat.com,
        rostedt@goodmis.org, mgorman@suse.de, vincent.guittot@linaro.org
In-Reply-To: <46b7ca44-a338-e1c1-e005-326e89576211@redhat.com>
References: <46b7ca44-a338-e1c1-e005-326e89576211@redhat.com>
 <20220513024109.648471-1-yajun.deng@linux.dev>
Precedence: bulk

June 7, 2022 3:55 PM, "Daniel Bristot de Oliveira" <bristot@redhat.com> w=
rote:=0A=0A> Hi Yajun=0A> =0A> On 5/13/22 04:41, Yajun Deng wrote:=0A> =
=0A>> proc_dointvec() is not applicable for unsigned integer, use=0A>> pr=
oc_douintvec_minmax() limit minimum value.=0A> =0A> I understand your pat=
ch, but your log message is somehow incomplete.=0A> =0A> Could you expand=
 on that, showing the problem using an example, and then how you=0A> see =
it fixed?=0A> =0A=0AThis patch isn't a fix. It's just an optimization for=
 match data and proc_handler in struct ctl_table.=0A=0A> Also, could you =
please add the Fixes: tag so this patch can land on stable trees?=0A> =0A=
=0AThis statement 'if (period < min || period > max)' in __checkparam_dl(=
) will work fine even if there hasn't this patch.=0ASo this patch may not=
 need land on stable trees.=0A=0A> -- Daniel