Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 7 Jun 2022 12:15:30 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc:     linux-kernel@vger.kernel.org,
        Amarula patchwork <linux-amarula@amarulasolutions.com>,
        michael@amarulasolutions.com,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH 03/13] can: slcan: use the alloc_can_skb() helper
Message-ID: <20220607101530.54gezhyq6goxwckz@pengutronix.de>
References: <20220607094752.1029295-1-dario.binacchi@amarulasolutions.com>
 <20220607094752.1029295-4-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="r3lgh2urouzfbnrf"
Content-Disposition: inline
In-Reply-To: <20220607094752.1029295-4-dario.binacchi@amarulasolutions.com>
Precedence: bulk


--r3lgh2urouzfbnrf
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 07.06.2022 11:47:42, Dario Binacchi wrote:
> It is used successfully by most (if not all) CAN device drivers. It
> allows to remove replicated code.

While you're at it, you can change the function to put the data into the
allocated skb directly instead of first filling the "cf" on the stack
and then doing a memcpy();

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--r3lgh2urouzfbnrf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKfJUAACgkQrX5LkNig
011FFQf/e7SAr4zvYs50K56wjpR7g5D+cUH7S1ta0y07du1xPlxbJM5aYvJyoSE9
TfkFuoj77+DEbtnJz3BcmqseB2GE76YvkcyLLCdyWyY41wgCCFSzKcU4vCZ7SdlT
Koia7yO4YlqJm1keua9OKVhtGVeP5xOgRmhuzLJkHKhO+Mg10MX0y8pXHIrinuCN
+xIroJWNVd/I3Xwd5O+svnQgW60+8rfqb9/Lvx9zT89dD/fvXnr9Kjtd4nkljYjT
/r//8CzmgWszLomt+7Yb+khwOpIsvEp2c2eyv/pKYuuX6vyzQ6F9fhRE5F4+i42g
kJsP+Z+1S+mws9gb5Wm8Z1ttmvV28w==
=lReK
-----END PGP SIGNATURE-----

--r3lgh2urouzfbnrf--