Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220602132543.596-1-chevron.li@bayhubtech.com>
In-Reply-To: <20220602132543.596-1-chevron.li@bayhubtech.com>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Tue, 7 Jun 2022 12:43:23 +0200
Message-ID: <CAPDyKFo7FnC_F4biVkBmi7LBaRjkK2UADNFgzdzRmVw79Gr6iw@mail.gmail.com>
Subject: Re: [PATCH V1 1/1] mmc:sdhci-pci-o2micro:fix card detect issue
 because card detect debouncing isn't done
To:     Chevron Li <chevron.li@bayhubtech.com>
Cc:     adrian.hunter@intel.com, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org, shaper.liu@bayhubtech.com,
        xiaoguang.yu@bayhubtech.com, shirley.her@bayhubtech.com,
        fred.ai@bayhubtech.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 2 Jun 2022 at 15:26, Chevron Li <chevron.li@bayhubtech.com> wrote:
>
> get_cd result is uncorrect during card detect debouncing
> we need to wait card detect stable before return get_cd result
>
> Signed-off-by: Chevron Li<chevron.li@bayhubtech.com>

Applied for fixes, by adding a fixes+stable tag, thanks!

Kind regards
Uffe


> ---
> change in V1:
> add wait card detect stable logical before return card detect result.
> ---
>  drivers/mmc/host/sdhci-pci-o2micro.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
> index 92c20cb8074a..0d4d343dbb77 100644
> --- a/drivers/mmc/host/sdhci-pci-o2micro.c
> +++ b/drivers/mmc/host/sdhci-pci-o2micro.c
> @@ -152,6 +152,8 @@ static int sdhci_o2_get_cd(struct mmc_host *mmc)
>
>         if (!(sdhci_readw(host, O2_PLL_DLL_WDT_CONTROL1) & O2_PLL_LOCK_STATUS))
>                 sdhci_o2_enable_internal_clock(host);
> +       else
> +               sdhci_o2_wait_card_detect_stable(host);
>
>         return !!(sdhci_readl(host, SDHCI_PRESENT_STATE) & SDHCI_CARD_PRESENT);
>  }
>
> base-commit: d1dc87763f406d4e67caf16dbe438a5647692395
> --
> 2.32.0
>