Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 7 Jun 2022 09:22:08 -0400
From:   Alan Stern <stern@rowland.harvard.edu>
To:     =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= <clement.leger@bootlin.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: host: ohci-at91: add support to enter suspend using
 SMC
Message-ID: <Yp9RAEa1D21lPiqa@rowland.harvard.edu>
References: <20220606141802.165252-1-clement.leger@bootlin.com>
 <Yp5DpPpW5/3SnuJl@rowland.harvard.edu>
 <20220607090759.3fc0b003@fixe.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220607090759.3fc0b003@fixe.home>
Precedence: bulk

On Tue, Jun 07, 2022 at 09:07:59AM +0200, Cl?ment L?ger wrote:
> Le Mon, 6 Jun 2022 14:12:52 -0400,
> Alan Stern <stern@rowland.harvard.edu> a ?crit :
> 
> > On Mon, Jun 06, 2022 at 04:18:02PM +0200, Cl?ment L?ger wrote:
> > > When Linux is running under OP-TEE, the SFR is set as secured and thus
> > > the AT91_OHCIICR_USB_SUSPEND register isn't accessible. Add a SMC to
> > > do the appropriate call to suspend the controller.
> > > The SMC id is fetched from the device-tree property
> > > "microchip,suspend-smc-id". if present, then the syscon regmap is not
> > > used to enter suspend and a SMC is issued.
> > > 
> > > Signed-off-by: Cl?ment L?ger <clement.leger@bootlin.com>
> > > ---  
> > 
> > Acked-by: Alan Stern <stern@rowland.harvard.edu>
> > 
> > However, this is a little weird...  You've written 
> > usb_hcd_at91_probe() so that the SMC is detected in preference to the 
> > regmap, but then you wrote ohci_at91_port_suspend() so that the regmap 
> > is used in preference to the SMC.  It's not wrong, but it is confusing 
> > to read.
> > 
> > Do you want to rewrite the patch to make the two routines agree on which 
> > mechanism to use by default?
> > 
> > Alan Stern
> 
> Hi Alan,
> 
> I'll rewrite that ! I did it in this specific order in the probe to
> allow overloading the device-tree with a SMC ID without removing the
> syscon property. This way, the regmap stays the default if no
> "microchip,suspend-smc-id" property is provided.
> 
> Does it sounds good to you ?

Sure.  Just make ohci_at91_port_suspend() try to use the SMC first, and 
then use the regmap only if the SMC ID hasn't been set.

Alan Stern